On Fri, 11 Mar 2022 13:23:23 GMT, Zhengyu Gu wrote:
>> The changes to the usages in src/java.base look okay.
>
> Thanks, @AlanBateman @dfuch
@zhengyu123 - why did you ignore the request to wait for a client reviewer ?
Over half the files touched are in client ? Might I ask what tests you ran ?
On Fri, 11 Mar 2022 10:33:29 GMT, Alan Bateman wrote:
>> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
>> calls, should be a `jboolean*` instead of a `jboolean`.
>
> The changes to the usages in src/java.base look okay.
> Thanks, @AlanBateman @dfuch
but make sure to
On Fri, 11 Mar 2022 10:33:29 GMT, Alan Bateman wrote:
>> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
>> calls, should be a `jboolean*` instead of a `jboolean`.
>
> The changes to the usages in src/java.base look okay.
Thanks, @AlanBateman @dfuch
-
PR:
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
Marked as reviewed by dfuchs (Reviewer).
The `libnet` changes look good to me - but please get someone from
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
The changes to the usages in src/java.base look okay.
-
Marked as reviewed by alanb (Reviewer).
Another trivial cleanup to fix the last parameter of `GetStringXXXChars` calls,
should be a `jboolean*` instead of a `jboolean`.
-
Commit messages:
- Fix
- 8282978: Wrong parameter passed to GetStringXXXChars in various places
Changes:
