On Thu, 9 Jun 2022 11:27:19 GMT, Daniel Fuchs wrote:
> We need to close the stream after the exchange has terminated, but the
> exchange will not be considered to be terminated if we have a request body
> and the request body has not been sent.
That answers it. Thank you.
-
PR: h
On Thu, 9 Jun 2022 11:15:14 GMT, Jaikiran Pai wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8286171: Added teardown method and comments
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 3
On Thu, 9 Jun 2022 11:26:52 GMT, Jaikiran Pai wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 308:
>>
>>> 306: // Have to mark request as sent, due to no request body being
>>> sent
>>> 307: // in the event of a 417 Expectation Failed
>>> 308:
On Thu, 9 Jun 2022 11:09:23 GMT, Conor Cleary wrote:
>> Yes - good catch!
>
> Good suggestion, no need for it to be public. Will do.
I made this change but added protected by mistake instead of just removing the
modifier. Will fix in subsequent change
-
PR: https://git.openjdk.jav
On Thu, 9 Jun 2022 11:06:11 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http1Response.java
>> line 424:
>>
>>> 422: }
>>> 423:
>>> 424: public void closeWhenFinished() {
>>
>> Hello Conor, do you think it might be better if we make this package pr
On Thu, 9 Jun 2022 11:10:11 GMT, Jaikiran Pai wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8286171: Added teardown method and comments
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http1Exchange.java
On Thu, 9 Jun 2022 11:19:04 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http1Exchange.java
>> line 862:
>>
>>> 860: // Sets a flag which closes the connection locally when
>>> 861: // onFinished() is called
>>> 862: respo
On Thu, 9 Jun 2022 10:31:31 GMT, Conor Cleary wrote:
>> **Issue**
>> It was observed that when the httpclient sends a POST request with the
>> `Expect: 100 Continue` header set and the server replies with a response
>> code `417 Expectation Failed` that the httpclient hangs indefinitely when
>
On Thu, 9 Jun 2022 10:31:31 GMT, Conor Cleary wrote:
>> **Issue**
>> It was observed that when the httpclient sends a POST request with the
>> `Expect: 100 Continue` header set and the server replies with a response
>> code `417 Expectation Failed` that the httpclient hangs indefinitely when
>
On Thu, 9 Jun 2022 10:31:31 GMT, Conor Cleary wrote:
>> **Issue**
>> It was observed that when the httpclient sends a POST request with the
>> `Expect: 100 Continue` header set and the server replies with a response
>> code `417 Expectation Failed` that the httpclient hangs indefinitely when
>
> **Issue**
> It was observed that when the httpclient sends a POST request with the
> `Expect: 100 Continue` header set and the server replies with a response code
> `417 Expectation Failed` that the httpclient hangs indefinitely when the
> version of Http used is HTTP/2. However, it was also s
11 matches
Mail list logo
