Re: RFR: 8286873: Improve websocket test execution time [v3]

2022-05-19 Thread Pavel Rappo
On Thu, 19 May 2022 12:05:45 GMT, Daniel Jeliński wrote: >> This PR improves the execution time of jdk_net tests (and, by extension, >> tier2) by about 3 minutes. >> >> Tests located under `jdk/java/net/httpclient/websocket` are never run in >> parallel. Each of the 8 modified `Pending***` tes

Re: RFR: 8286873: Improve websocket test execution time [v3]

2022-05-19 Thread Daniel Jeliński
On Thu, 19 May 2022 10:46:35 GMT, Pavel Rappo wrote: > > > What looks questionable is rearrangement of asserts: when `assertHangs` > > > moves down. assertNotDone(cfClose) can transitorry pass even if ping has > > > not hung. > > > > > > `assertHangs` either waits for 5 seconds or throws an e

Re: RFR: 8286873: Improve websocket test execution time [v3]

2022-05-19 Thread Daniel Jeliński
> This PR improves the execution time of jdk_net tests (and, by extension, > tier2) by about 3 minutes. > > Tests located under `jdk/java/net/httpclient/websocket` are never run in > parallel. Each of the 8 modified `Pending***` tests originally required 40 > seconds to complete. After the prop