> On May 24, 2021, at 10:39 AM, Mark Sheppard wrote:
>
> I could have used return directly in multiple places ... but my style
> preference is a single exit point from a method
My preference is the opposite :-) I like the "early returns" coding style
because I don't need to "keep state"
On Mon, 24 May 2021 12:30:38 GMT, Mark Sheppard wrote:
>> The test java/net/Socket/UdpSocket.java has been seen to fail with a
>> BindException, in the testMaxSockets test, on a regular basis on
>> macOS-aarch64 platform. testMaxSockets tests the maximum number of UDP
>> Sockets that may be
On Mon, 24 May 2021 14:34:54 GMT, Mark Sheppard wrote:
>> Mark Sheppard has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8265362 java/net/Socket/UdpSocket.java fails with
>> "java.net.BindException: Address already in use"
On Mon, 24 May 2021 12:30:38 GMT, Mark Sheppard wrote:
>> The test java/net/Socket/UdpSocket.java has been seen to fail with a
>> BindException, in the testMaxSockets test, on a regular basis on
>> macOS-aarch64 platform. testMaxSockets tests the maximum number of UDP
>> Sockets that may be
On Mon, 24 May 2021 12:30:38 GMT, Mark Sheppard wrote:
>> The test java/net/Socket/UdpSocket.java has been seen to fail with a
>> BindException, in the testMaxSockets test, on a regular basis on
>> macOS-aarch64 platform. testMaxSockets tests the maximum number of UDP
>> Sockets that may be
On Sat, 22 May 2021 10:54:06 GMT, Mark Sheppard wrote:
>> BTW: Is one retry enough? There is at least one other replace where we've
>> had to retry to workaround a macOS bug and one retry was enough there too.
>
> I have submitted a significant number of MACH5 job runs with repeat mode over
>
> The test java/net/Socket/UdpSocket.java has been seen to fail with a
> BindException, in the testMaxSockets test, on a regular basis on
> macOS-aarch64 platform. testMaxSockets tests the maximum number of UDP
> Sockets that may be created as defined by a system property
>
On Sat, 22 May 2021 06:46:18 GMT, Alan Bateman wrote:
>> Thanks, and if you want to keep it consistent with the existing code then
>> you could rename "Socket newUdpSocket" and "biEx", or just change it to
>> "return new Socket(...)".
>
> BTW: Is one retry enough? There is at least one other
On Sat, 22 May 2021 06:45:33 GMT, Alan Bateman wrote:
>> yes, thanks for that ... updated as requested
>
> Thanks, and if you want to keep it consistent with the existing code then you
> could rename "Socket newUdpSocket" and "biEx", or just change it to "return
> new Socket(...)".
BTW: Is
On Fri, 21 May 2021 17:00:11 GMT, Mark Sheppard wrote:
>> test/jdk/java/net/Socket/UdpSocket.java line 151:
>>
>>> 149: }
>>> 150: }
>>> 151: return newUdpSocket;
>>
>> I added this test in advance of JEP 353 as we didn't have much coverage for
>> this deprecated
On Tue, 18 May 2021 22:43:14 GMT, Mark Sheppard wrote:
> The test java/net/Socket/UdpSocket.java has been seen to fail with a
> BindException, in the testMaxSockets test, on a regular basis on
> macOS-aarch64 platform. testMaxSockets tests the maximum number of UDP
> Sockets that may be
The test java/net/Socket/UdpSocket.java has been seen to fail with a
BindException, in the testMaxSockets test, on a regular basis on macOS-aarch64
platform. testMaxSockets tests the maximum number of UDP Sockets that may be
created as defined by a system property sun.net.maxDatagramSockets. It
On Wed, 19 May 2021 05:56:07 GMT, Alan Bateman wrote:
>> The test java/net/Socket/UdpSocket.java has been seen to fail with a
>> BindException, in the testMaxSockets test, on a regular basis on
>> macOS-aarch64 platform. testMaxSockets tests the maximum number of UDP
>> Sockets that may be
On Tue, 18 May 2021 22:43:14 GMT, Mark Sheppard wrote:
> The test java/net/Socket/UdpSocket.java has been seen to fail with a
> BindException, in the testMaxSockets test, on a regular basis on
> macOS-aarch64 platform. testMaxSockets tests the maximum number of UDP
> Sockets that may be
14 matches
Mail list logo
