Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-30 Thread Michael McMahon
On Thu, 30 Sep 2021 09:05:41 GMT, Daniel Fuchs wrote: >> I think it would be simpler to replace lines 101-103 just with >> `trans.close()` > > Strictly speaking to preserve the current behavior - that would be > `trans.getResponseBody().close();` isn't it? HttpExchange.close() calls the close

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-30 Thread Daniel Fuchs
On Wed, 29 Sep 2021 19:24:36 GMT, Michael McMahon wrote: >> Hi @Michael-Mc-Mahon , In my understanding purpose of this block is to >> return a file with no contents.(Empty file). > > I think it would be simpler to replace lines 101-103 just with `trans.close()` Strictly speaking to preserve the

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-29 Thread Michael McMahon
On Wed, 29 Sep 2021 13:45:43 GMT, Mahendra Chhipa wrote: >> test/jdk/sun/net/www/protocol/http/B6296310.java line 103: >> >>> 101: try(PrintWriter pw = new >>> PrintWriter(trans.getResponseBody())) { >>> 102: pw.print(""); >>> 103: } >> >> Not sure what the purpo

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-29 Thread Mahendra Chhipa
On Wed, 29 Sep 2021 10:54:52 GMT, Michael McMahon wrote: >> Mahendra Chhipa has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-29 Thread Michael McMahon
On Wed, 22 Sep 2021 21:05:34 GMT, Mahendra Chhipa wrote: >> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed >> from following tests: >> open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java >> open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.j

Re: RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

2021-09-22 Thread Mahendra Chhipa
> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed > from following tests: > open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java > open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java > open/test/jdk/sun/net/www/protocol/http/RelativeRedirect.j