Re: RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-28 Thread Volker Simonis
Hi Alan, Chris, thanks for the review. I've just pushed the change with the additions proposed by you (I also removed the similar blocks/comments in PlainSocketImpl.c). Regards, Volker On Fri, Feb 28, 2014 at 3:14 PM, Alan Bateman wrote: > On 28/02/2014 14:08, Chris Hegarty wrote: >> >> Volker

Re: RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-28 Thread Alan Bateman
On 28/02/2014 14:08, Chris Hegarty wrote: Volker, The changes look fine to me, and in line with what I was thinking too. Quite trivially you can remove the block '{' from net_util_md.c Line 1637 and 1650. Also, the function comment says "Wrapper for select/poll ..." ( can remove 'select' ).

Re: RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-28 Thread Chris Hegarty
Volker, The changes look fine to me, and in line with what I was thinking too. Quite trivially you can remove the block '{' from net_util_md.c Line 1637 and 1650. Also, the function comment says "Wrapper for select/poll ..." ( can remove 'select' ). I ran your patch through our internal buil

RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-27 Thread Volker Simonis
Hi, could you please review the following clean-up change (for a better formatted description please see the webrev): http://cr.openjdk.java.net/~simonis/webrevs/8035949/ https://bugs.openjdk.java.net/browse/JDK-8035949 This change removes some unused code and macros from src/solaris/native/java