dev <net-dev@openjdk.java.net>
Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently
returns null for
MAC address
On 23/06/17 10:56, Seán Coffey wrote:
Thanks to Christoph, Vyom and Mark for the reviews.
I've improved the testcase as per feedback. Hope this meets all
stoph.lan...@sap.com>
Cc: net-dev <net-dev@openjdk.java.net>
Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently
returns null for
MAC address
On 23/06/17 10:56, Seán Coffey wrote:
Thanks to Christoph, Vyom and Mark for the reviews.
I've improved the testcase as per feedback. H
Hi Chris,
test looks good, one minor comment can be ignored, in failing case it
print stack and "Exception in thread "main" java.lang.RuntimeException:
Failed" both. I can see main is declared to throw Exception. Is is
possible to throw exception instead of printing trace or pass this
penjdk.java.net>
Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently returns null for
MAC address
On 23/06/17 10:56, Seán Coffey wrote:
Thanks to Christoph, Vyom and Mark for the reviews.
I've improved the testcase as per feedback. Hope this meets all requests :
http://cr.openjdk
Langer, Christoph
> <christoph.lan...@sap.com>
> Cc: net-dev <net-dev@openjdk.java.net>
> Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently returns null
> for
> MAC address
>
>
>
> On 23/06/17 10:56, Seán Coffey wrote:
> > Thanks to Christoph, Vy
On 23/06/17 10:56, Seán Coffey wrote:
Thanks to Christoph, Vyom and Mark for the reviews.
I've improved the testcase as per feedback. Hope this meets all requests :
http://cr.openjdk.java.net/~coffeys/webrev.8182672.jdk10.v2/webrev/
The change looks good.
Sean and I did a live coding
<vyom.tew...@oracle.com>; net-dev
Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently
returns null for
MAC address
Hi Vyom,
thanks for testing. Null is a valid value for some interfaces. I've
excluded the loopback interface from being testing. Perhaps there's
other issues at pla
a.net>; Mark Sheppard <mark.shepp...@oracle.com>
> Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently returns null
> for
> MAC address
>
> Thanks to Christoph, Vyom and Mark for the reviews.
>
> I've improved the testcase as per feedback. Hope this meets al
et-dev
Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently returns null for
MAC address
Hi Vyom,
thanks for testing. Null is a valid value for some interfaces. I've
excluded the loopback interface from being testing. Perhaps there's
other issues at play here. We know that getHardwareA
Hi Sean,
i debug the failure and it look like you need to modify your test and
make it more robust. As Christoph suggested first call
"getHardwareAddress" and check if is not null then only iterate 100
time. This way your test will run on any platform and one minor comment
make your global
i 2017 20:17
> To: Vyom Tewari <vyom.tew...@oracle.com>; net-dev d...@openjdk.java.net>
> Subject: Re: RFR : 8182672: Java 8u121 on Linux intermittently returns null
> for
> MAC address
>
> Hi Vyom,
>
> thanks for testing. Null is a valid value for some interfaces
Hi Sean,
main change looks fine - it sorts the reported problem.
ran your test against jdk8 152 and a recent jdk9 builds to verify that
your test failure occurs.
The failure is seen, together with an additional (intermittent) exception:
java.net.SocketException: No such device
Hi Vyom,
thanks for testing. Null is a valid value for some interfaces. I've
excluded the loopback interface from being testing. Perhaps there's
other issues at play here. We know that getHardwareAddress() can throw
SocketException if I/O fails. For this particular scenario we're not
: Seán Coffey [mailto:sean.cof...@oracle.com]
> Sent: Donnerstag, 22. Juni 2017 18:29
> To: OpenJDK Network Dev list <net-dev@openjdk.java.net>; Langer,
> Christoph <christoph.lan...@sap.com>
> Subject: RFR : 8182672: Java 8u121 on Linux intermittently returns null for
> MAC
Hi Sean,
with your patch as well your test case is failing on my
laptop(Ubuntu16.04), when i tried to run on jdk8 i am getting below error.
java.net.SocketException: No such device (ioctl(SIOCGIFHWADDR) failed)
at java.net.NetworkInterface.getMacAddr0(Native Method)
at
JDK 10 fix required to correct a race issue in NetworkInterface. I don't
believe the ifreq struct needs to be static in any case. New auto unit
testcase also. I propose to skip this fix for JDK 9 and fix in an update
release for that family. I also plan to port this to jdk8u-dev.
16 matches
Mail list logo
