Thanks for the updates, Chris. This looks fine to me (I'm not a reviewer).
-Jaikiran
On 07/08/18 3:22 PM, Chris Hegarty wrote:
>> On 4 Aug 2018, at 14:08, Jaikiran Pai wrote:
>>
>> ...
>>
>> Do you think this can be reworded a bit? Although I understand what's
>> being said here, the wording
The updated webrev looks fine to me, Chris.
Thanks,
Michael
On 07/08/2018, 10:52, Chris Hegarty wrote:
On 4 Aug 2018, at 14:08, Jaikiran Pai wrote:
...
Do you think this can be reworded a bit? Although I understand what's
being said here, the wording doesn't seem right. Maybe something
> On 4 Aug 2018, at 14:08, Jaikiran Pai wrote:
>
> ...
>
> Do you think this can be reworded a bit? Although I understand what's
> being said here, the wording doesn't seem right. Maybe something like:
>
> * In the case where a new connection needs to be
> established, if
>
Hi Chris,
src/java.net.http/share/classes/java/net/http/HttpClient.java
+ * In the case where a new connection needs to be
established, if
+ * the connection cannot be established within the given {@code
+ * duration}, then an {@link HttpConnectTimeoutException} is
Hi,
This is a code review to add connection specific timeout support to the
new HTTP Client, as discussed recently over on another thread [1].
The connection timeout duration is proposed to be added at the level of
the client, and if specified applies to all requests sent by that
client. The
