Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi, We haven't changed anything related to the From header. Are you suggesting that "From" should be removed from the restricted list also? - Michael On 11/10/2018, 23:17, Thomas Lußnig wrote: Hi, i did an quick check of the change: From: - E-Mail-Adresse des Nutzers, der die Anfrage stel

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi, i did an quick check of the change: From: - E-Mail-Adresse des Nutzers, der die Anfrage stellte (heute unüblich). RFC 2616 sagt hierzu, dass der |From:| /nicht/ ohne ausdrückliche Genehmigung des Nutzers gesendet werden darf. Why this is now allowed

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

> On 11 Oct 2018, at 18:05, Daniel Fuchs wrote: > > Hi Michael, > > On 11/10/2018 17:36, Michael McMahon wrote: >> Hi Daniel, >> I was allowing for the possibility that the implementation might silently >> discard the header. In that case, the server would send the 500 response >> after detec

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi Michael, On 11/10/2018 17:36, Michael McMahon wrote: Hi Daniel, I was allowing for the possibility that the implementation might silently discard the header. In that case, the server would send the 500 response after detecting the "Via" header. I would agree if that was a JCK test, but her

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi Daniel, I was allowing for the possibility that the implementation might silently discard the header. In that case, the server would send the 500 response after detecting the "Via" header. - Michael. On 11/10/2018, 17:32, Daniel Fuchs wrote: Hi Michael, Why the test: 219 if (

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Hi Michael, Why the test: 219 if (response.statusCode() != 200) 220 throw new RuntimeException("illegal header was sent in request"); Shouldn't this always throw, regardless of the status code? best regards, -- daniel On 11/10/2018 16:56, Michael McMahon wrot

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Thanks Daniel. I updated that test with some new scenarios for end to end testing. http://cr.openjdk.java.net/~michaelm/8203850/webrev.2/ Michael On 11/10/2018, 13:58, Daniel Fuchs wrote: Looks good to me Michael. You should be able to easily add new test cases for Origin and Referer to test

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

> On 11 Oct 2018, at 13:58, Daniel Fuchs wrote: > > Looks good to me Michael. > > You should be able to easily add new test cases for Origin and > Referer to test/jdk/java/net/SpecialHeadersTest.java too. +1 -Chris.

Re: RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Looks good to me Michael. You should be able to easily add new test cases for Origin and Referer to test/jdk/java/net/SpecialHeadersTest.java too. best regards, -- daniel On 11/10/2018 13:28, Michael McMahon wrote: Could I get the following fix reviewed please? http://cr.openjdk.java.net/~mi

RFR [12]: 8203850: java.net.http HTTP client should allow specifying Origin and Referer headers

Could I get the following fix reviewed please? http://cr.openjdk.java.net/~michaelm/8203850/webrev.1/ Thanks, Michael