> On 21 Dec 2019, at 08:23, Alan Bateman wrote:
>
> On 20/12/2019 22:34, Chris Hegarty wrote:
>>
>> Thanks Alan,
>>
>> 1) I updated the file descriptor check from ` > 0` to ` >= 0`
>> 2) Removed the pre-existing incorrect comment, and
>> 3) Added a few more test scenarios that check the index
On 20/12/2019 22:34, Chris Hegarty wrote:
Thanks Alan,
1) I updated the file descriptor check from ` > 0` to ` >= 0`
2) Removed the pre-existing incorrect comment, and
3) Added a few more test scenarios that check the index = 0 cases
Updated webrev:
https://cr.openjdk.java.net/~chegar/8236441/
> On 20 Dec 2019, at 20:17, Alan Bateman wrote:
>
>> ...
> This looks okay to me. There are a few inconsistencies in this code in that
> some places it checks if fd1 >= 0, others != -1 but I don't think there are
> correctness issues. You probably don't need to check ipv6_supported as fd1
>
On 20/12/2019 17:53, Chris Hegarty wrote:
The MulticastSocket implementation on Windows uses the two stacks
implementation. The two stacks implementation creates a socket on the
IPv4 stack and another on the IPv6 stack. Operations are then performed
on both sockets as appropriate. If the socket i
The MulticastSocket implementation on Windows uses the two stacks
implementation. The two stacks implementation creates a socket on the
IPv4 stack and another on the IPv6 stack. Operations are then performed
on both sockets as appropriate. If the socket is bound to a specific
address, then the IP v
