RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-09 Thread Ivan Gerasimov
Hello all! The MemLeakTest had been added with the fix for 8022584. Since that, the test was reported to fail intermittently, even though the leak was eliminated. I couldn't ever reproduce the failure even on the machines where the failure was detected. Here are the changes I propose: - Inc

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-09 Thread Alan Bateman
This looks like one for the net-dev list. On 09/10/2013 09:10, Ivan Gerasimov wrote: Hello all! The MemLeakTest had been added with the fix for 8022584. Since that, the test was reported to fail intermittently, even though the leak was eliminated. I couldn't ever reproduce the failure even

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-09 Thread Chris Hegarty
Do you have a sense of how long this test runs for, on an average machine, with the extra iterations? -Chris. On 09/10/2013 09:24, Ivan Gerasimov wrote: Hello all! The MemLeakTest had been added with the fix for 8022584. Since that, the test was reported to fail intermittently, even though th

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-10 Thread Ivan Gerasimov
Hi Chris! I've run the test on JPRT and it took 84, 99 and 146 seconds on three different machines. When I run it locally in the virtualbox, it takes approximately 300 seconds. Please note that even though the number of iterations was increased by 3.5 times, now only one NetworkInterface is a

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-11 Thread Ivan Gerasimov
On 10.10.2013 15:52, Ivan Gerasimov wrote: Hi Chris! I've run the test on JPRT and it took 84, 99 and 146 seconds on three different machines. When I run it locally in the virtualbox, it takes approximately 300 seconds. Please note that even though the number of iterations was increased by

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-14 Thread Chris Hegarty
I'm really not sure that the effort this test is going to is really necessary here ( to verify such a minor leak ). I'd be happy to see the test simply removed. Other opinions? -Chris. On 11/10/2013 20:24, Ivan Gerasimov wrote: On 10.10.2013 15:52, Ivan Gerasimov wrote: Hi Chris! I've run

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-15 Thread Ivan Gerasimov
On 14.10.2013 14:28, Chris Hegarty wrote: I'm really not sure that the effort this test is going to is really necessary here ( to verify such a minor leak ). I'd be happy to see the test simply removed. Other opinions? I agree. I only regret that this method of measurement of native memory

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-15 Thread Chris Hegarty
On 10/15/2013 11:19 AM, Ivan Gerasimov wrote: On 14.10.2013 14:28, Chris Hegarty wrote: I'm really not sure that the effort this test is going to is really necessary here ( to verify such a minor leak ). I'd be happy to see the test simply removed. Other opinions? I agree. I only regret tha

Re: RFR [8023390] Test java/net/NetworkInterface/MemLeakTest.java failed

2013-10-15 Thread Ivan Gerasimov
Thank you Chris! Here's the exported patch with the test removal: http://cr.openjdk.java.net/~igerasim/2commit/8023390-jdk8-remove-MemLeakTest.patch Sincerely yours, Ivan Gerasimov On 15.10.2013 16:54, Chris Hegarty wrote: On 10/15/2013 11:19 AM, Ivan Gerasimov wrote: On 14.10.2013 14:28, C