On 24/08/16 13:18, Svetlana Nikandrova wrote:
...
Hello,
please review this fix. Javadoc for HttpCookie setMaxAge states that
" A negative value means that cookie is not stored persistently" and
"max age is unspecified", but hasExpired only checks for "-1" as
possible negative value. Also
Reminder.
It's a little change and won't take much time to look into.
Thanks,
Svetlana
On 22.08.2016 20:33, Svetlana Nikandrova wrote:
Kindly reminder
On 19.08.2016 16:30, Svetlana Nikandrova wrote:
Hello,
please review this fix. Javadoc for HttpCookie setMaxAge states that
" A negative
Kindly reminder
On 19.08.2016 16:30, Svetlana Nikandrova wrote:
Hello,
please review this fix. Javadoc for HttpCookie setMaxAge states that "
A negative value means that cookie is not stored persistently" and
"max age is unspecified", but hasExpired only checks for "-1" as
possible negative
Hello,
please review this fix. Javadoc for HttpCookie setMaxAge states that " A
negative value means that cookie is not stored persistently" and "max
age is unspecified", but hasExpired only checks for "-1" as possible
negative value. Also changed max age for parsed cookies with "expires"
Hi Rob,
The changes look fine. ( Trivially the copyright year on the test should
be 2013 ).
Coming so late in the JDK8 development cycle, only P1-3 bugs are being
accepted [1]. I see this is a P4. Should it be deferred to the next
available minor update, or do you think it warrants being
Thanks Chris,
I don't mind deferring. Nobody is shouting at me to get this fixed at
the moment.
-Rob
On 21/10/13 16:21, Chris Hegarty wrote:
Hi Rob,
The changes look fine. ( Trivially the copyright year on the test
should be 2013 ).
Coming so late in the JDK8 development cycle, only
On 10/21/2013 05:05 PM, Rob McKenna wrote:
Thanks Chris,
I don't mind deferring. Nobody is shouting at me to get this fixed at
the moment.
OK, thanks. If this is just clearing the plate before ZBB, then simply
target to tbd_minor and archive the webrev/diffs for future.
-Chris.
Hi folks,
Simple enough change here. As per the description HttpCookie.setMaxAge
will set any arbitrary negative value, while we only check for
MAX_AGE_UNSPECIFIED to determine whether a cookies max age has been
specified or not. This fix sets maxAge to MAX_AGE_UNSPECIFIED if the