Re: RFR JDK-4880778

2013-02-04 Thread Chris Hegarty
@openjdk.java.net Sent: Monday, February 4, 2013 11:19:42 AM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK-4880778 Thanks John, Trivially, and unrelated to your changes but while you're there, I would really like to remove "are supposed to". < * Only classes derived from UR

Re: RFR JDK-4880778

2013-02-04 Thread John Zavgren
: Re: RFR JDK-4880778 Thanks John, Trivially, and unrelated to your changes but while you're there, I would really like to remove "are supposed to". < * Only classes derived from URLStreamHandler are supposed to be able < * to use this method to set the values of the URL

Re: RFR JDK-4880778

2013-02-04 Thread Chris Hegarty
@openjdk.java.net Sent: Saturday, February 2, 2013 9:47:31 AM GMT -05:00 US/Canada Eastern Subject: RFR JDK-4880778 Greetings: Please consider the following modification of our classes for handling URLs. http://cr.openjdk.java.net/~jzavgren/4880778/webrev.01/ background See http://java.sun.

Re: RFR JDK-4880778

2013-02-04 Thread John Zavgren
ginal Message - From: john.zavg...@oracle.com To: net-dev@openjdk.java.net Sent: Saturday, February 2, 2013 9:47:31 AM GMT -05:00 US/Canada Eastern Subject: RFR JDK-4880778 Greetings: Please consider the following modification of our classes for handling URLs. http://cr.openjdk.java.net/~jza

Re: RFR JDK-4880778

2013-02-04 Thread Chris Hegarty
On 02/02/2013 16:29, Alan Bateman wrote: On 02/02/2013 14:39, John Zavgren wrote: Greetings: Please consider the following modification of our classes for handling URLs. http://cr.openjdk.java.net/~jzavgren/4880778/webrev.01/ This looks okay to me. Yes, looks ok to me too. For the URLSt

Re: RFR JDK-4880778

2013-02-02 Thread Alan Bateman
On 02/02/2013 14:39, John Zavgren wrote: Greetings: Please consider the following modification of our classes for handling URLs. http://cr.openjdk.java.net/~jzavgren/4880778/webrev.01/ This looks okay to me. For the URLStreamHandler setURL methods then an alternative to removing the statem

RFR JDK-4880778

2013-02-02 Thread John Zavgren
Greetings: Please consider the following modification of our classes for handling URLs. http://cr.openjdk.java.net/~jzavgren/4880778/webrev.01/ background See http://java.sun.com/j2se/1.4.2/docs/api/java/net/URL.html. The URL class is declared final yet has two protected methods: prot