Re: RFR JDK-8008804

2013-03-04 Thread Alan Bateman
On 04/03/2013 20:04, John Zavgren wrote: Alan: You are right... I corrected the error and posted a new webrev image: http://cr.openjdk.java.net/~jzavgren/8008804/webrev.03/ Looks okay to me. At point we need to change this code to use SOCKET (and jlong) but that's for another day. -Alan

Re: RFR JDK-8008804

2013-03-04 Thread John Zavgren
PM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK-8008804 On 04/03/2013 19:37, John Zavgren wrote: > Thanks for catching that Dmitry. I just posted a new webrev image for a > change that uses the correct procedure: > http://cr.openjdk.java.net/~jzavgren/8008804/webrev.02/ > > J

Re: RFR JDK-8008804

2013-03-04 Thread Alan Bateman
On 04/03/2013 19:37, John Zavgren wrote: Thanks for catching that Dmitry. I just posted a new webrev image for a change that uses the correct procedure: http://cr.openjdk.java.net/~jzavgren/8008804/webrev.02/ John Shouldn't this be closesocket (not socketclose)? -Alan.

Re: RFR JDK-8008804

2013-03-04 Thread Dmitry Samersoff
gt; - Original Message - > From: dmitry.samers...@oracle.com > To: john.zavg...@oracle.com > Cc: net-dev@openjdk.java.net > Sent: Monday, March 4, 2013 12:59:16 PM GMT -05:00 US/Canada Eastern > Subject: Re: RFR JDK-8008804 > > John, > > closesocket call should b

Re: RFR JDK-8008804

2013-03-04 Thread John Zavgren
Sent: Monday, March 4, 2013 12:59:16 PM GMT -05:00 US/Canada Eastern Subject: Re: RFR JDK-8008804 John, closesocket call should be here. -Dmitry On 2013-03-04 20:12, John Zavgren wrote: > Greetings: > > I posted a webrev image for a modification that eliminates a file descriptor > lea

Re: RFR JDK-8008804

2013-03-04 Thread Dmitry Samersoff
John, closesocket call should be here. -Dmitry On 2013-03-04 20:12, John Zavgren wrote: > Greetings: > > I posted a webrev image for a modification that eliminates a file descriptor > leak. > > http://cr.openjdk.java.net/~jzavgren/8008804/webrev.01/ > > Thanks! > John > -- Dmitry Samerso

Re: RFR JDK-8008804

2013-03-04 Thread Chris Hegarty
On 03/04/2013 04:51 PM, Alan Bateman wrote: On 04/03/2013 16:12, John Zavgren wrote: Greetings: I posted a webrev image for a modification that eliminates a file descriptor leak. http://cr.openjdk.java.net/~jzavgren/8008804/webrev.01/ Thanks! John Isn't this a SOCKET rather than a file descr

Re: RFR JDK-8008804

2013-03-04 Thread Alan Bateman
On 04/03/2013 16:12, John Zavgren wrote: Greetings: I posted a webrev image for a modification that eliminates a file descriptor leak. http://cr.openjdk.java.net/~jzavgren/8008804/webrev.01/ Thanks! John Isn't this a SOCKET rather than a file descriptor, in which case it should be closesocke

RFR JDK-8008804

2013-03-04 Thread John Zavgren
Greetings: I posted a webrev image for a modification that eliminates a file descriptor leak. http://cr.openjdk.java.net/~jzavgren/8008804/webrev.01/ Thanks! John