Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-06-12 Thread Alan Bateman
On 11/06/2016 08:59, John Jiang wrote: Hi, Just restarted this job. On 2016/4/29 15:34, Alan Bateman wrote: On 28/04/2016 05:50, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from a

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-06-11 Thread John Jiang
Hi, Just restarted this job. On 2016/4/29 15:34, Alan Bateman wrote: On 28/04/2016 05:50, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even tho

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-29 Thread Alan Bateman
On 28/04/2016 05:50, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even though some ones have to declare other modules. If a test has the @modules

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi Amy, That's case to case. If a test is using java.logging APIs directly, I declared the module for the test. Otherwise, I didn't. I think that may be more clear. Although a test is using jdk.httpserver, that doesn't mean it also dependents on java.logging. Best regards, John Jiang On 2016

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread Amy Lu
On 4/28/16 12:50 PM, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even though some ones have to declare other modules. + * @modules jdk.httpser

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even though some ones have to declare other modules. Best regards, John Jiang On 2016/4/27 23:07, John Jiang wrote:

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi Alan, Felix, Thanks for your comments. Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.01/ Best regards, John Jiang On 2016/4/27 15:08, John Jiang wrote: Hi, Please review the fix for explicitly declaring module dependencies for java net tests. Issue

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread Alan Bateman
On 27/04/2016 08:08, John Jiang wrote: Hi, Please review the fix for explicitly declaring module dependencies for java net tests. Issue: https://bugs.openjdk.java.net/browse/JDK-8151913 Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00 Since every test in test/java/net/httpclient/*

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread Chris Hegarty
On 27 Apr 2016, at 08:08, John Jiang wrote: > Hi, > Please review the fix for explicitly declaring module dependencies for java > net tests. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8151913 > Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00 This looks ok to me. Thanks,

RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi, Please review the fix for explicitly declaring module dependencies for java net tests. Issue: https://bugs.openjdk.java.net/browse/JDK-8151913 Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00 Best regards, John Jiang