Re: RFR JDK-8161091 Incorrect Stream.FlowControl implementation allows to send DataFrame even when window size was exhausted

2016-07-19 Thread Sergey Kuksenko
Who could sponsor this? On 07/14/2016 07:53 AM, Chris Hegarty wrote: On 11 Jul 2016, at 23:47, Sergey Kuksenko wrote: I am awfully sorry, previous fix was incorrect. Please, review the right version: http://cr.openjdk.java.net/~skuksenko/jep110/8161091/webrev.01/

Re: RFR JDK-8161091 Incorrect Stream.FlowControl implementation allows to send DataFrame even when window size was exhausted

2016-07-14 Thread Chris Hegarty
> On 11 Jul 2016, at 23:47, Sergey Kuksenko wrote: > > I am awfully sorry, previous fix was incorrect. > Please, review the right version: > http://cr.openjdk.java.net/~skuksenko/jep110/8161091/webrev.01/ Looks good. Thanks Sergey. -Chris. > On 07/08/2016 02:40

Re: RFR JDK-8161091 Incorrect Stream.FlowControl implementation allows to send DataFrame even when window size was exhausted

2016-07-14 Thread Roger Riggs
+1, The revised fix looks correct. Roger On 7/11/2016 6:47 PM, Sergey Kuksenko wrote: I am awfully sorry, previous fix was incorrect. Please, review the right version: http://cr.openjdk.java.net/~skuksenko/jep110/8161091/webrev.01/ On 07/08/2016 02:40 PM, Sergey Kuksenko wrote: Hi, Could

Re: RFR JDK-8161091 Incorrect Stream.FlowControl implementation allows to send DataFrame even when window size was exhausted

2016-07-11 Thread Sergey Kuksenko
I am awfully sorry, previous fix was incorrect. Please, review the right version: http://cr.openjdk.java.net/~skuksenko/jep110/8161091/webrev.01/ On 07/08/2016 02:40 PM, Sergey Kuksenko wrote: Hi, Could you please review the following fix for JDK-8161091?

Re: RFR JDK-8161091 Incorrect Stream.FlowControl implementation allows to send DataFrame even when window size was exhausted

2016-07-08 Thread Brian Burkhalter
Hi Sergey, This is not my area of expertise so probably a second Reviewer would be in order here but the changes appear straightforward. On Jul 8, 2016, at 2:40 PM, Sergey Kuksenko wrote: > Could you please review the following fix for JDK-8161091? > >

RFR JDK-8161091 Incorrect Stream.FlowControl implementation allows to send DataFrame even when window size was exhausted

2016-07-08 Thread Sergey Kuksenko
Hi, Could you please review the following fix for JDK-8161091? http://cr.openjdk.java.net/~skuksenko/jep110/8161091/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8161091 Existing Stream.FlowControl implementation doesn't decrease amount of permits if requested amount is less than