On Wed, 9 Mar 2022 16:54:58 GMT, Daniel Fuchs wrote:
>> These changes make sure that pending requests are terminated if the selector
>> manager thread exits due to exceptions.
>> This includes:
>>1. completing CompletableFutures that were returned to the caller code
>>2. cancelling reque
On Thu, 10 Mar 2022 10:08:16 GMT, Jaikiran Pai wrote:
>> tryRelease can be called multiple time - it will only decrement the ref
>> counting once. It could happen when different threads notice that the
>> operation is finished (usually due to some exceptions being propagated) and
>> try concur
On Wed, 9 Mar 2022 12:09:48 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java
>> line 179:
>>
>>> 177: } catch (Throwable t) {
>>> 178: errorHandler.accept(command, t);
>>> 179: ASYNC_POOL.execute(co
On Wed, 9 Mar 2022 11:55:27 GMT, Daniel Fuchs wrote:
> Here we don't need to check whether it's been acquired because we know it's
> been acquired if we reach here.
Hello Daniel, may be I am misreading the diff but from what I can see, the
`acquire()` method now returns a `boolean` which we ar
> These changes make sure that pending requests are terminated if the selector
> manager thread exits due to exceptions.
> This includes:
>1. completing CompletableFutures that were returned to the caller code
>2. cancelling requests that are in flight
>3. calling onError on BodySubscr
