Re: Taking advantage of TCP Loopback fast path in Windows

2014-10-20 Thread Chris Hegarty
On 20 Oct 2014, at 20:01, Martin Sawicki (MS OPEN TECH) wrote: > > From: Alan Bateman [mailto:alan.bate...@oracle.com] > > The attribution line allows for multiple contributors to be listed. The > changes are now in jdk9/dev: > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/26e6402772c8 >

RE: Taking advantage of TCP Loopback fast path in Windows

2014-10-20 Thread Martin Sawicki (MS OPEN TECH)
From: Alan Bateman [mailto:alan.bate...@oracle.com] The attribution line allows for multiple contributors to be listed. The changes are now in jdk9/dev: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/26e6402772c8 Alan, thank you for your help with this. How would we go about getting this back-

Re: Taking advantage of TCP Loopback fast path in Windows

2014-10-19 Thread Alan Bateman
On 17/10/2014 18:34, Kirk Shoop (MS OPEN TECH) wrote: If you are okay with this then I will push it to the jdk9/dev forest listing you as the author. Valery and I both worked on this, but if only one author can be listed then use my name. The attribution line allows for multiple contribu

RE: Taking advantage of TCP Loopback fast path in Windows

2014-10-17 Thread Kirk Shoop (MS OPEN TECH)
From: Alan Bateman [mailto:alan.bate...@oracle.com] I've tweaked your patch a ting bit on a few minor issues. One is so that running with -Djdk.net.useTcpFastLoopback enables the setting. Another one is to just rename from fast_loopback to fastLoopback in a few places to keep it consistent. I a

Re: Taking advantage of TCP Loopback fast path in Windows

2014-10-15 Thread Alan Bateman
On 09/10/2014 18:10, Kirk Shoop (MS OPEN TECH) wrote: Here is the webrev with both changes: I've tweaked your patch a ting bit on a few minor issues. One is so that running with -Djdk.net.useTcpFastLoopback enables the setting. Another one is to just rename from fast_loopback to fastLoo

RE: Taking advantage of TCP Loopback fast path in Windows

2014-10-09 Thread Kirk Shoop (MS OPEN TECH)
From: nio-dev [mailto:nio-dev-boun...@openjdk.java.net] On Behalf Of Kirk Shoop (MS OPEN TECH) Sent: Tuesday, October 7, 2014 8:16 AM From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Tuesday, October 7, 2014 7:41 AM One that we need to decide on is the system property to enable this. You

RE: Taking advantage of TCP Loopback fast path in Windows

2014-10-07 Thread Kirk Shoop (MS OPEN TECH)
From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Tuesday, October 7, 2014 7:41 AM This looks much better and I can sponsor this. Thank you :) One that we need to decide on is the system property to enable this. You are currently using "windows.enableFastLocalTcpLoopback". In recent time

Re: Taking advantage of TCP Loopback fast path in Windows

2014-10-07 Thread Alan Bateman
On 02/10/2014 11:17, Kirk Shoop (MS OPEN TECH) wrote: : We tried the suggestions in this thread and the result is a much smaller patch that works as well as the previous patch. https://openjdkcontrib.blob.core.windows.net/tcploopback/webrev-20141002.zip GetVersionEx is not used and th

RE: Taking advantage of TCP Loopback fast path in Windows

2014-10-02 Thread Kirk Shoop (MS OPEN TECH)
From: Alan Bateman [mailto:alan.bate...@oracle.com] On 24/09/2014 19:21, Kirk Shoop (MS OPEN TECH) wrote: My memory is that setting it on the socket before calling listen did not work. However, we will try again and verify. It would be good

Re: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Alan Bateman
On 24/09/2014 19:21, Kirk Shoop (MS OPEN TECH) wrote: My memory is that setting it on the socket before calling listen did not work. However, we will try again and verify. It would be good to check, it may be that we just need to set it after the listen (in the case of listener oriented chan

RE: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Kirk Shoop (MS OPEN TECH)
interested. From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Wednesday, September 24, 2014 11:06 AM To: Kirk Shoop (MS OPEN TECH); Martin Sawicki (MS OPEN TECH); net-dev@openjdk.java.net Cc: Valery Kopylov (Akvelon); nio-dev Subject: Re: Taking advantage of TCP Loopback fast path in Windows On

Re: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Alan Bateman
On 24/09/2014 16:58, Kirk Shoop (MS OPEN TECH) wrote: SIO_LOOPBACK_FAST_PATH must be set on the socket passed to accept. The way I think about this is the socket instance passed to listen represents the port while the socket instance passed to accept represents a single TCP stream. SIO_LOOPBA

RE: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Kirk Shoop (MS OPEN TECH)
TECH) Subject: Re: Taking advantage of TCP Loopback fast path in Windows On 24/09/14 10:43, Michael McMahon wrote: On 24/09/14 08:50, Alan Bateman wrote: On 24/09/2014 02:19, Martin Sawicki (MS OPEN TECH) wrote: Hello We're proposing an improvement to the OpenJDK which enables users to

RE: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Kirk Shoop (MS OPEN TECH)
...@oracle.com] Sent: Wednesday, September 24, 2014 2:44 AM To: Alan Bateman; Martin Sawicki (MS OPEN TECH); net-dev@openjdk.java.net Cc: Valery Kopylov (Akvelon); nio-dev; Kirk Shoop (MS OPEN TECH) Subject: Re: Taking advantage of TCP Loopback fast path in Windows On 24/09/14 08:50, Alan Bateman wrote: On 24

RE: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Kirk Shoop (MS OPEN TECH)
Subject: Re: Taking advantage of TCP Loopback fast path in Windows On 24/09/2014 02:19, Martin Sawicki (MS OPEN TECH) wrote: Hello We're proposing an improvement to the OpenJDK which enables users to take advantage of the TCP loopback fast path mechanism in Windows for significantly h

Re: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Michael McMahon
On 24/09/14 10:43, Michael McMahon wrote: On 24/09/14 08:50, Alan Bateman wrote: On 24/09/2014 02:19, Martin Sawicki (MS OPEN TECH) wrote: Hello We’re proposing an improvement to the OpenJDK which enables users to take advantage of the TCP loopback fast path mechanism in Windows for signifi

Re: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Michael McMahon
On 24/09/14 08:50, Alan Bateman wrote: On 24/09/2014 02:19, Martin Sawicki (MS OPEN TECH) wrote: Hello We’re proposing an improvement to the OpenJDK which enables users to take advantage of the TCP loopback fast path mechanism in Windows for significantly higher performance of sockets whose

Re: Taking advantage of TCP Loopback fast path in Windows

2014-09-24 Thread Alan Bateman
On 24/09/2014 02:19, Martin Sawicki (MS OPEN TECH) wrote: Hello We're proposing an improvement to the OpenJDK which enables users to take advantage of the TCP loopback fast path mechanism in Windows for significantly higher performance of sockets whose both end points are on the same machine

Re: Taking advantage of TCP Loopback fast path in Windows

2014-09-23 Thread Kirk Shoop (MS OPEN TECH)
6:44 PM To: net-dev@openjdk.java.net Subject: Re: Taking advantage of TCP Loopback fast path in Windows Hello, Is the GetVersionEx the recommended way to check for this feature? (we had some trouble with manifests in the past and I think there is a new version helper api to query for minimum le

Re: Taking advantage of TCP Loopback fast path in Windows

2014-09-23 Thread Bernd Eckenfels
Hello, Is the GetVersionEx the recommended way to check for this feature? (we had some trouble with manifests in the past and I think there is a new version helper api to query for minimum levels?) Or would it easier to just try it and remeber the WSAEOPNOTSUPP? I see on MSDN the only reason why

RE: Taking advantage of TCP Loopback fast path in Windows

2014-09-23 Thread Martin Sawicki (MS OPEN TECH)
Hello We're proposing an improvement to the OpenJDK which enables users to take advantage of the TCP loopback fast path mechanism in Windows for significantly higher performance of sockets whose both end points are on the same machine. This is especially relevant in distributed server-side/clou