Xuelei,
Thanks for addressing my comments. This looks fine to me.
-Chris.
On 04/09/12 06:01, Xuelei Fan wrote:
webrev: http://cr.openjdk.java.net/~xuelei/7068321/webrev_spec.10/
On 9/3/2012 9:22 PM, Chris Hegarty wrote:
Xuelei,
This looks very good. Just a few minor comments:
-
Xuelei,
This looks very good. Just a few minor comments:
- SNIServerName hexes could be UPPERCASE, since it is a constant.
- Trivially, SNIHostName(String) calls IDN.toASCII(hostname) twice
It is not clear to me from this constructor whether it should
pass a hostname as understood by
Hi,
This is the spec review for JEP 114 [1].
webrev: http://cr.openjdk.java.net/~xuelei/7068321/webrev_spec.10/
Network team, per RFC 6066, the host_name in TLS SNI extension need to
be encoded in ASCII. In SNIHostName, to get the ASCII-Compatible
Encoding (ACE), java.net.IDN is used to
