Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2020-12-23 Thread Jamie Le Tual
> Users have been able to send ICMP packets without the need for root > privileges or the CAP_NET_RAW capability since at least kernel 3.11. > > For some time now, if the kernel parameter net.ipv4.ping_group_range included > the gid of a user sending an icmp packet with the IPPROTO_ICMP protocol

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2020-12-23 Thread Jamie Le Tual
On Tue, 22 Dec 2020 14:08:26 GMT, Alan Bateman wrote: > Adding support for SOCK_DGRAM/IPPROTO_ICMP(6) is good and I think is mostly > okay. The comments and the formatting is messy in several places and should > be cleaned up before the patch is sponsored. Alan, thanks for taking a look at the

Re: RFR: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows

2020-12-23 Thread Alan Bateman
On Mon, 30 Nov 2020 18:09:57 GMT, Mat Carter wrote: > Modified Windows specific loopback macros to support full range of loopback > addresses, commit message includes unit test data as there's no gtest's for > java libraries (only hotspot compiler) > > This is an expansion on the original fix

Re: RFR: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows

2020-12-23 Thread Mat Carter
On Wed, 23 Dec 2020 16:10:27 GMT, Alan Bateman wrote: >> Modified Windows specific loopback macros to support full range of loopback >> addresses, commit message includes unit test data as there's no gtest's for >> java libraries (only hotspot compiler) >> >> This is an expansion on the origin