Michael, Alan,
The timeout of 2 seconds would appear to be too small for busy systems.
Increase to 10 seconds (and add some extra debugging information if
failure).
http://cr.openjdk.java.net/~chegar/7020136/webrev.00/webrev/
-Chris.
On 02/24/11 11:11 AM, Alan Bateman wrote:
Chris Hegarty wrote:
Yeah, a little more love is required. I hope I've covered all your
concerns.
http://cr.openjdk.java.net/~chegar/7020136/webrev.01/webrev/
This looks much better. In the main method it doesn't look like you need
to catch
Changeset: c2c8f9c38fd1
Author:chegar
Date: 2011-02-24 12:57 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2c8f9c38fd1
7020136: java/net/URLConnection/RedirectLimit.java fails intermittently
Summary: Increase the socket timeout and clean up the test
Reviewed-by: alanb
!
Alan, Michael,
Trivially change getFdEntry() to ensure that the given fd is not =
fdCount since fdTable ( the array indexed by fd ) has only fdCount elements.
I'm not sure how anyone seen this bug in real life, but making this
simple change won't hurt and is strictly correct.
Changeset: 1f41e41ef2db
Author:chegar
Date: 2011-02-24 13:42 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f41e41ef2db
6849693: index of fdTable should be less than num. of fdTable in jdk7
Reviewed-by: alanb
! src/solaris/native/java/net/linux_close.c
Michael, Alan,
Some small cleanups to the use of scanf with specified string width. The
buffers should be sized large enough to handle the specified width and
the null terminator.
http://cr.openjdk.java.net/~chegar/7022269/webrev.00/webrev/
-Chris.
On 02/25/11 02:39 PM, Michael McMahon wrote:
Alan Bateman wrote:
Chris Hegarty wrote:
Michael, Alan,
Some small cleanups to the use of scanf with specified string width.
The buffers should be sized large enough to handle the specified
width and the null terminator.
http://cr.openjdk.java.net
Changeset: 29f25ba547fc
Author:chegar
Date: 2011-02-28 11:03 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/29f25ba547fc
7022269: clean up fscanf usage in Linux networking native code
Reviewed-by: michaelm, alanb
! src/solaris/native/java/net/NetworkInterface.c
!
/webrev/
-Chris.
On 03/ 1/11 02:00 AM, Charles Lee wrote:
On 03/01/2011 02:40 AM, Alan Bateman wrote:
Charles Lee wrote:
On 02/22/2011 05:43 PM, Chris Hegarty wrote:
Hi Chris,
any news for this issue? And where is CR 7021280?
I think there has been issues with bugs.sun.com recently and it's
Interesting... I would have guessed bmp would be supported too. It
doesn't appear to be specific to JarURLConnection, raw file urls also
exhibit the same behavior.
Wow, last time content-types.properties was meaningfully changed was
1999, when PNG was added! I don't have any specific objection
On 03/ 1/11 09:58 AM, Jing LV wrote:
Hello,
According to authority component RFC2396, if host name is a domain name
there should be no [ and ]. However if we put a hostname like
[www.abc.com] while creating a URI, it silently accept, no error is
reported. I suppose this is a bug. A testcase
Alan, Michael,
Trivially, embedded lists should be within the outer lists list item.
Remove unnecessary /li
http://cr.openjdk.java.net/~chegar/7018137/webrev.00/webrev/
-Chris.
Changeset: 7cfb0693eb33
Author:chegar
Date: 2011-03-03 16:44 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7cfb0693eb33
7018137: HTML4 compliance issues
Summary: move end list items tags to after nested list
Reviewed-by: alanb
! src/share/classes/java/net/URI.java
!
I think Alan mentioned it in an earlier mail, this is a legacy API and
not widely used. I can't say I've come across its use more than a
handful of times in more than 10 years.
If you have a small patch that resolves a particular issue then maybe we
should just proceed with getting it in.
Changeset: 63509149c027
Author:dl
Date: 2011-03-08 18:16 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63509149c027
7023006: Reduce unnecessary thread activity in ForkJoinPool
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/concurrent/ForkJoinPool.java
!
On 03/ 8/11 06:25 PM, Alex Lam S.L. wrote:
Under ForkJoinPool.java:
* readers must tolerate null slots. To avoid flailing during
should it be failing (extraneous l)?
I actually flagged this in my original review, but put it aside as I
guessed it was kinda correct. The array is sized large
On 08/03/2011 09:13, Jing LV wrote:
..
Hi Chris,
Thanks for reply. So as we see no objection for this issue, would
someone help to raise a bug in the bug system? So that we can apply the
patch and fix this 12-year problem.
I filed CR 7025938: Add bitmap mime type to
Alan, Michael,
In Java_java_net_Inet(4|6)AddressImpl_getLocalHostName JVM_GetHostName,
a.k.a gethostname, is returning ENAMETOOLONG. Then falling back to use
localhost, the assumption was that failure would only happen when
something went wrong, maybe networking is not setup.
It appears
On 09/03/2011 16:26, Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Michael,
In Java_java_net_Inet(4|6)AddressImpl_getLocalHostName
JVM_GetHostName, a.k.a gethostname, is returning ENAMETOOLONG. Then
falling back to use localhost, the assumption was that failure would
only happen when
On 03/ 9/11 05:07 PM, Alan Bateman wrote:
Chris Hegarty wrote:
:
I tested on a few different Linux machines and instrumented the error
handling code, it is definitely failing with ENAMETOOLONG.
Okay, must be a glibc thing. The changes you have look okay to me but
would be nice to ensure
Charles, Alan,
I filed CR 7026346: URLConnection.guessContentTypeFromStream does not
support UTF-8 and UTF-32 xml streams with BOM, for this issue.
I also creating a webrev from your patch, with the following changes:
* Moved the UTF-32BE before the UTF-32LE, as per the comment
* filled
Changeset: ab13f19ee0ff
Author:chegar
Date: 2011-03-11 08:47 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab13f19ee0ff
7024560: InetAddress.getLocalHost().getHostName() returns localhost for
hostnames of length HOST_NAME_MAX
Reviewed-by: alanb, michaelm
!
Changeset: 107d55ecd50d
Author:chegar
Date: 2011-03-11 08:57 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/107d55ecd50d
7026346: URLConnection.guessContentTypeFromStream does not support UTF-8 and
UTF-32 xml streams with BOM
Reviewed-by: alanb
Contributed-by: Charles Lee
Alan, Michael,
The subject line says it all! Nice to be able to remove this old code
that is no longer necessary. Hopefully this will make maintenance a
little easier going forward.
http://cr.openjdk.java.net/~chegar/7030256/webrev.00/webrev/
Mike Duigou noticed I pushed this webrev to
On 03/24/11 10:55 AM, Alan Bateman wrote:
Chris Hegarty wrote:
Alan, Michael,
The subject line says it all! Nice to be able to remove this old code
that is no longer necessary. Hopefully this will make maintenance a
little easier going forward.
http://cr.openjdk.java.net/~chegar/7030256
Changeset: c250a66c3b54
Author:chegar
Date: 2011-03-25 16:38 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c250a66c3b54
7030256: Cleanup/Remove code supporting old Windows versions (98, NT, 2000, etc)
Reviewed-by: alanb, mduigou
! make/java/net/Makefile
!
Hi Max,
You should take a look at how this is done in FileServerHandler.java [1]
( one of the httpserver tests in the regression library). I think it
does what you are trying to do.
-Chris.
[1]
Changeset: 31619dfa6a4a
Author:dl
Date: 2011-04-07 15:06 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31619dfa6a4a
7034657: Update Creative Commons license URL in legal notices
Reviewed-by: chegar
! src/share/classes/java/util/AbstractQueue.java
!
On 04/ 7/11 04:53 PM, Neil Richards wrote:
On Wed, 2011-03-16 at 10:43 +, Neil Richards wrote:
On 11 March 2011 14:39, Chris Hegartychris.hega...@oracle.com wrote:
As Michael (cc'ed) mentioned in an earlier mail, he is going to be making
some significant changes in this area in the next
On 04/14/11 05:56 PM, Michael McMahon wrote:
Chris Hegarty wrote:
Alan, Michael,
This is an old issue. JAR URLs may not compare equal when their
enclosing URL's are. The reason is that
URLStreamHandle.equals(URL,URL) and sameFile(URL,URL) doesn't know
about the composite URL syntax used
Changeset: 603e70836e74
Author:dl
Date: 2011-04-18 15:50 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/603e70836e74
7037436: CR 7035020 fails to check shutdown
Reviewed-by: chegar
! src/share/classes/java/util/concurrent/ForkJoinPool.java
!
Changeset: 005c0c85b0de
Author:dl
Date: 2011-04-18 16:10 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/005c0c85b0de
7036559: ConcurrentHashMap footprint and contention improvements
Reviewed-by: chegar
! src/share/classes/java/util/concurrent/ConcurrentHashMap.java
Changeset: 7fd31e477313
Author:dl
Date: 2011-04-21 13:53 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7fd31e477313
7038501: Clarify meaning of (optional) in javadoc
Reviewed-by: chegar
! src/share/classes/java/util/concurrent/BlockingDeque.java
!
Changeset: e9ec52c63a9f
Author:dl
Date: 2011-04-21 17:00 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e9ec52c63a9f
7038542: Small performace regression in ConcurrentHashMap on c1 since CR 703655
Reviewed-by: chegar
!
Changeset: 7c1cdb9c81a6
Author:dl
Date: 2011-04-22 16:33 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c1cdb9c81a6
7038885: Improved bulk operation disclaimers for concurrent collections
Reviewed-by: chegar
!
Changeset: c6742d21853b
Author:dl
Date: 2011-05-09 16:36 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6742d21853b
7042673: LockSupport.getBlocker(null) crashes
Reviewed-by: chegar
! src/share/classes/java/util/concurrent/locks/LockSupport.java
Thanks Brad,
This would appear to be a regression as a result of the changes for CR
5021645.
Before 5021645, url.openConnection.getPermission() was used to determine
the permission. For jar url's this will create a new JarURLConnection
that will delegate the getPermission request to its
Changeset: cecfcb4dbcaa
Author:chegar
Date: 2011-05-16 13:10 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cecfcb4dbcaa
7042679: Phaser javadoc example does not compile
Reviewed-by: dl
! src/share/classes/java/util/concurrent/Phaser.java
Changeset: 411d02c13385
Author:dl
Date: 2011-06-20 12:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/411d02c13385
7051516: ThreadLocalRandom seed is never initialized so all instances generate
the same sequence
Reviewed-by: chegar, dholmes, mduigou
!
Changeset: 6b2c14dfe9b9
Author:chegar
Date: 2011-06-23 13:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b2c14dfe9b9
7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their
own target, jdk_sctp
Reviewed-by: alanb
! test/Makefile
!
On 07/ 5/11 10:10 AM, Charles Lee wrote:
On 04/08/2011 04:47 PM, Chris Hegarty wrote:
On 04/ 7/11 04:53 PM, Neil Richards wrote:
On Wed, 2011-03-16 at 10:43 +, Neil Richards wrote:
On 11 March 2011 14:39, Chris Hegartychris.hega...@oracle.com wrote:
As Michael (cc'ed) mentioned
Changeset: 549b7c3f0bdc
Author:dl
Date: 2011-07-12 15:23 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/549b7c3f0bdc
7058828: test/java/util/concurrent/Phaser/Arrive.java fails intermittently
Reviewed-by: chegar
! test/java/util/concurrent/Phaser/Arrive.java
Changeset: db419c454f92
Author:dl
Date: 2011-07-13 12:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db419c454f92
7057320: test/java/util/concurrent/Executors/AutoShutdown.java failing
intermittently
Summary: Add retry/timeout for checking activeCount
Reviewed-by: chegar
On 07/13/11 06:39 PM, Alan Bateman wrote:
Jing LV wrote:
Hello,
Alan (or anyone else), do we have time to discuss these postponed
defects? Or do you have a outlook for this?
Thank you.
Sorry for the late reply, I've been on vacation.
Sorry, I also meant to respond. Just got lost in all
Michael,
Can you please review this change. It has already been discussed and
agreed, I just rebased it against jdk8 and added a test.
http://cr.openjdk.java.net/~chegar/7021280/webrev.02/webrev/
Thanks,
-Chris.
On 07/13/11 04:07 AM, Charles Lee wrote:
On 07/12/2011 07:03 PM, Chris Hegarty
Changeset: 8bbea505b060
Author:chegar
Date: 2011-07-18 22:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8bbea505b060
7021280: SocketPermission should accept wildcards
Reviewed-by: michaelm
! src/share/classes/java/net/SocketPermission.java
+
Hi Michael,
It has been noticed that there is a perceived delay in response from the
Lightweight HTTP Server implementation that ships with the JDK, compared
to other production HTTP Servers. The cause for this delay has been
identified as the Nagle algorithm buffering the response data until
Changeset: 07a12583d4ea
Author:chegar
Date: 2011-07-25 14:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07a12583d4ea
7035556: DatagramSocket.java:183: warning: unreachable catch clause
Summary: Remove redundant catches in bind
Reviewed-by: alanb, michaelm, wetmore,
Congratulation Kurchi on your first contribution to OpenJDK. Hope to see
more in the future.
-Chris.
On 07/25/11 10:42 PM, chris.hega...@oracle.com wrote:
Changeset: 07a12583d4ea
Author:chegar
Date: 2011-07-25 14:35 -0700
URL:
Michael,
There is an issue in the tunneling/Http retry code whereby a proxy
requiring authentication, if it gives a bad response after the initial
407, may cause the HTTPClient to perform recursive calls to parseHTTP
until StackOverFlow. The reason is obvious when you look at the try
once
Changeset: a80562f7ea50
Author:chegar
Date: 2011-07-27 18:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a80562f7ea50
6670868: StackOverFlow with bad authenticated Proxy tunnels
Reviewed-by: michaelm
! src/share/classes/sun/net/www/http/HttpClient.java
!
This change looks fine to me. Thanks Kurchi,
-Chris.
On 7/28/2011 10:29 PM, Kurchi Hazra wrote:
Hi,
The ServerSocket.toString method returns a string that, besides the
ServerSocket's local port information, also contains port=0. For
example:
Sorry for the delay on this Sean, I owe you a reply. I'll try to get to
this in the next few days.
-Chris.
On 8/4/2011 8:09 AM, Sean Chou wrote:
Hi all,
I checked with java8, this problem still exists; and I checked the
patch, it is still working.
The bug was filed with id 7023713 for
Changeset: cf203f293b4e
Author:chegar
Date: 2011-08-09 16:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf203f293b4e
7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in
Cygwin
Reviewed-by: alanb, dcubed
! test/com/sun/jdi/ShellScaffold.sh
An minor test issue seen when running on a virtual instance. Parent can
legitimately be null, so the test should be robust enough to handle this.
: hg diff NetParamsTest.java
diff -r cf203f293b4e test/java/net/NetworkInterface/NetParamsTest.java
---
On 8/10/2011 11:47 AM, Alan Bateman wrote:
Chris Hegarty wrote:
..
Should this be parentName as I assume parent.getName will NPE here.
Do'h, thanks. Updated patch below...
hg diff NetParamsTest.java
diff -r cf203f293b4e test/java/net/NetworkInterface/NetParamsTest.java
--- a/test/java
Changeset: af15e902cf08
Author:chegar
Date: 2011-08-10 12:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af15e902cf08
7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail
with NPE
Reviewed-by: alanb
!
On 08/11/11 05:27 PM, Alan Bateman wrote:
Chris Hegarty wrote:
Here is a first stab at fixing this issue.
http://cr.openjdk.java.net/~chegar/7014860/webrev.00/webrev/
-Chris.
The spec clarification seems reasonable to me. Small typo the streams
available method to the stream's available
Unusual, but I have not problem with this. Thanks for fixing it.
-Chris.
On 12/08/2011 07:56, Weijun Wang wrote:
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7078355
webrev: http://cr.openjdk.java.net/~weijun/7078355/webrev.00/
Evaluation:
It seems on this system, being an owner of
On 11/08/2011 19:31, Michael McMahon wrote:
On 11/08/11 17:27, Alan Bateman wrote:
Chris Hegarty wrote:
Here is a first stab at fixing this issue.
http://cr.openjdk.java.net/~chegar/7014860/webrev.00/webrev/
-Chris.
The spec clarification seems reasonable to me. Small typo the
streams
Changeset: 809e8db0c142
Author:chegar
Date: 2011-07-29 10:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/809e8db0c142
6978200: ServerSocket.toString include port=0 in the returned String
Summary: Removal of port=0 from ServerSocket.toString method
Reviewed-by: alanb,
Can I get a review for this contribution?
It adds bitmap mime type support to content-types.properties, so that
URLConnection.getContentType() returns 'image/bmp' rather than
'content/unknown'. This is not a commonly used API, but the contribution
seems reasonable.
I agree with the change,
Changeset: 46b53f80ab0a
Author:chegar
Date: 2011-08-19 10:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46b53f80ab0a
7025938: Add bitmap mime type to content-types.properties
Reviewed-by: chegar, alanb, michaelm
Contributed-by: lvj...@linux.vnet.ibm.com
!
is OK to you? If so, can
you apply it to the repostory?
Thanks!
于 2011-4-26 18:43, Jing LV 写道:
于 2011-3-9 22:32, Chris Hegarty 写道:
On 08/03/2011 09:13, Jing LV wrote:
..
Hi Chris,
Thanks for reply. So as we see no objection for this issue, would
someone help to raise a bug in the bug
Hi Sean,
I submitted a JPRT job with you patch. If all builds and tests are
successful I'll push this change for you.
diff -r 46b53f80ab0a src/share/classes/java/net/HttpCookie.java
--- a/src/share/classes/java/net/HttpCookie.javaFri Aug 19
10:55:05 2011 +0100
+++
[take two!]
Tom,
This specific area of code was changed recently due to CR 7035556 [1],
changeset [2], and this issue was discussed during the code review [3].
Essentially, bind() already closes the impl internally before throwing
the exception. Does this resolve the issue for you? Or do
.
-Original Message-
From: Chris Hegarty [mailto:chris.hega...@oracle.com]
Sent: Monday, August 29, 2011 1:56 PM
To: Salter, Thomas A
Cc: net-dev@openjdk.java.net
Subject: Re: Datagram socket leak
[take two!]
Tom,
This specific area of code was changed recently due to CR 7035556 [1
Changeset: a5a28b040714
Author:chegar
Date: 2011-09-01 06:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5a28b040714
7014860: Socket.getInputStream().available() not clear for shutdown input
Reviewed-by: alanb, michaelm
!
An embarrassing bug in the equal(String,String) private implementation
method. The Strings compare equal when there is a % in one string, a
different char in the same place in the other string, but the two chars
following are the same.
On 09/ 1/11 11:40 AM, Michael McMahon wrote:
On 01/09/11 09:36, Chris Hegarty wrote:
...
Change looks fine. I just wonder if the test should go into the existing
mega-test, rather than creating a second file just for this bug?
Agreed, I added it to the mega-test.
Updated webrev:
http
Changeset: fcb33500b325
Author:chegar
Date: 2011-09-01 13:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcb33500b325
7041800: URI.equals may incorrectly return true with escaped octets
Reviewed-by: alanb, michaelm
! src/share/classes/java/net/URI.java
!
: Michael McMahon [mailto:michael.x.mcma...@oracle.com]
Sent: Thursday, September 08, 2011 4:11 AM
To: chris hegarty
Cc: Salter, Thomas A; net-dev@openjdk.java.net
Subject: Re: Datagram socket leak
On 07/09/11 21:54, chris hegarty wrote:
On 07/09/2011 17:24, Michael McMahon wrote:
Hi all,
I've
Hazra wrote:
Updated webrev:
http://cr.openjdk.java.net/~sherman/kurchi/7090158/webrev/
Thanks,
Kurchi
On 9/14/2011 12:42 PM, chris hegarty wrote:
Kurchi,
The problem here is that due to a bug in the compiler, CR 7090499, we
are not seeing raw type warnings for anonymous inner classes.
When
Changeset: 75d763111eec
Author:chegar
Date: 2011-09-16 12:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75d763111eec
7090158: Networking Libraries don't build with javac -Werror
Summary: Minor changes to networking java files to remove warnings
Reviewed-by: chegar,
On 19/09/2011 14:35, Michael McMahon wrote:
My last changeset was missing the file for Windows XP, with the effect
the new test is failing on XP.
This is to address that problem
http://cr.openjdk.java.net/~michaelm/7091369/webrev.3/
Looks fine.
-Chris.
Thanks
Michael
Changeset: 8876d1dec4d7
Author:chegar
Date: 2011-09-26 15:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8876d1dec4d7
7094141: test/sun/misc/JarIndex/metaInfFilenames/Basic.java no longer compiles
Reviewed-by: alanb
! test/sun/misc/JarIndex/metaInfFilenames/Basic.java
Changeset: 7f1aca641910
Author:chegar
Date: 2011-09-26 11:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f1aca641910
7084030: DatagramSocket.getLocalAddress inconsistent on XP/2003 when IPv6
enabled and socket is connected
Summary: Use family of connected IP address to
Thumbs up from me too.
-Chris.
On 30/09/2011 18:35, Mike Duigou wrote:
This fix looks correct. I ran into this bug and this is the same fix I believed
would fix the problem.
Mike
On Sep 30 2011, at 10:08 , Kurchi Hazra wrote:
Hi,
The CookieStore.add() method throws a Null Pointer
Changeset: 74f5fef1d961
Author:chegar
Date: 2011-10-04 13:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74f5fef1d961
6953455: CookieStore.add() cannot handle null URI parameter, contrary to the API
Reviewed-by: chegar, mduigou
Contributed-by:
Changeset: 24741fe639a8
Author:chegar
Date: 2011-10-04 16:37 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24741fe639a8
7095949: java/net/URLConnection/RedirectLimit.java and Redirect307Test fail
intermittently
Reviewed-by: alanb
!
Changeset: ff5e57dc1fb3
Author:chegar
Date: 2011-10-06 12:15 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5e57dc1fb3
7090499: missing rawtypes warnings in anonymous inner class
Summary: Fix anonymous inner classes with raw types currently being built in
the jdk with
Michael, Alan,
This is a follow up to CR 7073491 where the same issue was addressed in
DatagramSocket. This CR proposes to address the same problem exposed
through deprecated java.net.Socket(InetAddress host, int port, boolean
stream).
The problem is in AbstractPlainSocketImpl.create(). If
On 10/ 7/11 05:58 PM, Michael McMahon wrote:
Looks fine. Possibly the comment
line at 102:AbstractPlainSocketImpl.java is not really
needed/appropriate though.
True. I'll remove it.
Thanks,
-Chris.
- Michael.
On 07/10/11 06:40, Chris Hegarty wrote:
Michael, Alan,
This is a follow up
Changeset: 1e89a13d9d8f
Author:chegar
Date: 2011-10-10 10:38 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e89a13d9d8f
7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work
correctly with System.gc()
Reviewed-by: michaelm
!
Changeset: 2a36b8741363
Author:chegar
Date: 2011-10-10 15:29 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a36b8741363
7098755: test/sun/misc/JarIndex/metaInfFilenames/Basic.java should use
supported compiler interface
Reviewed-by: mcimadamore
!
Max [to'ed],
Does this look familiar? Is it wrong for the server to be returning
WWW-Authenticate: Negotiate during NTLM handshake?
-Chris.
On 08/10/2011 14:41, Mario Ivankovits wrote:
Hi net-devs,
I hope you do not mind that I post to this list, but I hope I can
provide enough in-depth
Thanks Max,
I filed the following for this:
CR 7099488: TwoStacksPlainSocketImpl should invoke
super.create(stream), typo in fix for 7098719
Too many changes in too many repos!
-Chris.
On 10/11/11 06:32 AM, Weijun Wang wrote:
in AbstractPlainSocketImpl.close().
Webrev for CR 7099488:
http://cr.openjdk.java.net/~chegar/7099488/webrev.00/webrev/
Thanks,
-Chris.
On 10/11/11 10:36 AM, Chris Hegarty wrote:
Thanks Max,
I filed the following for this:
CR 7099488: TwoStacksPlainSocketImpl should invoke
super.create(stream), typo in fix
Changeset: 5bfe2de1157b
Author:chegar
Date: 2011-10-11 12:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bfe2de1157b
7099488: TwoStacksPlainSocketImpl should invoke super.create(stream), typo in
fix for 7098719
Reviewed-by: coffeys
!
seem worth testing.
-Chris.
Thanks,
Kurchi
On 10/19/11 8:48 AM, Chris Hegarty wrote:
Michael, Kurchi,
java/net/DatagramSocket/ChangingAddress.java was added recently in
JDK8, see CR 7084030. Looking at it again I'm not sure if the test
makes sense, or at least we would have to loosen its
Changeset: b375523d6037
Author:chegar
Date: 2011-10-24 21:03 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b375523d6037
7103549: Remove dependencies on libjava and libjvm from security libraries
Reviewed-by: vinnie, ohair, alanb, dholmes
!
On 26/10/2011 10:36, Alan Bateman wrote:
On 26/10/2011 10:24, Charles Lee wrote:
/ I don't think this code has changed too much since then and
probably could do with a clean-up./
Not true.
I'm talking about the InetAddress* code, that hasn't changed
significantly and probably could do with
Changeset: 88a260444e4d
Author:chegar
Date: 2011-10-26 13:58 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a260444e4d
7104650: rawtype warnings in several net, nio and security source files
Summary: Also reviewed by ulf.zi...@gmx.de
Reviewed-by: mcimadamore, alanb,
, Chris Hegarty wrote:
On 26/10/2011 10:36, Alan Bateman wrote:
On 26/10/2011 10:24, Charles Lee wrote:
/ I don't think this code has changed too much since then and
probably could do with a clean-up./
Not true.
I'm talking about the InetAddress* code, that hasn't changed
significantly
On 11/11/2011 18:57, Kurchi Hazra wrote:
Hi,
As specified in the CR description, this is a bug in
src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption()
should be called instead of socketSetOption().
This bug did not create a problem yet since setOption() is usually
called for
Changeset: 68fc55d12ae6
Author:chegar
Date: 2011-11-14 10:06 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68fc55d12ae6
7107020: java.net.PlainSocketImpl.socketSetOption() calls itself
Reviewed-by: alanb, chegar
Contributed-by: kurchi.subhra.ha...@oracle.com
!
On Nov 11 2011, at 06:53 , Neil Richards wrote:
On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote:
On 11/09/2011 03:25 AM, Chris Hegarty wrote:
Charles,
Is it possible to fix up the style issues, etc that Neil pointed out,
and have the webrev updated?
snip
Hi Chris,
Here
On 11/15/11 06:57 AM, Charles Lee wrote:
Sigh. Chris, I still fail to see those warnings, even if I do a very
clean remove of my build directory and rebuild the whole jdk
The warning are being generated on Solaris when using the Sun compilers
( both full and incremental builds
On 11/16/11 01:48 AM, Charles Lee wrote:
On 11/16/2011 01:00 AM, Neil Richards wrote:
On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote:
On 11/15/2011 07:10 PM, Chris Hegarty wrote:
On 11/15/11 06:57 AM, Charles Lee wrote:
Sigh. Chris, I still fail to see those warnings, even if I do
Kris,
This issue would be more appropriate on the net-dev or nio-dev mailing
lists. So, I'll cross post it and bcc off jdk8-dev.
Thanks,
-Chris.
On 11/18/11 08:22 AM, 撒迦 wrote:
Hi all,
I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor:
In OpenJDK 6, 7 and 8,
101 - 200 of 1795 matches
Mail list logo
