Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread David Holmes
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - S

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Naoto Sato
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - S

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Mandy Chung
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Raffaello Giulietti
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - S

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-08 Thread Weijun Wang
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed My 2 ce

RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Roger Riggs
Improvements to support OS specific customization for JDK internal use: - To select values and code; allowing elimination of unused code and values - Optionally evaluated by build processes, compilation, or archiving (i.e. CDS) - Simple API to replace adhoc comparisons with `os.name` - Clear an

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-08 Thread Weijun Wang
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed Maybe i

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-08 Thread Daniel Jeliński
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed ah, you

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-08 Thread Weijun Wang
On Wed, 8 Mar 2023 15:15:52 GMT, Daniel Jeliński wrote: >> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed >

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-08 Thread Daniel Jeliński
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed I'm not

Re: RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-08 Thread Daniel Fuchs
On Wed, 8 Mar 2023 09:05:19 GMT, Alexey Bakhtin wrote: > This patch fixes a possible native memory leak in case of a custom native GSS > provider. > The actual leak was reported in production. > > sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests > are passed @wangwe

Integrated: 8303682: Simplify HttpClient DebugLogger

2023-03-08 Thread Daniel Fuchs
On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs wrote: > The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debu

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v3]

2023-03-08 Thread Jaikiran Pai
On Wed, 8 Mar 2023 11:37:03 GMT, Daniel Fuchs wrote: >> The HttpClient internal DebugLogger could be simplified if its configuration >> was held in a record. Some of the methods in Utils that return a debug >> logger could also be simplified/removed. The system property that configures >> the

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v3]

2023-03-08 Thread Daniel Fuchs
On Wed, 8 Mar 2023 11:01:07 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use HashSet.newHashSet(capacity) > > test/jdk/java/net/httpclient/DebugLoggerTest.java line 242: > >> 240: out

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v2]

2023-03-08 Thread Jaikiran Pai
On Wed, 8 Mar 2023 11:29:42 GMT, Daniel Fuchs wrote: >> The HttpClient internal DebugLogger could be simplified if its configuration >> was held in a record. Some of the methods in Utils that return a debug >> logger could also be simplified/removed. The system property that configures >> the

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v3]

2023-03-08 Thread Daniel Fuchs
> The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debug logging could be extended to choose between System.er

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v2]

2023-03-08 Thread Jaikiran Pai
On Wed, 8 Mar 2023 11:25:43 GMT, Daniel Fuchs wrote: >> The HttpClient internal DebugLogger could be simplified if its configuration >> was held in a record. Some of the methods in Utils that return a debug >> logger could also be simplified/removed. The system property that configures >> the

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v2]

2023-03-08 Thread Daniel Fuchs
On Wed, 8 Mar 2023 07:44:58 GMT, Jaikiran Pai wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java >> line 59: >> >>> 57: *printed to {@link System#err} >>> 58: * @param logLevel the level above which messages will be forwarded >>> 59

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v2]

2023-03-08 Thread Daniel Fuchs
> The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debug logging could be extended to choose between System.er

Re: RFR: 8303682: Simplify HttpClient DebugLogger [v2]

2023-03-08 Thread Daniel Fuchs
On Wed, 8 Mar 2023 07:26:22 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Make sure julLogger is not GC'ed before the end of the test. >> - Integrated review feedback > > src/java.net.http/sh

Re: RFR: 8303682: Simplify HttpClient DebugLogger

2023-03-08 Thread Jaikiran Pai
On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs wrote: > The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debu

Re: RFR: 8303682: Simplify HttpClient DebugLogger

2023-03-08 Thread Jaikiran Pai
On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs wrote: > The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debu

Re: RFR: 8303682: Simplify HttpClient DebugLogger

2023-03-08 Thread Jaikiran Pai
On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs wrote: > The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debu

Re: RFR: 8303682: Simplify HttpClient DebugLogger

2023-03-08 Thread Jaikiran Pai
On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs wrote: > The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debu

RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl

2023-03-08 Thread Alexey Bakhtin
This patch fixes a possible native memory leak in case of a custom native GSS provider. The actual leak was reported in production. sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests are passed - Commit messages: - 8303809: Dispose context in SPNEGO Negoti

Re: RFR: 8303682: Simplify HttpClient DebugLogger

2023-03-08 Thread Jaikiran Pai
On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs wrote: > The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debu

Re: RFR: 8303682: Simplify HttpClient DebugLogger

2023-03-08 Thread Jaikiran Pai
On Tue, 7 Mar 2023 10:16:24 GMT, Daniel Fuchs wrote: > The HttpClient internal DebugLogger could be simplified if its configuration > was held in a record. Some of the methods in Utils that return a debug logger > could also be simplified/removed. The system property that configures the > debu