Re: RFR: 8303485: Replacing os.name for operating system customization [v4]

2023-03-22 Thread Naoto Sato
On Tue, 14 Mar 2023 18:21:33 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v4]

2023-03-22 Thread Roger Riggs
On Tue, 14 Mar 2023 18:21:33 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8219083: java/net/MulticastSocket/SetGetNetworkInterfaceTest.java failed in same binary run on windows x64

2023-03-22 Thread Daniel Fuchs
On Wed, 22 Mar 2023 15:07:21 GMT, Daniel Jeliński wrote: > This PR removes the test from the problemlist. > > The test failed in JDK13 because of an issue with > `TwoStackPlainDatagramSocket`'s implementation of `setNetworkInterface`, see > JBS for details. > > `TwoStackPlainDatagramSocket` w

RFR: 8219083: java/net/MulticastSocket/SetGetNetworkInterfaceTest.java failed in same binary run on windows x64

2023-03-22 Thread Daniel Jeliński
This PR removes the test from the problemlist. The test failed in JDK13 because of an issue with `TwoStackPlainDatagramSocket`'s implementation of `setNetworkInterface`, see JBS for details. `TwoStackPlainDatagramSocket` was completely removed in JDK 18, and the current implementation appears

Re: RFR: 8267140: Support closing the HttpClient by making it auto-closable [v11]

2023-03-22 Thread Daniel Fuchs
> Please find here an RFE that makes the `java.net.HttpClient` auto-closeable. > > The API has been modeled on `ExecutorService`. > > HttpClient::close() is a graceful shutdown and will wait until all operations > are terminated before returning. > If a request is in progress, and the caller doe

Integrated: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659

2023-03-22 Thread Daniel Jeliński
On Thu, 16 Mar 2023 14:19:14 GMT, Daniel Jeliński wrote: > Please review this change that fixes and reenables OptionsTest on Windows. > > The test is checking that the values retrieved from getOption match the > values set by an earlier call to setOption. The `IP_MULTICAST_IF` option was > tes