On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Thu, 30 Mar 2023 19:40:27 GMT, Daniel Fuchs wrote:
> The ContentLengthHeaderTest could be refactored to use the new HttpTestServer
> factory methods.
> I took the opportunity to also run the test over HTTP/2.
Looks fine to me.
-
Marked as reviewed by jpai (Reviewer).
PR Revie
On Thu, 30 Mar 2023 16:42:45 GMT, Varada M wrote:
>> src/jdk.net/aix/classes/jdk/net/AIXSocketOptions.java line 38:
>>
>>> 36: class AIXSocketOptions extends PlatformSocketOptions {
>>> 37:
>>> 38: public AIXSocketOptions() {
>>
>> It would be good to make this package private constructor
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote:
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
> based on
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
> based on the ensuing discussion and suggestion, is now being handled
On Thu, 30 Mar 2023 19:42:33 GMT, Alan Bateman wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> based on
The ContentLengthHeaderTest could be refactored to use the new HttpTestServer
factory methods.
I took the opportunity to also run the test over HTTP/2.
-
Commit messages:
- 8305323
Changes: https://git.openjdk.org/jdk/pull/13251/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote:
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
> based on
Please review a change to add `@spec` tags (and remove some equivalent `@see`
tags) to the main "core-libs" packages in `java.base` module.
This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
based on the ensuing discussion and suggestion, is now being handled with a
se
On Thu, 30 Mar 2023 12:41:26 GMT, Erik Joelsson wrote:
>> Please update the copyright year on this file to `2016, 2023, `
>
> AIX should be covered by `LIBS_unix := -ljava` as long as that's the only lib
> it needs.
@erikj79 @jaikiran I do think `LIBS_unix := -ljava` is the library AIX needs.
On Thu, 30 Mar 2023 11:49:24 GMT, Jaikiran Pai wrote:
>> make/modules/jdk.net/Lib.gmk line 30:
>>
>>> 28:
>>>
>>> 29:
>>> 30: ifeq ($(call isTargetOs, linux macosx windows aix), true)
>>
>> Hello Varada, I'm not
On Thu, 30 Mar 2023 11:55:09 GMT, Jaikiran Pai wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to copyright year
>
> src/jdk.net/aix/classes/jdk/net/AIXSocketOptions.java line 38:
>
>> 36: class AIXSocketOption
> Breaking this into two parts :
>
> 1. Implementing socket options for AIX
> 2. DontFragmentTest failure
>
> - Implementing socket options for AIX :
>
> Unlike the linux, windows and macOS, AIX uses the default implementation for
> socket options such as ipDontFragmentSupported(),
> keepAl
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote:
> Breaking this into two parts :
>
> 1. Implementing socket options for AIX
> 2. DontFragmentTest failure
>
> - Implementing socket options for AIX :
>
> Unlike the linux, windows and macOS, AIX uses the default implementation for
> socket
On Thu, 30 Mar 2023 11:49:24 GMT, Jaikiran Pai wrote:
>> make/modules/jdk.net/Lib.gmk line 30:
>>
>>> 28:
>>>
>>> 29:
>>> 30: ifeq ($(call isTargetOs, linux macosx windows aix), true)
>>
>> Hello Varada, I'm not
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote:
> Breaking this into two parts :
>
> 1. Implementing socket options for AIX
> 2. DontFragmentTest failure
>
> - Implementing socket options for AIX :
>
> Unlike the linux, windows and macOS, AIX uses the default implementation for
> socket
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote:
> Breaking this into two parts :
>
> 1. Implementing socket options for AIX
> 2. DontFragmentTest failure
>
> - Implementing socket options for AIX :
>
> Unlike the linux, windows and macOS, AIX uses the default implementation for
> socket
On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote:
> Breaking this into two parts :
>
> 1. Implementing socket options for AIX
> 2. DontFragmentTest failure
>
> - Implementing socket options for AIX :
>
> Unlike the linux, windows and macOS, AIX uses the default implementation for
> socket
On Thu, 30 Mar 2023 11:47:50 GMT, Jaikiran Pai wrote:
>> Breaking this into two parts :
>>
>> 1. Implementing socket options for AIX
>> 2. DontFragmentTest failure
>>
>> - Implementing socket options for AIX :
>>
>> Unlike the linux, windows and macOS, AIX uses the default implementation fo
20 matches
Mail list logo
