Re: RFR: 8314774: Optimize URLEncoder [v10]

2023-09-05 Thread Glavo
> I mainly made these optimizations: > > * Avoid allocating `StringBuilder` when there are no characters in the URL > that need to be encoded; > * Implement a fast path for UTF-8. > > In addition to improving performance, these optimizations also reduce > temporary objects: > > * It no longer

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Valerie Peng
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8314774: Optimize URLEncoder [v9]

2023-09-05 Thread Glavo
> I mainly made these optimizations: > > * Avoid allocating `StringBuilder` when there are no characters in the URL > that need to be encoded; > * Implement a fast path for UTF-8. > > In addition to improving performance, these optimizations also reduce > temporary objects: > > * It no longer

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Chris Plummer
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Jonathan Gibbons
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Erik Joelsson
There are a number of files in the `test` directory that have an incorrect copyright header, which includes the "classpath" exception text. This patch removes that text from all test files that I could find it in. I did this using a combination of `sed` and `grep`. Reviewing this patch is probab

Withdrawn: JDK-8305406: Add @spec tags in java.base/java.* (part 2)

2023-09-05 Thread duke
On Tue, 4 Apr 2023 19:46:32 GMT, Jonathan Gibbons wrote: > Please review a doc update to add `@spec` into the rest of the files in > `java.base` (compared to those in > [JDK-8305206](https://bugs.openjdk.org/browse/JDK-8305206) PR #13248) This pull request has been closed without being integra

Re: RFR: 8314774: Optimize URLEncoder [v8]

2023-09-05 Thread Claes Redestad
On Thu, 24 Aug 2023 10:38:57 GMT, Glavo wrote: >> I mainly made these optimizations: >> >> * Avoid allocating `StringBuilder` when there are no characters in the URL >> that need to be encoded; >> * Implement a fast path for UTF-8. >> >> In addition to improving performance, these optimization

Re: RFR: 8308807: [AIX] MulticastSocket and jdp test fails due to joinGroup

2023-09-05 Thread Deepa Kumari
On Sun, 6 Aug 2023 13:47:41 GMT, Andrey Turbanov wrote: >> DatagramSocket delegates to an inner DatagramSocket object. Irrespective of >> whether datagramSocket is IPv4 or IPv6, we create an IPv6 datagramChannel as >> its's delegate. So, This can cause problems with operations like joinGroup.