Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Magnus Ihse Bursie
On Thu, 1 Feb 2024 17:21:23 GMT, Joe Darcy wrote: > I just suggest double-checking on the current maintenance procedures for the > java.util.concurrent code. @jddarcy Any idea how to do that? I tried searching for JSR-166 and java.util.concurrent, but all I could find was talk about a now-del

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Pavel Rappo
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Withdrawn: 8305839: Add application/sql MIME type for SQL file extension

2024-02-01 Thread duke
On Wed, 8 Nov 2023 15:52:13 GMT, Izumi Ryuu wrote: > 8305839: Add application/sql MIME type for SQL file extension This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/16563

RFR: 8323089: networkaddress.cache.ttl is not a system property

2024-02-01 Thread Daniel Jeliński
Please review this documentation change that: - removes networkcache.cache.*.ttl properties from the [System properties page](https://docs.oracle.com/en/java/javase/21/docs/api/system-properties.html) - Adds a link to the Security class where security properties are mentioned - Commi

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Joe Darcy
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Roger Riggs
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Alexey Ivanov
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Daniel Fuchs
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Magnus Ihse Bursie
This is a follow-up on [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the bin/blessed-modifier-order.sh on the entire code base, and manually checked the result. I have reverted all but these trivial and uncontroversial changes. Almost all of these are about moving `stat

Re: JVM security properties warning

2024-02-01 Thread Daniel Jeliński
(adding back net-dev) Hi Autumn, Thanks for the clarifications. The JDK usually doesn't do any logging unless asked to; I don't think a misused property warrants a warning on stderr. I think we can add a set of system properties to configure caching. Would you be interested in that? We originall