> Calls to getSecurityManager, checkPermission, and doPrivileged are removed.
>
> - URLUtils.getConnectPermission is still used in the client area and couldn't
> be removed right away.
> [JDK-8344303](https://bugs.openjdk.org/browse/JDK-8344303) has been logged.
>
> - Similarly, URLConnection.g
On Fri, 15 Nov 2024 08:24:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the usages of
> `SecurityManager` and calls to `AccessController.doPrivileged()` from the
> `sun.net.www.MimeTable` class?
>
> No new tests have been introduced and existing tests in
On Fri, 15 Nov 2024 15:55:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes references to
> `AccessController.doPriveleged()` and also removes a security check?
>
> Specifically:
>
> - The `AccessController.doPriveleged()` has been removed from the
> impleme
On Fri, 15 Nov 2024 20:12:13 GMT, Roger Riggs wrote:
>> Is that sure? We might have custom handlers there (ContentHandlerFactory is
>> a public exported service interface) - some of them might be throwing
>> `SecurityException` for reasons of their own. That's why I was
>> conservatively keepi
> This PR, addressing 8343791, enhances `Socket#connect()` and effectively
> makes it close the `Socket` if `SocketImpl#connect()` fails with a
>
> 1. `SocketTimeoutException`
> 2. `InterruptedIOException` in an interrupted vthread
> 3. `IOException` that is *not* an `UnknownHostException`
>
> O
On Fri, 15 Nov 2024 10:31:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes calls to
> `SecurityManager` and `AccessController.doPrivileged()` from the
> `ProxySelector` and `DefaultProxySelector` classes?
>
> Apart from the trivial removing of those calls, t
> Can I please get a review of this change which removes calls to
> `SecurityManager` and `AccessController.doPrivileged()` from the
> `ProxySelector` and `DefaultProxySelector` classes?
>
> Apart from the trivial removing of those calls, the commit in this PR also
> removes the `getProxySelect
On Fri, 15 Nov 2024 08:24:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the usages of
> `SecurityManager` and calls to `AccessController.doPrivileged()` from the
> `sun.net.www.MimeTable` class?
>
> No new tests have been introduced and existing tests in
On Fri, 15 Nov 2024 15:55:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes references to
> `AccessController.doPriveleged()` and also removes a security check?
>
> Specifically:
>
> - The `AccessController.doPriveleged()` has been removed from the
> impleme
On Fri, 15 Nov 2024 19:45:04 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/URLConnection.java line 1406:
>>
>>> 1404: f = iterator.next();
>>> 1405: } catch (ServiceConfigurationError e) {
>>> 1406: if (e.getCause() instanceof Securi
On Fri, 15 Nov 2024 08:54:38 GMT, Volkan Yazıcı wrote:
>> This PR introduces the following changes addressing intermittent
>> `PlainProxyConnectionTest` failures reported in
>> [JDK-8342811](https://bugs.openjdk.org/browse/JDK-8342811):
>>
>> * Increase logging verbosity to aid in troubleshoot
On Mon, 11 Nov 2024 08:59:03 GMT, Volkan Yazıcı wrote:
> This PR introduces the following changes addressing intermittent
> `PlainProxyConnectionTest` failures reported in
> [JDK-8342811](https://bugs.openjdk.org/browse/JDK-8342811):
>
> * Increase logging verbosity to aid in troubleshooting (
On Fri, 15 Nov 2024 17:18:46 GMT, Alan Bateman wrote:
>> Calls to getSecurityManager, checkPermission, and doPrivileged are removed.
>>
>> - URLUtils.getConnectPermission is still used in the client area and
>> couldn't be removed right away.
>> [JDK-8344303](https://bugs.openjdk.org/browse/JD
On Fri, 15 Nov 2024 09:00:29 GMT, Eirik Bjørsnøs wrote:
> Please review this PR to clean up SM use in `java.net.Authenticator`,
> `java.net.CookieHandler`, and `java.net.ResponseCache` after JEP 486
> integration.
>
> * `Authenticator` is updated to remove calls to SM::checkPermission`
> * `Co
On Fri, 15 Nov 2024 08:28:44 GMT, Eirik Bjørsnøs wrote:
> Please review this JEP486 cleanup PR in the
> `s.n.w.p.mailto.MailToURLConnection` and `sun.net.smtp.SmtpClient` classes.
>
> * The `MailToURLConnection::getPermission` override with the related
> `permission` field is removed
> * The S
This PR, addressing 8343791, enhances `Socket#connect()` and effectively makes
it close the `Socket` if `SocketImpl#connect()` fails with a
1. `SocketTimeoutException`
2. `InterruptedIOException` in an interrupted vthread
3. `IOException` that is *not* an `UnknownHostException`
On the other hand
On Fri, 15 Nov 2024 16:58:46 GMT, Daniel Fuchs wrote:
> Calls to getSecurityManager, checkPermission, and doPrivileged are removed.
>
> - URLUtils.getConnectPermission is still used in the client area and couldn't
> be removed right away.
> [JDK-8344303](https://bugs.openjdk.org/browse/JDK-834
On Fri, 15 Nov 2024 09:00:29 GMT, Eirik Bjørsnøs wrote:
> Please review this PR to clean up SM use in `java.net.Authenticator`,
> `java.net.CookieHandler`, and `java.net.ResponseCache` after JEP 486
> integration.
>
> * `Authenticator` is updated to remove calls to SM::checkPermission`
> * `Co
Calls to getSecurityManager, checkPermission, and doPrivileged are removed.
- URLUtils.getConnectPermission is still used in the client area and couldn't
be removed right away.
[JDK-8344303](https://bugs.openjdk.org/browse/JDK-8344303) has been logged.
- Similarly, URLConnection.getPermission i
On Fri, 15 Nov 2024 10:31:46 GMT, Daniel Fuchs wrote:
> Changes look good. Please run tier2 to validate.
tier2 ran to completion with only the `VerifyJimage.java` test failing. So
seems okay.
-
PR Comment: https://git.openjdk.org/jdk/pull/22139#issuecomment-2479463011
On Fri, 15 Nov 2024 15:55:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes references to
> `AccessController.doPriveleged()` and also removes a security check?
>
> Specifically:
>
> - The `AccessController.doPriveleged()` has been removed from the
> impleme
On Fri, 15 Nov 2024 11:37:55 GMT, Jaikiran Pai wrote:
> > No CSR needed for removing those permissions. There's no visible change to
> > the public APIs, and no behavior change that was not already covered by JEP
> > 486 CSR, since permissions checks have now become deadcode. Or am I missing
>
On Fri, 15 Nov 2024 15:55:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes references to
> `AccessController.doPriveleged()` and also removes a security check?
>
> Specifically:
>
> - The `AccessController.doPriveleged()` has been removed from the
> impleme
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
Can I please get a review of this change which removes references to
`AccessController.doPriveleged()` and also removes a security check?
Specifically:
- The `AccessController.doPriveleged()` has been removed from the
implementation.
- The overridden `getPermission()` method has been removed fr
On Fri, 15 Nov 2024 15:00:39 GMT, Christian Stein wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix regexes in CheckManPageOptions
>
> test/langtools/jdk/javadoc/tool/CheckManPageOptions.java line 277:
>
>
On Thu, 14 Nov 2024 20:40:46 GMT, Daniel Fuchs wrote:
> Please find here a patch that cleans up the java.net.http module code to
> remove permission checks and doPriviliged calls.
> This was mostly mechanical.
This pull request has now been integrated.
Changeset: 40a055eb
Author:Daniel Fuc
On Fri, 15 Nov 2024 08:28:44 GMT, Eirik Bjørsnøs wrote:
> Please review this JEP486 cleanup PR in the
> `s.n.w.p.mailto.MailToURLConnection` and `sun.net.smtp.SmtpClient` classes.
>
> * The `MailToURLConnection::getPermission` override with the related
> `permission` field is removed
> * The S
On Fri, 15 Nov 2024 14:46:33 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms of editing, we make changes to
> the man pages in markdown and
On Fri, 15 Nov 2024 01:25:43 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix CheckManPageOptions test
>> - Remove classpath exception
>
>> > Now `CheckManPageOptions` finds the `.md`
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms of editing, we make changes to
> the man pages in markdown and
On Fri, 15 Nov 2024 09:58:09 GMT, Daniel Fuchs wrote:
> Changes look reasonable. Please run tier2 to validate.
Ran `jtreg:test/jdk:tier2`
A few network tests like `MulticastSocket` and `InetAddress` failed, probably
related to unstable network conditions on my local machine during the test run
On Fri, 15 Nov 2024 14:07:10 GMT, Daniel Fuchs wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
>
On Fri, 15 Nov 2024 09:10:51 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SimpleSSLContext.java
>> line 45:
>>
>>> 43: * Creates a simple usable SSLContext for SSLSocketFactory
>>> 44: * or a HttpsServer using a default keystore in the
On Fri, 15 Nov 2024 13:15:42 GMT, Jaikiran Pai wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commit
> Please find here a patch that cleans up the java.net.http module code to
> remove permission checks and doPriviliged calls.
> This was mostly mechanical.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Jaikiran's feedback
On Fri, 15 Nov 2024 08:54:38 GMT, Volkan Yazıcı wrote:
>> This PR introduces the following changes addressing intermittent
>> `PlainProxyConnectionTest` failures reported in
>> [JDK-8342811](https://bugs.openjdk.org/browse/JDK-8342811):
>>
>> * Increase logging verbosity to aid in troubleshoot
On Fri, 15 Nov 2024 10:25:18 GMT, Daniel Fuchs wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> Daniel Fuchs has updated the pull request with a new target base due to a
> me
On Fri, 15 Nov 2024 10:25:18 GMT, Daniel Fuchs wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> Daniel Fuchs has updated the pull request with a new target base due to a
> me
On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes SM permission checking from
> `s.n.w.p.j.JarFileFactory`.
>
> This removes the permission checking happening in
> `JarFileFactory::getCachedJarFile` and also removes the associated private
> `getPerm
On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes SM permission checking from
> `s.n.w.p.j.JarFileFactory`.
>
> This removes the permission checking happening in
> `JarFileFactory::getCachedJarFile` and also removes the associated private
> `getPerm
On Fri, 15 Nov 2024 09:50:17 GMT, Daniel Fuchs wrote:
> Changes look good, but since this is linked to JarURLConnection it would be
> good to run tier1,tier2 to validate.
Ran tests `jtreg:test/jdk:tier2`, results look okay:
* `VerifyJimage` fail with the same error as in the `FtpClient` PR
* `
On Fri, 15 Nov 2024 11:26:50 GMT, Daniel Fuchs wrote:
> No CSR needed for removing those permissions. There's no visible change to
> the public APIs, and no behavior change that was not already covered by JEP
> 486 CSR, since permissions checks have now become deadcode. Or am I missing
> somet
On Thu, 14 Nov 2024 12:57:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes uses of `AccessController::doPrivileged`
> in `sun/net/ftp`.
>
> Changes are mostly straightforward, one exception is the removal of the
> somewhat exotic unwrapping of temporary arrays in the static
On Fri, 15 Nov 2024 10:31:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes calls to
> `SecurityManager` and `AccessController.doPrivileged()` from the
> `ProxySelector` and `DefaultProxySelector` classes?
>
> Apart from the trivial removing of those calls, t
On Fri, 15 Nov 2024 09:00:29 GMT, Eirik Bjørsnøs wrote:
> Please review this PR to clean up SM use in `java.net.Authenticator`,
> `java.net.CookieHandler`, and `java.net.ResponseCache` after JEP 486
> integration.
>
> * `Authenticator` is updated to remove calls to SM::checkPermission`
> * `Co
On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes SM permission checking from
> `s.n.w.p.j.JarFileFactory`.
>
> This removes the permission checking happening in
> `JarFileFactory::getCachedJarFile` and also removes the associated private
> `getPerm
Can I please get a review of this change which removes calls to
`SecurityManager` and `AccessController.doPrivileged()` from the
`ProxySelector` and `DefaultProxySelector` classes?
Apart from the trivial removing of those calls, the commit in this PR also
removes the `getProxySelector` and `set
> Please find here a patch that cleans up the java.net.http module code to
> remove permission checks and doPriviliged calls.
> This was mostly mechanical.
Daniel Fuchs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated c
On Fri, 15 Nov 2024 08:28:44 GMT, Eirik Bjørsnøs wrote:
> Please review this JEP486 cleanup PR in the
> `s.n.w.p.mailto.MailToURLConnection` and `sun.net.smtp.SmtpClient` classes.
>
> * The `MailToURLConnection::getPermission` override with the related
> `permission` field is removed
> * The S
On Fri, 15 Nov 2024 08:51:48 GMT, Volkan Yazıcı wrote:
>> test/jdk/java/net/httpclient/PlainProxyConnectionTest.java line 60:
>>
>>> 58: * verifying that the remote address of the HTTP exchange (on
>>> the fake proxy server)
>>> 59: * is always the same InetSocketAddress. Lo
On Fri, 15 Nov 2024 08:24:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the usages of
> `SecurityManager` and calls to `AccessController.doPrivileged()` from the
> `sun.net.www.MimeTable` class?
>
> No new tests have been introduced and existing tests in
On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes SM permission checking from
> `s.n.w.p.j.JarFileFactory`.
>
> This removes the permission checking happening in
> `JarFileFactory::getCachedJarFile` and also removes the associated private
> `getPerm
On Thu, 14 Nov 2024 12:57:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes uses of `AccessController::doPrivileged`
> in `sun/net/ftp`.
>
> Changes are mostly straightforward, one exception is the removal of the
> somewhat exotic unwrapping of temporary arrays in the static
Please review this JEP486 cleanup PR in the
`s.n.w.p.mailto.MailToURLConnection` and `sun.net.smtp.SmtpClient` classes.
* The `MailToURLConnection::getPermission` override with the related
`permission` field is removed
* The SM property access check in `MailToURLConnection::getFromAddress` is
r
> Please find here a patch that cleans up the java.net.http module code to
> remove permission checks and doPriviliged calls.
> This was mostly mechanical.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Review feedback
On Thu, 14 Nov 2024 20:53:02 GMT, Michael McMahon wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientBuilderImpl.
On Thu, 14 Nov 2024 15:29:32 GMT, Daniel Fuchs wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove references to the ticket ID
>
> test/jdk/java/net/httpclient/PlainProxyConnectionTest.java line 56:
>
>> 54: /
On Thu, 14 Nov 2024 21:17:01 GMT, Michael McMahon wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/Si
Please review this PR to clean up SM use in `java.net.Authenticator`,
`java.net.CookieHandler`, and `java.net.ResponseCache` after JEP 486
integration.
* `Authenticator` is updated to remove calls to SM::checkPermission`
* `CookieHandler` is updated to remove calls to SM::checkPermission` and re
> This PR introduces the following changes addressing intermittent
> `PlainProxyConnectionTest` failures reported in
> [JDK-8342811](https://bugs.openjdk.org/browse/JDK-8342811):
>
> * Increase logging verbosity to aid in troubleshooting (if the failure
> happens to pop up again)
> * Add salt t
> This PR introduces the following changes addressing intermittent
> `PlainProxyConnectionTest` failures reported in
> [JDK-8342811](https://bugs.openjdk.org/browse/JDK-8342811):
>
> * Increase logging verbosity to aid in troubleshooting (if the failure
> happens to pop up again)
> * Add salt t
On Thu, 14 Nov 2024 15:30:46 GMT, Daniel Fuchs wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove references to the ticket ID
>
> test/jdk/java/net/httpclient/PlainProxyConnectionTest.java line 60:
>
>> 58:
Can I please get a review of this change which removes the usages of
`SecurityManager` and calls to `AccessController.doPrivileged()` from the
`sun.net.www.MimeTable` class?
No new tests have been introduced and existing tests in tier1 and tier2
continue to pass with this change.
-
Please review this PR which removes SM permission checking from
`s.n.w.p.j.JarFileFactory`.
This removes the permission checking happening in
`JarFileFactory::getCachedJarFile` and also removes the associated private
`getPermission` method, (sadly including the cute `// gulp`). The import of
`
67 matches
Mail list logo
