On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote:
>> Adds `test.lib.Utils::createTempFileOfSize` to generate
>> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
>> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
>> tracked by git:
>>
>>
On Tue, 4 Feb 2025 17:18:09 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 668:
>
>> 666: *
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview Comments
-
Changes:
- all:
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Fri, 31 Jan 2025 01:45:47 GMT, Bradford Wetmore wrote:
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 668:
> 666: * String encodedHukUn
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote:
>> Adds `test.lib.Utils::createTempFileOfSize` to generate
>> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
>> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
>> tracked by git:
>>
>>
On Tue, 4 Feb 2025 10:47:22 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assert that multiple files can be served using the same
>> `FileServerHandler`
>> - Remove redundant `@build` depen
On Tue, 4 Feb 2025 12:04:47 GMT, Volkan Yazici wrote:
>> Adds `test.lib.Utils::createTempFileOfSize` to generate
>> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
>> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
>> tracked by git:
>>
>>
> Adds `test.lib.Utils::createTempFileOfSize` to generate
> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
> tracked by git:
>
>
> $ git ls-files | while read f; do echo -e $(stat -c %s "$f
On Tue, 4 Feb 2025 14:15:00 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace `assert`s with conditionally thrown exceptions
>
> test/jdk/java/net/httpclient/http2/FixedThreadPoolTest.java
On Mon, 3 Feb 2025 10:26:59 GMT, Volkan Yazici wrote:
> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
This pull request has now been integrated.
Changeset: d699aba2
Author:Volkan Yazici
URL:
https://git.openjdk.org/jdk/commit/d699aba26f65ce1941bfbaaf1918c987dd0
On Tue, 4 Feb 2025 12:22:28 GMT, Volkan Yazici wrote:
>> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix `assertEquals()` argument order
@vy
Your ch
On Tue, 4 Feb 2025 12:22:28 GMT, Volkan Yazici wrote:
>> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix `assertEquals()` argument order
Attached suc
On Tue, 4 Feb 2025 12:22:28 GMT, Volkan Yazici wrote:
>> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix `assertEquals()` argument order
Thank you fo
On Tue, 4 Feb 2025 11:22:41 GMT, Jaikiran Pai wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace `assert`s with explicit checks throwing `AssertionError`s
>
> test/jdk/java/net/httpclient/HttpRequestBuilderTe
> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
Volkan Yazici has updated the pull request incrementally with one additional
commit since the last revision:
Fix `assertEquals()` argument order
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23415/files
On Tue, 4 Feb 2025 11:07:09 GMT, Volkan Yazici wrote:
>> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replace `assert`s with explicit checks throwing `
On Tue, 4 Feb 2025 10:46:33 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assert that multiple files can be served using the same
>> `FileServerHandler`
>> - Remove redundant `@build` depen
> Adds `test.lib.Utils::createTempFileOfSize` to generate
> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
> tracked by git:
>
>
> $ git ls-files | while read f; do echo -e $(stat -c %s "$f
On Tue, 4 Feb 2025 11:07:09 GMT, Volkan Yazici wrote:
>> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replace `assert`s with explicit checks throwing `
> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
Volkan Yazici has updated the pull request incrementally with one additional
commit since the last revision:
Replace `assert`s with explicit checks throwing `AssertionError`s
-
Changes:
- all: https://git.ope
On Tue, 4 Feb 2025 07:24:20 GMT, Jaikiran Pai wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commit
On Mon, 3 Feb 2025 19:26:03 GMT, Volkan Yazici wrote:
>> Adds `test.lib.Utils::createTempFileOfSize` to generate
>> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
>> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
>> tracked by git:
>>
>>
23 matches
Mail list logo
