On Mon, 10 Feb 2025 11:04:42 GMT, Volkan Yazici wrote:
> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
> the ticket for details on the issue. `tier1,2` results are attached to the
> ticket too.
This pull request has now been integrated.
Changeset: d558d9d4
Author:
On Tue, 11 Feb 2025 11:46:44 GMT, Volkan Yazici wrote:
>> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
>> the ticket for details on the issue. `tier1,2` results are attached to the
>> ticket too.
>
> Volkan Yazici has updated the pull request incrementally with two
On Tue, 11 Feb 2025 11:46:44 GMT, Volkan Yazici wrote:
>> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
>> the ticket for details on the issue. `tier1,2` results are attached to the
>> ticket too.
>
> Volkan Yazici has updated the pull request incrementally with two
On Tue, 11 Feb 2025 10:09:53 GMT, Volkan Yazici wrote:
> Add tests verifying the behavior of `limiting()` factory methods (introduced
> in JDK-8328919) of `HttpResponse` on misbehaving Reactive Streams operators
> that throw exceptions.
test/jdk/java/net/httpclient/ThrowingSubscribersAsLimitin
On Fri, 10 Jan 2025 16:08:05 GMT, Josiah Noel wrote:
> All I'm saying is we can make things clearer. We should be unambiguous in
> saying that the default implementation provided by the module is only
> intended for testing without discouraging the efforts of existing
> implementations meant f
On Fri, 7 Feb 2025 13:48:29 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a change that fixes a potential race condition in
> SSLTube.SSLSubscriptionWrapper.
> Typically the race may get triggered if the demand increased by request() is
> not exhausted by the time
> the subscription i
On Tue, 11 Feb 2025 11:46:44 GMT, Volkan Yazici wrote:
>> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
>> the ticket for details on the issue. `tier1,2` results are attached to the
>> ticket too.
>
> Volkan Yazici has updated the pull request incrementally with two
On Tue, 11 Feb 2025 10:51:52 GMT, Jaikiran Pai wrote:
>> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
>> the ticket for details on the issue. `tier1,2` results are attached to the
>> ticket too.
>
> Hello Volkan, so from what I understand, before this change, we us
> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
> the ticket for details on the issue. `tier1,2` results are attached to the
> ticket too.
Volkan Yazici has updated the pull request incrementally with two additional
commits since the last revision:
- Add current i
On Mon, 10 Feb 2025 11:04:42 GMT, Volkan Yazici wrote:
> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
> the ticket for details on the issue. `tier1,2` results are attached to the
> ticket too.
Hello Volkan, so from what I understand, before this change, we used to
On Tue, 11 Feb 2025 10:09:35 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/DigestEchoClient.java line 531:
>>
>>> 529: if (error != null) {
>>> 530: if (failed != null) error.addSuppressed(failed);
>>> 531: throw error;
>>
>> Do you think a
On Tue, 11 Feb 2025 10:03:25 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes a potential race condition in
>> SSLTube.SSLSubscriptionWrapper.
>> Typically the race may get triggered if the demand increased by request()
>> is not exhausted by the time
>> the subscr
On Tue, 11 Feb 2025 10:00:26 GMT, Jaikiran Pai wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> test/jdk/java/net/httpclient/DigestEchoClient.java line 531:
>
>> 529: if (error != nu
Add tests verifying the behavior of `limiting()` factory methods (introduced in
JDK-8328919) of `HttpResponse` on misbehaving Reactive Streams operators that
throw exceptions.
-
Commit messages:
- Verify `limiting()` behavior on misbehaving RS operators
Changes: https://git.openjd
On Tue, 11 Feb 2025 09:58:32 GMT, Jaikiran Pai wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> test/jdk/java/net/httpclient/DigestEchoClient.java line 411:
>
>> 409: BodyPublish
> Hi,
>
> Please find here a change that fixes a potential race condition in
> SSLTube.SSLSubscriptionWrapper.
> Typically the race may get triggered if the demand increased by request() is
> not exhausted by the time
> the subscription is switched by setSubscription.
>
> Some synchronizatio
On Tue, 11 Feb 2025 09:51:59 GMT, Jaikiran Pai wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> src/java.net.http/share/classes/jdk/internal/net/http/common/SSLTube.java
> line 644:
>
>> 642:
On Tue, 11 Feb 2025 10:00:26 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes a potential race condition in
>> SSLTube.SSLSubscriptionWrapper.
>> Typically the race may get triggered if the demand increased by request()
>> is not exhausted by the time
>> the subscr
On Fri, 7 Feb 2025 13:48:29 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a change that fixes a potential race condition in
> SSLTube.SSLSubscriptionWrapper.
> Typically the race may get triggered if the demand increased by request() is
> not exhausted by the time
> the subscription i
19 matches
Mail list logo
