Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-06 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v6]

2025-05-06 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v5]

2025-05-06 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v13]

2025-05-06 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: 8353440: Disable FTP fallback for non-local file URLs by default [v14]

2025-05-06 Thread Daniel Fuchs
On Fri, 2 May 2025 20:32:27 GMT, Eirik Bjørsnøs wrote: >> Please help review this PR which disables the unspecified but long-standing >> feature where an `FtpURLConnection` is opened as a fallback for non-local >> file URLs. >> >> Before this change, if a file URL has a non-local host componen

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v2]

2025-05-06 Thread Daniel Fuchs
On Tue, 6 May 2025 14:40:46 GMT, Per Minborg wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > Per Minborg has updated the pull request incremen

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v8]

2025-05-06 Thread Daniel Fuchs
On Tue, 6 May 2025 13:24:55 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to respecify the 2 >> `java.net.Socket` constructors that allow construction of UDP sockets? This >> addresses https://bugs.openjdk.org/browse/JDK-8356154. >> >> As noted in that JBS

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v2]

2025-05-06 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8353440: Disable FTP fallback for non-local file URLs by default [v14]

2025-05-06 Thread Eirik Bjørsnøs
On Fri, 2 May 2025 20:32:27 GMT, Eirik Bjørsnøs wrote: >> Please help review this PR which disables the unspecified but long-standing >> feature where an `FtpURLConnection` is opened as a fallback for non-local >> file URLs. >> >> Before this change, if a file URL has a non-local host componen

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread ExE Boss
On Mon, 5 May 2025 13:41:22 GMT, Per Minborg wrote: > This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. src/java.base/share/classes/jdk/internal/lang/stable/St

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v7]

2025-05-06 Thread Jaikiran Pai
On Tue, 6 May 2025 13:08:46 GMT, Michael McMahon wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unintentional file additions > > src/java.base/share/classes/java/net/Socket.java line 455: > >> 453:

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v8]

2025-05-06 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to respecify the 2 > `java.net.Socket` constructors that allow construction of UDP sockets? This > addresses https://bugs.openjdk.org/browse/JDK-8356154. > > As noted in that JBS issue, in Java 23 we deprecated for removal the 2 > `Socke

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v7]

2025-05-06 Thread Michael McMahon
On Tue, 6 May 2025 09:11:32 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to respecify the 2 >> `java.net.Socket` constructors that allow construction of UDP sockets? This >> addresses https://bugs.openjdk.org/browse/JDK-8356154. >> >> As noted in that JBS

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Chen Liang
On Tue, 6 May 2025 11:33:27 GMT, Per Minborg wrote: >> Calling the method that computes hash. > > This would require another implementation to be written. Maybe we can add > that later? I feel like declaring a function is declaring redundant classes when we can just reuse a DirectMethodHandle

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Chen Liang
On Tue, 6 May 2025 09:09:50 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/reflect/Method.java line 101: >> >>> 99: >>> 100: private static final ToIntFunction HASH_UPDATER = >>> 101: StableFieldUpdater.ofIntRaw(Method.class, >>> Unsafe.getUnsafe().objectField

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Chen Liang
On Mon, 5 May 2025 13:41:22 GMT, Per Minborg wrote: > This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Changes requested by liach (Reviewer). src/java.base/s

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Per Minborg
On Tue, 6 May 2025 10:55:22 GMT, Chen Liang wrote: >> Do you mean for interacting with the field or computing the hash? > > Calling the method that computes hash. This would require another implementation to be written. Maybe we can add that later? - PR Review Comment: https://git

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Shaojin Wen
On Mon, 5 May 2025 13:41:22 GMT, Per Minborg wrote: > This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. src/java.base/share/classes/java/lang/reflect/Method.ja

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Per Minborg
On Mon, 5 May 2025 13:41:22 GMT, Per Minborg wrote: > This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Benchmarks: BenchmarkMode Cn

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Per Minborg
On Mon, 5 May 2025 15:04:54 GMT, Chen Liang wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > src/java.base/share/classes/java/lang/reflect/Meth

RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations

2025-05-06 Thread Per Minborg
This sketch shows how "Stable Updaters" can be used to create stable computations of `@Stable` fields. Only one updater is needed per class, similar to `AtomicIntegerFieldUpdater`. - Commit messages: - Address comments - Document field alignment assumption - Add unhecked call tes

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-05-06 Thread Mikhail Yankelevich
On Thu, 6 Feb 2025 15:54:47 GMT, Mikhail Yankelevich wrote: >> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically > > Mikhail Yankelevich has updated the pull request incrementally with one > a

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v7]

2025-05-06 Thread Alan Bateman
On Tue, 6 May 2025 09:11:32 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to respecify the 2 >> `java.net.Socket` constructors that allow construction of UDP sockets? This >> addresses https://bugs.openjdk.org/browse/JDK-8356154. >> >> As noted in that JBS

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v7]

2025-05-06 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to respecify the 2 > `java.net.Socket` constructors that allow construction of UDP sockets? This > addresses https://bugs.openjdk.org/browse/JDK-8356154. > > As noted in that JBS issue, in Java 23 we deprecated for removal the 2 > `Socke

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v5]

2025-05-06 Thread Jaikiran Pai
On Tue, 6 May 2025 08:03:27 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's review suggestion - simplify Socket constructor API documentation > > src/java.base/share/classes/java/net/Socket

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v6]

2025-05-06 Thread Jaikiran Pai
On Tue, 6 May 2025 08:05:02 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> additional updates to apiNotes > > src/java.base/share/classes/java/net/Socket.java line 384: > >> 382: * stream s

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v6]

2025-05-06 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to respecify the 2 > `java.net.Socket` constructors that allow construction of UDP sockets? This > addresses https://bugs.openjdk.org/browse/JDK-8356154. > > As noted in that JBS issue, in Java 23 we deprecated for removal the 2 > `Socke

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v5]

2025-05-06 Thread Alan Bateman
On Tue, 6 May 2025 07:26:05 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to respecify the 2 >> `java.net.Socket` constructors that allow construction of UDP sockets? This >> addresses https://bugs.openjdk.org/browse/JDK-8356154. >> >> As noted in that JBS

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v3]

2025-05-06 Thread Jaikiran Pai
On Tue, 6 May 2025 06:30:27 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/net/Socket.java line 384: >> >>> 382: * stream socket. Only stream socket creation is allowed. If the >>> stream >>> 383: * argument is {@code false}, then this constructor throws >>> 384: *

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v5]

2025-05-06 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to respecify the 2 > `java.net.Socket` constructors that allow construction of UDP sockets? This > addresses https://bugs.openjdk.org/browse/JDK-8356154. > > As noted in that JBS issue, in Java 23 we deprecated for removal the 2 > `Socke

Re: RFR: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException [v4]

2025-05-06 Thread Jaikiran Pai
On Tue, 6 May 2025 06:32:33 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> additional changes to SocketImpl.create(...) API javadoc based on review >> suggestions > > src/java.base/share/classes