On Wed, 4 Jun 2025 14:23:01 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
>> targeting it to 26.
>> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
>> Expires attributes
>> are present in a cookie, the M
On Wed, 4 Jun 2025 11:12:02 GMT, Michael McMahon wrote:
> Hi,
>
> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
> targeting it to 26.
> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
> Expires attributes
> are present in a cookie, the Max-A
On Wed, 4 Jun 2025 16:04:08 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/java/net/Socket.java line 970:
>>
>>> 968: long end = SocketReadEvent.timestamp();
>>> 969: long duration = end - start;
>>> 970: if (SocketReadEvent.shouldThrottleCommit(durati
On Wed, 4 Jun 2025 15:46:36 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](http
On Wed, 4 Jun 2025 14:32:31 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix adjust boundary
>
> src/java.base/share/classes/java/net/Socket.java line 970:
>
>> 968: long end = Sock
On Fri, 16 May 2025 10:26:11 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 422 commits:
>>
>> - merge latest changes from master branch
>> - Undo whitespace change
>> - Remove unnecess
On Wed, 4 Jun 2025 14:16:56 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix adjust boundary
>
> src/jdk.jfr/share/classes/jdk/jfr/Throttle.java line 77:
>
>> 75: * Specifying {@code "off"
> Hi,
>
> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP
> Client API](https://openjdk.org/jeps/517).
>
> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP
> Client API](https://bugs.openjdk.org/browse/JDK-8350588)
>
> This JEP propose
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Wed, 4 Jun 2025 11:12:02 GMT, Michael McMahon wrote:
> Hi,
>
> This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
> targeting it to 26.
> We currently do not obey the rule in RFC 6265 that says if both Max-Age and
> Expires attributes
> are present in a cookie, the Max-A
On Fri, 30 May 2025 08:57:47 GMT, Volkan Yazici wrote:
>> Thanks for the catch - the class simple name has been appended in
>> 18bac9fa64f81110c2894f5f141e88ec5dc20b03
>
> @p-nima, the handler still accepts all calls to `/`, you only salted the
> request URI. Would you mind doing the same in
>
Hi,
This is a fix to j.n.HttpCookie (which has a doc/spec change). So, I'm
targeting it to 26.
We currently do not obey the rule in RFC 6265 that says if both Max-Age and
Expires attributes
are present in a cookie, the Max-Age should take precedence.
Thanks
Michael
-
Commit messag
On Wed, 28 May 2025 12:46:25 GMT, Volkan Yazici wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.httpclien
On Thu, 29 May 2025 16:03:11 GMT, p-nima wrote:
>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 66:
>>
>>> 64: };
>>> 65:
>>> 66: httpTestServer.addHandler(httpTestHandler, "/");
>>
>> In the past, there has been occasions in CI where a test server re
On Wed, 28 May 2025 12:16:02 GMT, Volkan Yazici wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.httpclien
On Wed, 28 May 2025 14:07:37 GMT, Darragh Clarke wrote:
>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 52:
>>
>>> 50:
>>> 51: private static final int DEFAULT_RETRY_LIMIT = 3;
>>> 52: private final int retryLimit =
>>> Integer.getInteger("jdk.httpclient.auth.retryli
On Wed, 28 May 2025 12:04:31 GMT, Mikhail Yankelevich
wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.ht
On Wed, 28 May 2025 13:40:42 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 34:
>>
>>> 32: * @build jdk.httpclient.test.lib.http2.Http2TestServer
>>> 33: * @run junit HttpClientRetryLimitTest
>>> 34: * @run junit/othervm -Djdk.httpclient.auth.retry
On Wed, 28 May 2025 12:05:20 GMT, Mikhail Yankelevich
wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.ht
On Wed, 28 May 2025 11:26:17 GMT, p-nima wrote:
> The AuthenticationFilter did not respect the default retry limit of 3 retries
> in case of invalid credentials supplied.
>
> This PR helps to resolve the bug and tests it with default and updated retry
> limit set via `jdk.httpclient.auth.retry
On Wed, 28 May 2025 11:26:17 GMT, p-nima wrote:
> The AuthenticationFilter did not respect the default retry limit of 3 retries
> in case of invalid credentials supplied.
>
> This PR helps to resolve the bug and tests it with default and updated retry
> limit set via `jdk.httpclient.auth.retry
The AuthenticationFilter did not respect the default retry limit of 3 retries
in case of invalid credentials supplied.
This PR helps to resolve the bug and tests it with default and updated retry
limit set via `jdk.httpclient.auth.retrylimit=1`.
The test is green with tiers 1, 2, 3 and the test
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Wed, 4 Jun 2025 11:31:21 GMT, Erik Gahlin wrote:
> @AlanBateman Do you have time for a review?
Yes, looking at the changes.
-
PR Comment: https://git.openjdk.org/jdk/pull/25559#issuecomment-2939787559
On Tue, 3 Jun 2025 12:56:49 GMT, Alan Bateman wrote:
> If several threads attempt to read from a Socket's input stream at the same
> time then all but the winner will block trying to acquire the read lock.
> This is okay for untimed-reads but surprising for timed-reads as the timeout
> is onl
25 matches
Mail list logo
