Re: RFR: 8352502: Response message is null if expect 100 assertion fails with non 100 [v2]

2025-07-08 Thread Daniel Fuchs
On Tue, 8 Jul 2025 14:33:04 GMT, Darragh Clarke wrote: >> Currently if a request has set Expect-Continue and receives a non 100 >> response the `responseMessage` wouldn't be set. >> >> This PR sets `responseMessage`, it also updates `getResponseMessage` to >> check if the message has already b

Re: RFR: 8352502: Response message is null if expect 100 assertion fails with non 100 [v2]

2025-07-08 Thread Daniel Fuchs
On Tue, 8 Jul 2025 14:33:04 GMT, Darragh Clarke wrote: >> Currently if a request has set Expect-Continue and receives a non 100 >> response the `responseMessage` wouldn't be set. >> >> This PR sets `responseMessage`, it also updates `getResponseMessage` to >> check if the message has already b

Re: RFR: 8352502: Response message is null if expect 100 assertion fails with non 100 [v2]

2025-07-08 Thread Darragh Clarke
> Currently if a request has set Expect-Continue and receives a non 100 > response the `responseMessage` wouldn't be set. > > This PR sets `responseMessage`, it also updates `getResponseMessage` to check > if the message has already been set. This should match the way that > `responseCode` is c

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-07-08 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8342868: Errors related to unused code on Windows after 8339120 in core libs [v2]

2025-07-08 Thread Julian Waters
On Tue, 8 Jul 2025 01:49:14 GMT, David Holmes wrote: >> Sorry for waiting so long. It's become clear that I won't be able to get awt >> and accessibility up to speed for a long time, so I will go ahead with this >> one first > > @TheShermanTanker the commented out code really should have been d

Re: RFR: 8342868: Errors related to unused code on Windows after 8339120 in core libs [v2]

2025-07-08 Thread Julian Waters
On Tue, 8 Jul 2025 04:20:32 GMT, Jaikiran Pai wrote: > > Since your change was applied there have been 3762 commits pushed to the > > master branch > > It's usually risky to be integrating a PR which is so far behind the master > branch, without first merging the latest changes and running the