Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v4]

2025-08-20 Thread David Holmes
On Wed, 20 Aug 2025 15:21:39 GMT, Magnus Ihse Bursie wrote: > I realize that this is highly hardware dependent, but test times tend to be > Pareto distributed, so a very quick test maybe takes 1 second on fast > machines and 10 on slow, @magicus unfortunately that is often not the case in pra

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-20 Thread Magnus Ihse Bursie
On Wed, 20 Aug 2025 17:05:59 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Artur Barashev
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-08-20 Thread Daniel Fuchs
On Wed, 20 Aug 2025 16:21:42 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/sun/security/ssl/Finished.java line 852: >> >>> 850: QuicTLSEngineImpl engine = >>> 851: (QuicTLSEngineImpl) >>> shc.conContext.transport; >>> 852:

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-20 Thread Leo Korinth
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts > to individual test cases so that I am able to run them with a timeout factor > of 0.7 (some margin to the checked in factor of one) > > In addition to changing the timeout factor, I am also using a library call to

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v4]

2025-08-20 Thread Leo Korinth
On Wed, 20 Aug 2025 16:24:43 GMT, Leo Korinth wrote: >> doc/testing.md line 385: >> >>> 383: (`-timeoutFactor`). Also, some test cases that programmatically wait a >>> 384: certain amount of time will apply this factor. If we run in >>> 385: forced compilation mode (`-Xcomp`), [RunTest.gmk](../m

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v4]

2025-08-20 Thread Leo Korinth
On Wed, 20 Aug 2025 15:17:02 GMT, Magnus Ihse Bursie wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> after suggestion from Daniel > > doc/testing.md line 385: > >> 383: (`-timeoutFactor`). Also, some test cases tha

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-08-20 Thread Jaikiran Pai
On Thu, 26 Jun 2025 18:06:03 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Artur Barashev
On Wed, 20 Aug 2025 15:14:01 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 616 commits: >> >> - merge latest changes from master branch >> - merge latest http3 changes >> - Hide inte

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Artur Barashev
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Artur Barashev
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v4]

2025-08-20 Thread Magnus Ihse Bursie
On Mon, 18 Aug 2025 16:34:21 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v4]

2025-08-20 Thread Magnus Ihse Bursie
On Mon, 18 Aug 2025 16:34:21 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Artur Barashev
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Artur Barashev
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Daniel Jeliński
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Daniel Fuchs
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v3]

2025-08-20 Thread SendaoYan
On Wed, 20 Aug 2025 12:53:23 GMT, David Holmes wrote: >> But what this PR do is change the timeoutFactor in general and find out all >> the tests which may timeout after the timeoutFactor has been changed. >> >> The old default timeout before this PR is 120 * 4, after this PR the new >> defaul

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v3]

2025-08-20 Thread David Holmes
On Tue, 19 Aug 2025 06:38:01 GMT, SendaoYan wrote: >> No change should be made to any explicit setting of the timeoutFactor in >> general as that could cause mass timeouts to occur (old default timeout = >> 120 * 10 = 1200 but new default = 120 * 2.5 = 300!). >> >> However I see the concern o

Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v10]

2025-08-20 Thread Jaikiran Pai
On Wed, 20 Aug 2025 09:43:09 GMT, Volkan Yazici wrote: >> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)` >> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient` >> publisher to upload a certain region of a file. The new publisher does not >> mod

Re: RFR: 8365834: Mark java/net/httpclient/ManyRequests.java as intermittent

2025-08-20 Thread Jaikiran Pai
On Wed, 20 Aug 2025 03:30:26 GMT, SendaoYan wrote: > The test java/net/httpclient/ManyRequests.java has been observed intermittent > failure such as https://bugs.openjdk.org/browse/JDK-8327968 and > https://bugs.openjdk.org/browse/JDK-8365811. Should we mark this test as > `@intermittent`. I

Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v10]

2025-08-20 Thread Daniel Fuchs
On Wed, 20 Aug 2025 09:43:09 GMT, Volkan Yazici wrote: >> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)` >> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient` >> publisher to upload a certain region of a file. The new publisher does not >> mod

Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v10]

2025-08-20 Thread Volkan Yazici
> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)` > method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient` > publisher to upload a certain region of a file. The new publisher does not > modify the state of the passed `FileChannel`, streams the file c