On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
Test failure is because JDK source failed to check
On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
@fandreuz
Your change (at version 09067914f31bdabe
On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
LGTM
-
Marked as reviewed by naoto (R
On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
Removals are consistent with the ones commented out
[JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
rather than removing it. The code can be removed safely, as pointed out in the
PR review: #21654.
-
Commit messages:
- remove commented code
Changes: https://git.openjdk.org/jdk/pull/27012/files
Webrev
> This PR updates the CertificateBuilder with a new method that creates a new
> instance with common fields (subject name, public key, serial number,
> validity, and key uses) filled-in. One test, IPIdentities.java, is updated to
> show how the method can be used to create various certificates.
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing the timeout factor, I am also using a library call to
On Fri, 29 Aug 2025 15:16:04 GMT, Matthew Donovan wrote:
>> This PR updates the CertificateBuilder with a new method that creates a new
>> instance with common fields (subject name, public key, serial number,
>> validity, and key uses) filled-in. One test, IPIdentities.java, is updated
>> to s
On Tue, 26 Aug 2025 17:06:08 GMT, Matthew Donovan wrote:
>> Leo Korinth has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - revert added timeout, it is not needed
>> - feedback from Mark Sheppard
>
> test/jdk/sun/security/krb5/name/Constr
On Fri, 29 Aug 2025 08:50:52 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> mod
> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
> publisher to upload a certain region of a file. The new publisher does not
> modify the state of the passed `FileChannel`, streams the file c
On Fri, 29 Aug 2025 08:50:52 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> mod
On Fri, 29 Aug 2025 08:50:52 GMT, Volkan Yazici wrote:
>> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
>> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
>> publisher to upload a certain region of a file. The new publisher does not
>> mod
> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)`
> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient`
> publisher to upload a certain region of a file. The new publisher does not
> modify the state of the passed `FileChannel`, streams the file c
14 matches
Mail list logo
