Re: RFR: 8357013: Optimize response code parsing in HttpURLConnection

2025-05-20 Thread Daniel Fuchs
On Fri, 16 May 2025 19:34:59 GMT, Patrick Strawderman wrote: >> Thanks for this fix. The proposed changes LGTM. Did you run tier2 tests? > >> Thanks for this fix. The proposed changes LGTM. Did you run tier2 tests? > > Yes, I've run tier1 and tier2 tests. There were a few unrelated failures, but

Re: RFR: 8357013: Optimize response code parsing in HttpURLConnection

2025-05-20 Thread Daniel Fuchs
On Thu, 15 May 2025 05:14:02 GMT, Patrick Strawderman wrote: > Avoid allocating a substring to parse the response code in > HttpURLConnection#getResponseCode, but instead use the Integer.parseInt > overload that accepts String indices. Marked as reviewed by dfuchs (Reviewer). - P

Re: RFR: 8357013: Optimize response code parsing in HttpURLConnection

2025-05-16 Thread Patrick Strawderman
On Thu, 15 May 2025 11:47:08 GMT, Daniel Fuchs wrote: > Thanks for this fix. The proposed changes LGTM. Did you run tier2 tests? Yes, I've run tier1 and tier2 tests. There were a few unrelated failures, but the [test ](https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/HttpURLConnect

Re: RFR: 8357013: Optimize response code parsing in HttpURLConnection

2025-05-15 Thread Daniel Fuchs
On Thu, 15 May 2025 05:14:02 GMT, Patrick Strawderman wrote: > Avoid allocating a substring to parse the response code in > HttpURLConnection#getResponseCode, but instead use the Integer.parseInt > overload that accepts String indices. Thanks for this fix. The proposed changes LGTM. Did you ru

RFR: 8357013: Optimize response code parsing in HttpURLConnection

2025-05-14 Thread Patrick Strawderman
Avoid allocating a substring to parse the response code in HttpURLConnection#getResponseCode, but instead use the Integer.parseInt overload that accepts String indices. - Commit messages: - Optimize response code parsing in HttpURLConnection Changes: https://git.openjdk.org/jdk/pu