Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Bill Fenner
On Sun, May 20, 2018 at 2:25 PM, Robert Story wrote: > On Sun, 20 May 2018 13:06:43 -0400 Bill wrote: > BF> I do not think that now is the time to try to deal with any of > BF> the fundamentals, but just not regress from previous released > BF> behavior, and deal with the underlying issue in 5.8.

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Robert Story
On Sun, 20 May 2018 13:06:43 -0400 Bill wrote: BF> I do not think that now is the time to try to deal with any of BF> the fundamentals, but just not regress from previous released BF> behavior, and deal with the underlying issue in 5.8.1 / 5.7.4. Just to clarify, do you mean a) accepts Bart's RF

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Bill Fenner
On Sun, May 20, 2018 at 12:18 AM, Robert Story wrote: > On Sat, 19 May 2018 14:07:56 -0700 Bart wrote: > BVA> strlcpy() implementations typically scan for the end of the > BVA> source argument passed to strlcpy(). Hence avoid passing an > BVA> unterminated string to strlcpy(). > > I'm going to sa

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-20 Thread Bart Van Assche
On 05/19/18 21:18, Robert Story wrote: On Sat, 19 May 2018 14:07:56 -0700 Bart wrote: BVA> strlcpy() implementations typically scan for the end of the BVA> source argument passed to strlcpy(). Hence avoid passing an BVA> unterminated string to strlcpy(). I'm going to say -1, but for the patch an