Re: [PATCH]; request for votes] Cygwin: Make it again possible to build with OpenSSL

2018-05-21 Thread Wes Hardaker via Net-snmp-coders
Bart Van Assche writes: > This patch should work for both newer and older Cygwin versions. The > description of commit 0657b90b7181 is as follows: Ok, I'll trust you (I haven't built on windows in a decade at least). +1 -- Wes Hardaker Please mail all replies to

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-21 Thread Bill Fenner
On Mon, May 21, 2018 at 11:18 AM, Wes Hardaker < harda...@users.sourceforge.net> wrote: > Bill Fenner writes: > > > So, +1 on committing Bart's patch, because it accomplishes the goal of > > fixing the regression, with the caveat that I really think that this > > whole area

Re: [PATCH]; request for votes] Cygwin: Make it again possible to build with OpenSSL

2018-05-21 Thread Bart Van Assche
On 05/21/18 09:43, Wes Hardaker wrote: Bart Van Assche writes: Remove #define OPENSSL_SYS_WIN32 since that tells OpenSSL to include the Winsock header file. Define VC_EXTRALEAN and WIN32_LEAN_AND_MEAN to avoid that header files are included from that conflict with the

Re: [PATCH]; request for votes] Cygwin: Make it again possible to build with OpenSSL

2018-05-21 Thread Wes Hardaker via Net-snmp-coders
Bart Van Assche writes: > Remove #define OPENSSL_SYS_WIN32 since that tells OpenSSL to include > the Winsock header file. Define VC_EXTRALEAN and WIN32_LEAN_AND_MEAN > to avoid that header files are included from that conflict > with the OpenSSL header files. This patch

Re: [PATCH; request for votes] snmplib: Avoid that sprint_realloc_octet_string() triggers a segmentation fault

2018-05-21 Thread Wes Hardaker via Net-snmp-coders
Bill Fenner writes: > So, +1 on committing Bart's patch, because it accomplishes the goal of > fixing the regression, with the caveat that I really think that this > whole area needs to be revisited. I think this comment is spot on. So I'd accept the patch too, though my gut

[PATCH]; request for votes] Cygwin: Make it again possible to build with OpenSSL

2018-05-21 Thread Bart Van Assche
Remove #define OPENSSL_SYS_WIN32 since that tells OpenSSL to include the Winsock header file. Define VC_EXTRALEAN and WIN32_LEAN_AND_MEAN to avoid that header files are included from that conflict with the OpenSSL header files. This patch avoids that building without --with-openssl=internal