Re: multi-type config files [Re: AgentX broken]

2004-08-25 Thread Dave Shield
> NETSNMP_DS_LIB_APPTYPES seems to be the sum of all types of config that is to > be read while > NETSNMP_DS_LIB_APPTYPE seems to be the 'natural' type that is parsed. Yes - that's right. > but I do agree that I do not understand the exact implications of them. No - neither do I :-) That tend

Re: multi-type config files [Re: AgentX broken]

2004-08-25 Thread Magnus Fromreide
On Wed, Aug 25, 2004 at 09:38:52AM -0400, Robert Story wrote: > On Wed, 25 Aug 2004 09:55:43 +0100 Dave wrote: > DS> I'd submitted the changes for the first of these, but didn't think > DS> that I'd touched the other two. So I was a little suprised when > DS> Magnus reported this problem - partic

Re: multi-type config files [Re: AgentX broken]

2004-08-25 Thread Coders
On Wed, 25 Aug 2004 09:55:43 +0100 Dave wrote: DS> I'd submitted the changes for the first of these, but didn't think DS> that I'd touched the other two. So I was a little suprised when DS> Magnus reported this problem - particularly when I searched my DS> code and didn't find any mention of "age

Re: multi-type config files [Re: AgentX broken]

2004-08-25 Thread Dave Shield
> I think I'm going to wait on Dave for this one, as I believe I may have > been barking up the wrong tree with my patch, and led you astray. > > My patch made the config code parse the same file with different types. > I think the idea is actually to parse different files (eg snmpd.conf & > agen

Re: multi-type config files [Re: AgentX broken]

2004-08-24 Thread Magnus Fromreide
On Tue, Aug 24, 2004 at 03:22:24PM -0400, Robert Story wrote: > On Tue, 24 Aug 2004 08:14:46 +0200 Magnus wrote: > MF> This is an adapted version of Roberts patch which makes some more testcases > MF> pass for me. > MF> [...] > MF> Could this please be applyed to the head branch? > > I think I'm

multi-type config files [Re: AgentX broken]

2004-08-24 Thread Coders
On Tue, 24 Aug 2004 08:14:46 +0200 Magnus wrote: MF> This is an adapted version of Roberts patch which makes some more testcases MF> pass for me. MF> [...] MF> Could this please be applyed to the head branch? I think I'm going to wait on Dave for this one, as I believe I may have been barking up

Re: AgentX broken

2004-08-23 Thread Magnus Fromreide
Hello. This is an adapted version of Roberts patch which makes some more testcases pass for me. I have made a few functions that wasn't in the header file static in the process since I wanted to change their behaviour slightly in order to make error reporting consistent. Could this please be app

Re: AgentX broken

2004-08-23 Thread Magnus Fromreide
On Fri, Aug 20, 2004 at 10:30:44PM -0400, Robert Story wrote: > On Thu, 19 Aug 2004 23:52:18 +0200 Magnus wrote: > MF> I have no registrations for > MF> type:agentx:snmpd,file:/tmp/snmp-test-1-22664/snmpd.conf > MF> > MF> which I read as to mean that there are no handlers for "agentx:snmpd" so it

Re: AgentX broken

2004-08-20 Thread Coders
On Fri, 20 Aug 2004 19:35:09 -0700 Steve wrote: SF> Don't I see a memory leak here? =:-O I did mention it was a temporary fix, didn't I? Lame excuse, but it's the best one I've got. At least I didn't check it in! For the memory conscious: SF> > +char *type_list; SF>char *ty

Re: AgentX broken

2004-08-20 Thread Coders
On Thu, 19 Aug 2004 23:52:18 +0200 Magnus wrote: MF> I have no registrations for MF> type:agentx:snmpd,file:/tmp/snmp-test-1-22664/snmpd.conf MF> MF> which I read as to mean that there are no handlers for "agentx:snmpd" so it MF> seems as if the use of multiple config reader classes is somewhat br

Re: AgentX broken

2004-08-20 Thread Magnus Fromreide
On Thu, Aug 19, 2004 at 10:18:42AM +0100, Dave Shield wrote: > > Oops! > OK - this has now been added to the standard agent_includes.h file, > so should be picked up by all agent-related code files. > > I've also tweaked the Makefile to handle all the agent_module header files > appropriately, so

Re: AgentX broken

2004-08-19 Thread Dave Shield
> The current CVS code doesn't support AgentX any more since the new file > include/net-snmp/agent/agent_module_config.h that contains the definition > of USING_AGENTX_*_MODULE isn't included by the files that need it so all > code protected by those macros is effectively disabled. Oops! OK - thi

AgentX broken

2004-08-19 Thread Magnus Fromreide
Hello. The current CVS code doesn't support AgentX any more since the new file include/net-snmp/agent/agent_module_config.h that contains the definition of USING_AGENTX_*_MODULE isn't included by the files that need it so all code protected by those macros is effectively disabled. Could someone p