Re: Processing invalid messages

2010-03-31 Thread Robert Story
On Wed, 31 Mar 2010 08:48:25 -0700 Wes wrote: WH> RS> So we even want our bugs to be backwards compatible?? Don't WH> RS> think that I agree with that... WH> WH> If we believe that people are using a function for decoding a ASN range WH> that doesn't check the type of the variable (IE, int

Re: Processing invalid messages

2010-03-31 Thread Wes Hardaker
> On Wed, 31 Mar 2010 08:52:05 -0400, Robert Story > said: RS> On Tue, 30 Mar 2010 20:19:02 -0700 Wes wrote: WH> > On Tue, 16 Mar 2010 13:15:39 -0400, Robert Story said: WH> WH> RS> IMHO, bug fixes trump backwards compatibility. WH> WH> Except when it's easy to fix by introducing

Re: Processing invalid messages

2010-03-31 Thread Robert Story
On Tue, 30 Mar 2010 20:19:02 -0700 Wes wrote: WH> > On Tue, 16 Mar 2010 13:15:39 -0400, Robert Story said: WH> WH> RS> IMHO, bug fixes trump backwards compatibility. WH> WH> Except when it's easy to fix by introducing a new function instead that WH> leaves backwards compat with the old func

Re: Processing invalid messages

2010-03-30 Thread Wes Hardaker
> On Tue, 16 Mar 2010 13:15:39 -0400, Robert Story > said: RS> IMHO, bug fixes trump backwards compatibility. Except when it's easy to fix by introducing a new function instead that leaves backwards compat with the old function. -- Wes Hardaker Please mail all replies to net-snmp-coder

Re: Processing invalid messages

2010-03-16 Thread Robert Story
On Tue, 16 Mar 2010 15:53:42 +0100 Bart wrote: BVA> On Tue, Mar 16, 2010 at 2:36 PM, Jan Safranek wrote: BVA> > Based on yesterday's conversation, I prepared a patch with solution #2 BVA> > (put it inside asn_parse_foo (which may not be possible)). My simple BVA> > tests show that it works, see pa

Re: Processing invalid messages

2010-03-16 Thread Bart Van Assche
On Tue, Mar 16, 2010 at 2:36 PM, Jan Safranek wrote: > > On 03/05/2010 04:44 PM, Jan Safranek wrote: > > Hi, > > > > I've stumbled upon snmpd processing malformed requests. How should > > snmplib react to it? E.g. my snmpd received get-request with ASN.1 error > > in Request ID - instead of Type:

Re: Processing invalid messages

2010-03-16 Thread Jan Safranek
On 03/05/2010 04:44 PM, Jan Safranek wrote: > Hi, > > I've stumbled upon snmpd processing malformed requests. How should > snmplib react to it? E.g. my snmpd received get-request with ASN.1 error > in Request ID - instead of Type: 2, Length: 1, Value: 0xc it received > Type: 32, which is wrong. But

Re: Processing invalid messages

2010-03-12 Thread Wes Hardaker
> On Fri, 05 Mar 2010 16:44:13 +0100, Jan Safranek > said: JS> IMHO such malformed packets should be silently discarded. I'd agree. JS> Would you mind if I add checks to appropriate asn_parse_xxx? *If* that's the right place to do it for a given problem, I'd agree. JS> Or is it up to

Processing invalid messages

2010-03-05 Thread Jan Safranek
Hi, I've stumbled upon snmpd processing malformed requests. How should snmplib react to it? E.g. my snmpd received get-request with ASN.1 error in Request ID - instead of Type: 2, Length: 1, Value: 0xc it received Type: 32, which is wrong. But the request got processed and answered, nothing ch