Re: Proper solution for bug/patch 1633670

2011-09-02 Thread Bart Van Assche
On Tue, Aug 30, 2011 at 12:54 PM, Jan Safranek wrote: > On 08/30/2011 12:40 PM, Bart Van Assche wrote: >> Regarding your patch: are you aware that it changes the return value of >> netsnmp_remove_delegated_requests_for_session() such that it always >> returns zero ? > > It's called only on one pla

Re: Proper solution for bug/patch 1633670

2011-08-30 Thread Jan Safranek
On 08/30/2011 12:40 PM, Bart Van Assche wrote: > On Tue, Aug 30, 2011 at 10:24 AM, Jan Safranek wrote: >> Problem is that you *must* dequeue all requests which are related to the >> closing AgentX session - somewhere deep in these requests there is >> pointer to the AgentX session and the session

Re: Proper solution for bug/patch 1633670

2011-08-30 Thread Bart Van Assche
On Tue, Aug 30, 2011 at 10:24 AM, Jan Safranek wrote: > Problem is that you *must* dequeue all requests which are related to the > closing AgentX session - somewhere deep in these requests there is > pointer to the AgentX session and the session is being freed when closing. That became clear to m

Re: Proper solution for bug/patch 1633670

2011-08-30 Thread Jan Safranek
On 08/29/2011 06:00 PM, Bart Van Assche wrote: > On Fri, Aug 26, 2011 at 1:40 PM, Jan Safranek wrote: >> I debugged bug 1633670 as far as I could and I have even a >> proof-of-concept patch, but I am not so happy with it. Could someone >> with better AgentX knowledge look at it? These parts look a

Re: Proper solution for bug/patch 1633670

2011-08-29 Thread Bart Van Assche
On Fri, Aug 26, 2011 at 1:40 PM, Jan Safranek wrote: > I debugged bug 1633670 as far as I could and I have even a > proof-of-concept patch, but I am not so happy with it. Could someone > with better AgentX knowledge look at it? These parts look a bit fragile > and I don't want to break them apart

Proper solution for bug/patch 1633670

2011-08-26 Thread Jan Safranek
Hi guys, I debugged bug 1633670 as far as I could and I have even a proof-of-concept patch, but I am not so happy with it. Could someone with better AgentX knowledge look at it? These parts look a bit fragile and I don't want to break them apart with wrong patch. Thanks in advance Jan -