Re: RFV: Fix for --with-mysql for fedora15

2011-09-12 Thread Niels Baggesen
Den 12-09-2011 20:09, Bart Van Assche skrev: > MY_INIT() sets the program name that will be included in error messages > but my_init() doesn't. I sure hope that the MySQL library does not try to print any error messages by itself. > You are trying to implement a workaround for > something that i

Re: RFV: Fix for --with-mysql for fedora15

2011-09-12 Thread Bart Van Assche
On Sun, Sep 11, 2011 at 8:20 PM, Niels Baggesen wrote: > Den 11-09-2011 19:37, Bart Van Assche skrev: > >> Is it possible to develop a configure test that selects between the two >> initialization styles shown above ? >> > > Why would that be interesting? I can't why anyone would prefer the MY_INI

Re: RFV: Fix for --with-mysql for fedora15

2011-09-11 Thread Niels Baggesen
Den 11-09-2011 19:37, Bart Van Assche skrev: > Is it possible to develop a configure test that selects between the two > initialization styles shown above ? Why would that be interesting? I can't why anyone would prefer the MY_INIT method over the my_init. /Niels -- Niels Baggesen - @home - År

Re: RFV: Fix for --with-mysql for fedora15

2011-09-11 Thread Bart Van Assche
On Tue, Sep 6, 2011 at 8:14 PM, Niels Baggesen wrote: > Den 01-09-2011 17:25, Niels Baggesen skrev: > > First off it fixes the compile. > > > > This was a quick warning of a problem. I will see if I can set up a > > MySQL server to test, unless some of you have a working setup ... > > Right, havi

Re: RFV: Fix for --with-mysql for fedora15

2011-09-06 Thread Niels Baggesen
Den 01-09-2011 17:25, Niels Baggesen skrev: > First off it fixes the compile. > > This was a quick warning of a problem. I will see if I can set up a > MySQL server to test, unless some of you have a working setup ... Right, having set up a test environment under CentOS 5, the patch is as follows

Re: RFV: Fix for --with-mysql for fedora15

2011-09-01 Thread Wes Hardaker
> On Thu, 1 Sep 2011 17:25:38 +0200, Niels Baggesen > said: >> Have you tested this change yet? Or does this just fix the compile? NB> First off it fixes the compile. NB> This was a quick warning of a problem. I will see if I can set up a NB> MySQL server to test, unless some of you h

Re: RFV: Fix for --with-mysql for fedora15

2011-09-01 Thread Niels Baggesen
On Thu, Sep 01, 2011 at 07:34:39AM -0700, Wes Hardaker wrote: > A quick grep seems to indicate we're not calling those other functions. That was what I thought > Have you tested this change yet? Or does this just fix the compile? First off it fixes the compile. This was a quick warning of a pr

Re: RFV: Fix for --with-mysql for fedora15

2011-09-01 Thread Wes Hardaker
> On Wed, 31 Aug 2011 21:53:06 +0200, Niels Baggesen > said: NB> Fedora15 has MySQL 5.5 which does not like the MY_INIT call in NB> snmptrapd_sql. NB> May I suggest this fix: NB> diff --git a/apps/snmptrapd_sql.c b/apps/snmptrapd_sql.c NB> index c7433dc..74b660f 100644 NB> --- a/apps/

RFV: Fix for --with-mysql for fedora15

2011-08-31 Thread Niels Baggesen
Fedora15 has MySQL 5.5 which does not like the MY_INIT call in snmptrapd_sql. May I suggest this fix: diff --git a/apps/snmptrapd_sql.c b/apps/snmptrapd_sql.c index c7433dc..74b660f 100644 --- a/apps/snmptrapd_sql.c +++ b/apps/snmptrapd_sql.c @@ -437,8 +437,6 @@ netsnmp_mysql_init(void)