Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-27 Thread Bart Van Assche
On Tue, May 25, 2010 at 8:00 PM, Wes Hardaker < harda...@users.sourceforge.net> wrote: > > On Tue, 25 May 2010 09:27:38 +0100, Dave Shield < > d.t.shi...@liverpool.ac.uk> said: > > DS> What are the advantages to keeping these two libraries separate? > > Well, I should speak up since I created

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Magnus Fromreide
On Wed, 2010-05-26 at 00:54 +0200, Thomas Anders wrote: > Dave Shield wrote: > > What are the advantages to keeping these two libraries separate? > > What (amount of) code out there would only depend on the agent lib > (and not the helpers lib) if the dependencies were clean? agentxtrap (the agen

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Wes Hardaker
> On Wed, 26 May 2010 01:27:00 +0200, Thomas Anders > said: >> I'm not sure which (if any) of the extension mechanisms rely on >> the helpers library, and which just on the agent lib. TA> I would certainly be interested to know! I suspect in theory it'd be nice if they were separate.

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Thomas Anders
Dave Shield wrote: > I'm not sure which (if any) of the extension mechanisms rely on > the helpers library, and which just on the agent lib. I would certainly be interested to know! +Thomas -- _

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Dave Shield
On 25 May 2010 23:54, Thomas Anders wrote: > Dave Shield wrote: >> What are the advantages to keeping these two libraries separate? > > What (amount of) code out there would only depend on the agent lib > (and not the helpers lib) if the dependencies were clean? Presumably just an agent (or subag

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Thomas Anders
Dave Shield wrote: > What are the advantages to keeping these two libraries separate? What (amount of) code out there would only depend on the agent lib (and not the helpers lib) if the dependencies were clean? That code (with its dependencies) would benefit from having a smaller footprint, then

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Thomas Anders
Bart Van Assche wrote: > On Mon, May 24, 2010 at 11:47 PM, Thomas Anders > mailto:thomas.and...@blue-cable.de>> wrote: > What's the "business case"? I suggest to look at this from a users > perspective: what exactly do they get in exchange for a backwards > incompatible change? > > Thi

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Wes Hardaker
> On Tue, 25 May 2010 09:27:38 +0100, Dave Shield > said: DS> What are the advantages to keeping these two libraries separate? Well, I should speak up since I created the separation. The reality is that it's just a "functional" difference. IE, the helpers was designed to be all the co

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Wes Hardaker
> On Mon, 24 May 2010 20:10:59 +0200, Bart Van Assche > said: BVA> +static void __attribute__((constructor)) No... I wish that was portable, but it'll certainly cause problems. Cool solution, but not one we can consider. -- Wes Hardaker Please mail all replies to net-snmp-coders@lists

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-25 Thread Dave Shield
On 25 May 2010 06:35, Bart Van Assche wrote: > And a third alternative is to merge libnetsnmphelpers into libnetsnmpagent. I was going to ask whether that idea had been dropped. It seemed to be the proposed solution from my brief look at the Library layering page. That would seem to have the a

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-24 Thread Bart Van Assche
On Mon, May 24, 2010 at 5:46 PM, Wes Hardaker < harda...@users.sourceforge.net> wrote: > > On Mon, 24 May 2010 14:08:02 +0200, Bart Van Assche < > bvanass...@acm.org> said: > > BVA> The patch below fixes the circular dependency between > libnetsnmphelpers and > BVA> libnetsnmpagent. > > That o

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-24 Thread Bart Van Assche
On Mon, May 24, 2010 at 11:47 PM, Thomas Anders wrote: > Bart Van Assche wrote: > > The patch below fixes the circular dependency between libnetsnmphelpers > > and libnetsnmpagent. It does this by removing the netsnmp_init_helpers() > > call from init_agent() and by adding an explicit call to > >

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-24 Thread Thomas Anders
Bart Van Assche wrote: > The patch below fixes the circular dependency between libnetsnmphelpers > and libnetsnmpagent. It does this by removing the netsnmp_init_helpers() > call from init_agent() and by adding an explicit call to > netsnmp_init_helpers() after every call to init_agent(). This is a

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-24 Thread Magnus Fromreide
On Mon, 2010-05-24 at 20:10 +0200, Bart Van Assche wrote: > > An alternative is the patch below. init_agent() still calls > netsnmp_init_helpers(), but only if libnetsnmphelpers.so has been > loaded before libnetsnmpagent.so. This has been realized by adding a > shared-library initialization func

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-24 Thread Bart Van Assche
On Mon, May 24, 2010 at 5:46 PM, Wes Hardaker < harda...@users.sourceforge.net> wrote: > > On Mon, 24 May 2010 14:08:02 +0200, Bart Van Assche < > bvanass...@acm.org> said: > > BVA> The patch below fixes the circular dependency between > libnetsnmphelpers and > BVA> libnetsnmpagent. > > That o

Re: Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-24 Thread Wes Hardaker
> On Mon, 24 May 2010 14:08:02 +0200, Bart Van Assche > said: BVA> The patch below fixes the circular dependency between libnetsnmphelpers and BVA> libnetsnmpagent. That one call is the only dependency? (which surprises me in itself). Sigh... If we go that route it certainly warrants

Resolving the circular dependency between libnetsnmphelpers and libnetsnmpagent

2010-05-24 Thread Bart Van Assche
Hello, The patch below fixes the circular dependency between libnetsnmphelpers and libnetsnmpagent. It does this by removing the netsnmp_init_helpers() call from init_agent() and by adding an explicit call to netsnmp_init_helpers() after every call to init_agent(). This is a backwards incompatible