Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-16 Thread Jochen Friedrich
Hi Thomas, > I think it's overdue. I'm happy to attach a revised patch that changes all oid > length variables/parameters consistently to size_t, matching the main library. > I'm calling for votes to include this in 5.4. +1 from me. From the Debian point of view, the next release will support y

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-14 Thread Thomas Anders
G. S. Marzot wrote: > +1 - I will be happy to review the changes too. They're already in CVS MAIN. Feel free to double-check them. +Thomas -- Thomas Anders (thomas.anders at blue-cable.de) - Using Tomcat but need to do mo

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-14 Thread G. S. Marzot
Thomas Anders wrote: > > I think it's overdue. I'm happy to attach a revised patch that changes all oid > length variables/parameters consistently to size_t, matching the main library. > I'm calling for votes to include this in 5.4. > > > +Thomas > +1 - I will be happy to review the changes to

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-13 Thread Wes Hardaker
> "TA" == Thomas Anders <[EMAIL PROTECTED]> writes: TA> May I take your positive comments as a "+1" vote? Yes, on the patch you sent. -- Wes Hardaker Sparta, Inc. - Using Tomcat but need to do more? Need to support web

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-13 Thread Thomas Anders
Wes Hardaker wrote: >> Additionally this looks like a general fault case that could be present >> in more places so maybe a global search for size_t/int confusion might >> be in place as well? > > TA> I think it's overdue. I'm happy to attach a revised patch that > TA> changes all oid length varia

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-13 Thread Wes Hardaker
> Additionally this looks like a general fault case that could be present > in more places so maybe a global search for size_t/int confusion might > be in place as well? TA> I think it's overdue. I'm happy to attach a revised patch that TA> changes all oid length variables/parameters consistently

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-13 Thread Robert Story
On Mon, 13 Nov 2006 16:32:21 +0100 Thomas wrote: TA> Robert Story wrote: TA> > On Sun, 12 Nov 2006 00:03:43 +0100 Thomas wrote: TA> > TA> > Here's the offending call that fails on 64-bit: TA> > TA> > TA> > TA> > SNMP::translateObj('.iso.org.dod.internet.mgmt.mib-2.system.sysDescr'); TA> > TA> TA

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-13 Thread Thomas Anders
Robert Story wrote: > On Sun, 12 Nov 2006 00:03:43 +0100 Thomas wrote: > TA> > Here's the offending call that fails on 64-bit: > TA> > > TA> > SNMP::translateObj('.iso.org.dod.internet.mgmt.mib-2.system.sysDescr'); > TA> > TA> Here's the one-line patch that fixes this bug. Somewhat of a no-braine

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-13 Thread Robert Story
On Sun, 12 Nov 2006 00:03:43 +0100 Thomas wrote: TA> > Here's the offending call that fails on 64-bit: TA> > TA> > SNMP::translateObj('.iso.org.dod.internet.mgmt.mib-2.system.sysDescr'); TA> TA> Here's the one-line patch that fixes this bug. Somewhat of a no-brainer given TA> that on 64-bit plat

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-12 Thread Marcus Rueckert
On 2006-11-12 15:18:10 +0100, Thomas Anders wrote: > Magnus Fromreide wrote: > > I am thus more inclined towards a patch that also changes the signature > > of __scan_num_objid to > > > > static int __scan_num_objid _((char *, oid *, size_t *)); > > > > to make the patch more correct. > > Agreed

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-12 Thread Thomas Anders
Magnus Fromreide wrote: > I am thus more inclined towards a patch that also changes the signature > of __scan_num_objid to > > static int __scan_num_objid _((char *, oid *, size_t *)); > > to make the patch more correct. Agreed. > Additionally this looks like a general fault case that could be

Re: rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-12 Thread Magnus Fromreide
On sön, 2006-11-12 at 00:03 +0100, Thomas Anders wrote: > Thomas Anders wrote: > > Thomas Anders wrote: > >> t/mib.dubious > > > > Here's the offending call that fails on 64-bit: > > > > SNMP::translateObj('.iso.org.dod.internet.mgmt.mib-2.system.sysDescr'); > > Here's the one-line patch

rfv: 5.4.rc2 SNMP.pm MIB code broken on 64-bit

2006-11-11 Thread Thomas Anders
Thomas Anders wrote: > Thomas Anders wrote: >> t/mib.dubious > > Here's the offending call that fails on 64-bit: > > SNMP::translateObj('.iso.org.dod.internet.mgmt.mib-2.system.sysDescr'); Here's the one-line patch that fixes this bug. Somewhat of a no-brainer given that on 64-bit platfo