Re: rfv: properly protect nlist code in snmplib/system.c

2006-11-18 Thread Wes Hardaker
> "TA" == Thomas Anders <[EMAIL PROTECTED]> writes: TA> snmplib/system.c uses nlist() (and open(/dev/kmem), lseek and read) TA> without properly protecting the code by #ifdef NETSNMP_CAN_USE_NLIST. TA> Thus, this code is active even if --without-kmem-usage has been TA> specified (recommended i

Re: rfv: properly protect nlist code in snmplib/system.c

2006-11-15 Thread Marcus Rueckert
hi, the patch looks fine to me. +1 darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org - Take Surveys. Earn Cash. Influence the Future of IT J

Re: rfv: properly protect nlist code in snmplib/system.c

2006-11-14 Thread Demetri S . Mouratis
> > DSM> [patch snipped] > > DSM> As a motivated user (I'm trying to run on AIX with --without- > kmem- > DSM> usage), I vote +1 :-) > > Did you try it on AIX and it worked? You don't clearly state whether > it just looked good or whether you tried it and it fixed your issues. > -- > Wes Hardake

Re: rfv: properly protect nlist code in snmplib/system.c

2006-11-14 Thread Wes Hardaker
> "DSM" == Demetri S Mouratis <[EMAIL PROTECTED]> writes: DSM> [patch snipped] DSM> As a motivated user (I'm trying to run on AIX with --without-kmem- DSM> usage), I vote +1 :-) Did you try it on AIX and it worked? You don't clearly state whether it just looked good or whether you tried it

Re: rfv: properly protect nlist code in snmplib/system.c

2006-11-14 Thread Demetri S. Mouratis
> > > From: Thomas Anders <[EMAIL PROTECTED]> > Date: November 13, 2006 10:05:59 AM CST > To: net-snmp-coders@lists.sourceforge.net > Subject: rfv: properly protect nlist code in snmplib/system.c > Reply-To: net-snmp-coders@lists.sourceforge.net > > > -Cod

Re: rfv: properly protect nlist code in snmplib/system.c

2006-11-13 Thread Thomas Anders
Robert Story wrote: > What problem does it fix? Does it cause a crash? It's really getting rather > late in the release process, and I think we need to start focusing on > show-stoppers, rather than general cleanup... When building with --without-kmem-usage on IRIX you'll end up with an undefined

Re: rfv: properly protect nlist code in snmplib/system.c

2006-11-13 Thread Robert Story
On Mon, 13 Nov 2006 17:05:59 +0100 Thomas wrote: TA> snmplib/system.c uses nlist() (and open(/dev/kmem), lseek and read) TA> without properly protecting the code by #ifdef NETSNMP_CAN_USE_NLIST. TA> Thus, this code is active even if --without-kmem-usage has been TA> specified (recommended in README

rfv: properly protect nlist code in snmplib/system.c

2006-11-13 Thread Thomas Anders
-Coders, snmplib/system.c uses nlist() (and open(/dev/kmem), lseek and read) without properly protecting the code by #ifdef NETSNMP_CAN_USE_NLIST. Thus, this code is active even if --without-kmem-usage has been specified (recommended in README.aix and README.irix for 64-bit builds), which is a bug