Re: rfv: remove asserts with undefined string comparisons

2007-07-16 Thread Wes Hardaker
> "TA" == Thomas Anders <[EMAIL PROTECTED]> writes: >> here we go. the final one. i hope :) TA> +1 (on v3 of this patch) Applied. All current branches. Thanks! -- Wes Hardaker Sparta, Inc. - This SF.net email is spons

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Thomas Anders
Marcus Rueckert wrote: > here we go. the final one. i hope :) +1 (on v3 of this patch) +Thomas - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of you

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Marcus Rueckert
On 2007-07-04 15:50:46 -0400, Robert Story wrote: > On Wed, 4 Jul 2007 20:15:27 +0100 Dave wrote: > DS> On 04/07/07, Marcus Rueckert <[EMAIL PROTECTED]> wrote: > DS> > ok after another discussion on irc with robert and thomas, we got v2 of > DS> > the patch. instead of removing the asserts we make

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 20:15:27 +0100 Dave wrote: DS> On 04/07/07, Marcus Rueckert <[EMAIL PROTECTED]> wrote: DS> > ok after another discussion on irc with robert and thomas, we got v2 of DS> > the patch. instead of removing the asserts we make the conditions static DS> > strings. the compiler shuts up

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Dave Shield
On 04/07/07, Marcus Rueckert <[EMAIL PROTECTED]> wrote: > ok after another discussion on irc with robert and thomas, we got v2 of > the patch. instead of removing the asserts we make the conditions static > strings. the compiler shuts up and robert still gets his debug message. Why is the first as

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Robert Story
On Wed, 4 Jul 2007 18:32:42 +0200 Marcus wrote: MR> ok after another discussion on irc with robert and thomas, we got v2 of MR> the patch. instead of removing the asserts we make the conditions static MR> strings. the compiler shuts up and robert still gets his debug message. +1 -

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Thomas Anders
Marcus Rueckert wrote: > ok after another discussion on irc with robert and thomas, we got v2 of > the patch. instead of removing the asserts we make the conditions static > strings. the compiler shuts up and robert still gets his debug message. +1 with remark: Could you add the "always false/fail

Re: rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Marcus Rueckert
On 2007-07-04 17:42:57 +0200, Marcus Rueckert wrote: > all the asserts removed in this patch use != or == for string > comparison, which is undefined in C. after a discussion on irc with Wes > and Robert, i followed Wes' suggestion and removed the offending > asserts. > > Can we still apply it for

rfv: remove asserts with undefined string comparisons

2007-07-04 Thread Marcus Rueckert
hi, all the asserts removed in this patch use != or == for string comparison, which is undefined in C. after a discussion on irc with Wes and Robert, i followed Wes' suggestion and removed the offending asserts. Can we still apply it for 5.4.1?:) darix -- openSUSE - SUSE Linux is