Re: [netcf-devel] [PATCH 1/5] don't redefine DATADIR

2015-03-16 Thread Laine Stump
On 03/16/2015 11:03 AM, Laine Stump wrote: >^ > > To eliminate the warnings, all we need to do is remove the pointless Sigh. I had already amended this commit message to complete the sentence fragment, but forgot to finish out the commit, so it sent the old version... ___

[netcf-devel] [PATCH 5/5] Update STR*() macros to match those in libvirt

2015-03-16 Thread Laine Stump
netcf's internal.h already had some of the other STR*() macros that are in libvirt, but was missing some. A couple of the macros now use the gnulib variants of strcase* functions, so the appropriate module is added to bootstrap.conf and the #include is added to internal.h. --- bootstrap.conf | 3

[netcf-devel] [PATCH 0/5] Various small tweaks/fixes.

2015-03-16 Thread Laine Stump
I made these changes while working on something slightly more significant, and wanted to get them out of the way. Laine Stump (5): don't redefine DATADIR use augeas typedef instead of "struct augeas" remove unnecessary calls to get_augeas() Update gnulib Update STR*() macros to match tho

[netcf-devel] [PATCH 2/5] use augeas typedef instead of "struct augeas"

2015-03-16 Thread Laine Stump
I'm not sure why all definitions of augeas objects use struct augeas, as the typedef has existed longer than netcf has (since 2008 according to augeas git). --- src/drv_debian.c | 8 src/drv_redhat.c | 18 +- src/drv_suse.c| 24 src/dutil_li

[netcf-devel] [PATCH 3/5] remove unnecessary calls to get_augeas()

2015-03-16 Thread Laine Stump
There were several functions in drv_redhat.c that apparently had previously required an augeas object, but no longer do (if the augeas object was required, the return value of get_augeas() would have been saved, and the side effect of rereading the augeas tree from disk isn't needed as any subordin

[netcf-devel] [PATCH 4/5] Update gnulib

2015-03-16 Thread Laine Stump
This updates the gnulib used by netcf to the latest git master commit 0f4fa16dfd89eece82848858e327d6320c27e4bf. This wasn't necessary for any particular reason, just general housekeeping. --- .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index d5fec6

[netcf-devel] [PATCH 1/5] don't redefine DATADIR

2015-03-16 Thread Laine Stump
A long time ago netcf #defined DATADIR as the base directory for data files (usually "/usr/share") in datadir.h which was autogenerated by a Makefile rule, but this conflicted with a different use of DATADIR somewhere within WIN32 config files, so when the basic (incomplete / never finished) WIN32