[PATCH 1/1] Implement cheapest way of supporting DCCPDIAG_GETSOCK

2005-08-10 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/ Now this tree has _two_ outstanding changesets. Below are just IPPROTO_DCCP sockets. [EMAIL PROTECTED] ~]# ./ss -dane State Recv-Q Send-Q Local Address:P

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-10 Thread Philippe De Muyter
Paul Mackerras wrote : > Philippe De Muyter writes: > > > Actually, that's probably the case I had, but my fix gets the ip adresses > > 4byte aligned in my case : I had verified the address of the saddr field, > > and I needed to shift the buffer by 3, not 1, to get it 4byte aligned. > > Please o

Re: skb->pkt_type

2005-08-10 Thread Harald Welte
On Tue, Aug 09, 2005 at 04:36:58PM -0700, David S. Miller wrote: > > I pushed a bunch of bluetooth updates into my net-2.6.14 > tree, and in there you will find the change to make > the bluetooth stack not use skb->pkt_type in the funny > way it used to. > > This opens up the possibility to shrin

Re: [PATCH] untracked fix now in Linus' tree, but not in net-2.6.14

2005-08-10 Thread Harald Welte
On Tue, Aug 09, 2005 at 12:00:00PM -0700, David S. Miller wrote: > I absolutely do not like applying a patch twice, once in > net-2.6.13 and once in net-2.6.14, just to get it to > show up in both places. That makes for merge headaches > later. Ok, thanks for the explanation. Now I know your str

Re: skb->pkt_type

2005-08-10 Thread Harald Welte
On Wed, Aug 10, 2005 at 12:59:11PM +0200, Harald Welte wrote: > thanks. So my initial idea was to put those three bits into the > "local_df,cloned,ip_summed,nohdr" bitfield. But meanwhile I stuffed > nfctinfo into that field, so there is no space. I meant something like this (totally untested):

Re: 8139cp misses interrupts during resume

2005-08-10 Thread Pierre Ossman
Pierre Ossman wrote: > Pierre Ossman wrote: > >>I'm having problem with the interrupt getting killed after suspend with >>my 8139cp controller. The problem only appears if the cable is connected >>during resume (before suspend is irrelevant) and the interface is down. >> >>Both suspend-to-disk and

kernel to userspace communication

2005-08-10 Thread knash
Hello all, I'm writing a kernel module which intercepts incoming IP packets and reads information from a custom header. The information contained in "My header" is passed to userspace via netlink. So userspace builds up a picture of the current network state, neighbouring nodes etc. I've inser

[Patch] Use sk_stream_error function rather than DECnet's own

2005-08-10 Thread Steven Whitehouse
Hi, Below is the patch I mentioned at UKUUG, its against an older kernel but it still applies when I tried it against 2.6.12 just now, Steve. - Signed-off-by: Steven Whitehouse <[EMAIL PROTECTED]> diff -Nru linux-2.6.1

Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- revised flow cache [resend]

2005-08-10 Thread Trent Jaeger
I see. Yes, I need to do pfkey_sadb2xfrm_user_ctx there as well. Regards, Trent. Trent Jaeger IBM T.J. Watson Research Center 19 Skyline Drive, Hawthorne, NY 10532 (914) 784-7225, FAX (914) 784-7225 Herbert Xu <[EMAIL PROTECTED]>

about PMTU discovery in IPSEC

2005-08-10 Thread Louis Croisez
Hi, i am currently reading the ipsec kernel source code and i need some help for specialists : Does the current IPSEC implementation in last kernel 2.6 uses PMTU discovery with cookie protection (anti DoS)? If not, what is the reason for this? Is there a entry in /proc or /sys to enable/disable thi

Re: kernel to userspace communication

2005-08-10 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: Hello all, I'm writing a kernel module which intercepts incoming IP packets and reads information from a custom header. The information contained in "My header" is passed to userspace via netlink. So userspace builds up a picture of the current network state, neighbouring

[PATCH] disable DEBUG in ibmveth

2005-08-10 Thread Anton Blanchard
At the moment ibmveth has DEBUG enabled which is rather verbose. Disable it. Signed-off-by: Anton Blanchard <[EMAIL PROTECTED]> Index: foobar2/drivers/net/ibmveth.c === --- foobar2.orig/drivers/net/ibmveth.c 2005-07-06 07:49:42.000

[PATCH] make use of ->private_data in sockfd_lookup

2005-08-10 Thread Benjamin LaHaise
Hello Dave, all, Please consider the patch below which makes use of file->private_data to store the pointer to the socket, which avoids touching several unused cachelines in the dentry and inode in sockfd_lookup. diff -purN 00_v2.6.13-rc6/net/socket.c 01_net_file/net/socket.c --- 00_v2.6.13-rc6

Re: [PATCH] disable DEBUG in ibmveth

2005-08-10 Thread Patrick McHardy
Anton Blanchard wrote: > At the moment ibmveth has DEBUG enabled which is rather verbose. Disable > it. > > -#define DEBUG 1 > +#undef DEBUG 1 The trailing 1 will cause a warning. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH] disable DEBUG in ibmveth

2005-08-10 Thread Anton Blanchard
> The trailing 1 will cause a warning. Good point. -- At the moment ibmveth has DEBUG enabled which is rather verbose. Disable it. Signed-off-by: Anton Blanchard <[EMAIL PROTECTED]> Index: foobar2/drivers/net/ibmveth.c === --- fo

where is ethtool source hosted now?

2005-08-10 Thread Jesse Brandeburg
where is the ethtool source hosted now? I wanted to make some patches against the latest version. It used to be in bitkeeper but i don't see it at http://www.kernel.org/git Jesse - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [Patch] Use sk_stream_error function rather than DECnet's own

2005-08-10 Thread David S. Miller
From: Steven Whitehouse <[EMAIL PROTECTED]> Date: Wed, 10 Aug 2005 15:45:55 +0100 > Below is the patch I mentioned at UKUUG, its against an older kernel but > it still applies when I tried it against 2.6.12 just now, Applied, thanks Steven. - To unsubscribe from this list: send the line "unsubscr

Re: where is ethtool source hosted now?

2005-08-10 Thread Randy.Dunlap
On Wed, 10 Aug 2005, Jesse Brandeburg wrote: > where is the ethtool source hosted now? I wanted to make some patches > against the latest version. > > It used to be in bitkeeper but i don't see it at http://www.kernel.org/git good question. all i know of is Jeff's files (including ethtool) at h

Re: [PATCH] make use of ->private_data in sockfd_lookup

2005-08-10 Thread David S. Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Wed, 10 Aug 2005 12:46:55 -0400 > Please consider the patch below which makes use of file->private_data to > store the pointer to the socket, which avoids touching several unused > cachelines in the dentry and inode in sockfd_lookup. Please repor

Re: [PATCH] make use of ->private_data in sockfd_lookup

2005-08-10 Thread Benjamin LaHaise
Here is a resend properly signed off. Please consider the patch below which makes use of file->private_data to store the pointer to the socket, which avoids touching several unused cachelines in the dentry and inode in sockfd_lookup. Signed-off-by: Benjamin LaHaise <[EMAIL PROTECTED]> diff -pur

Re: [PATCH] make use of ->private_data in sockfd_lookup

2005-08-10 Thread David S. Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Wed, 10 Aug 2005 17:17:37 -0400 > Here is a resend properly signed off. Applied to net-2.6.14, thanks Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes, take two

2005-08-10 Thread David S. Miller
From: Peter Hagervall <[EMAIL PROTECTED]> Date: Tue, 9 Aug 2005 09:49:10 +0200 > This patch contains the following possible cleanups/fixes: Applied to net-2.6.14, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: where is ethtool source hosted now?

2005-08-10 Thread Jeff Garzik
Randy.Dunlap wrote: On Wed, 10 Aug 2005, Jesse Brandeburg wrote: where is the ethtool source hosted now? I wanted to make some patches against the latest version. It used to be in bitkeeper but i don't see it at http://www.kernel.org/git good question. all i know of is Jeff's files (inclu

Re: where is ethtool source hosted now?

2005-08-10 Thread Randy.Dunlap
On Wed, 10 Aug 2005, Jeff Garzik wrote: > Randy.Dunlap wrote: > > On Wed, 10 Aug 2005, Jesse Brandeburg wrote: > > > > > >>where is the ethtool source hosted now? I wanted to make some patches > >>against the latest version. > >> > >>It used to be in bitkeeper but i don't see it at http://www.kern

Re: that TCP bug

2005-08-10 Thread Herbert Xu
On Tue, Aug 09, 2005 at 10:19:11PM +1000, herbert wrote: > > So cnt is equal to fackets_out - reordering. Normally > fackets_out is less than packets_out. The only reason > I've found that might cause fackets_out to exceed packets_out > is if tcp_fragment is called from tcp_retransmit_skb with a

Question about SO_LINGER

2005-08-10 Thread steve roussey
In a conversation the other yesterday about web servers, this came up in conversation by another much more informed than I. I'm not sure if the information is up to date to current kernel builds, so I pose the question here: Does the linux kernel block on SO_LINGER? Here is paragraph in the other

Re: that TCP bug

2005-08-10 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 11 Aug 2005 07:55:36 +1000 > Here is a patch that adjusts fackets_out accordingly. And what's more the original code there modifying packets_out looks wrong. I think I'm going to push this in for 2.6.13. - To unsubscribe from this list: send the li

Re: that TCP bug

2005-08-10 Thread Herbert Xu
On Wed, Aug 10, 2005 at 06:29:56PM -0700, David S. Miller wrote: > > And what's more the original code there modifying packets_out > looks wrong. Hmm I was actually careful in making sure the rewritten expression did the same thing to packets_out so I hope that's not the case :) I just had anoth

Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Herbert Xu
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > > -/* FIXME: this is utterly wrong */ > +/* Structure describing an Internet (DCCP) socket address. */ > struct sockaddr_dccp { > - struct sockaddr_in in; > - unsigned intservice; > + __u16 sdccp_family; /

Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Ian McDonald
On 11/08/05, Herbert Xu <[EMAIL PROTECTED]> wrote: > Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > > > > -/* FIXME: this is utterly wrong */ > > +/* Structure describing an Internet (DCCP) socket address. */ > > struct sockaddr_dccp { > > - struct sockaddr_in in; > > - unsi

Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Herbert Xu
On Thu, Aug 11, 2005 at 02:18:31PM +1200, Ian McDonald wrote: > On 11/08/05, Herbert Xu <[EMAIL PROTECTED]> wrote: > > Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > > > > > > -/* FIXME: this is utterly wrong */ > > > +/* Structure describing an Internet (DCCP) socket address. */ > > > struc

Re: [PATCH 2/3][DCCP] Fix struct sockaddr_dccp definition

2005-08-10 Thread Ian McDonald
> In that case wouldn't it be better if this user-visible structure is > designed in a way so that it can support IPv6 later on? > Yep. Feel free to submit patches! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [RFT] Yukon 2 driver

2005-08-10 Thread Jeff Garzik
Stephen Hemminger wrote: Here is a new Yukon 2 driver. It is based on the out-of-tree version of sk98lin, but is structured like the skge driver. Although this driver has TSO and checksum offload, it is fragile at this point and probably has lots of BUGS. It dies under stress from receive ring g

Re: [RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output by ethtool -d

2005-08-10 Thread Jeff Garzik
Malli Chilakala wrote: Fix data output by ethtool -d Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c netdev-2.6/drivers/net/ixgb

Re: [RESEND][PATCH net-drivers-2.6 1/9] ixgb: Set RXDCTL:PTHRESH/HTHRESH to zero

2005-08-10 Thread Jeff Garzik
Malli Chilakala wrote: Set RXDCTL:PTHRESH/HTHRESH to zero Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> diff -up netdev-2.6/drivers/net/ixgb/ixgb_main.c netdev-2.6/drivers/net/ix

Re: [PATCH] Gianfar PHY Layer Update

2005-08-10 Thread Jeff Garzik
not applied: Applying 'Gianfar PHY Layer Update' error: patch failed: drivers/net/gianfar.c:393 error: drivers/net/gianfar.c: patch does not apply error: drivers/net/gianfar_mii.c: No such file or directory - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me