[PATCH] Deinitialise static variables in net/core/pktgen.c

2005-12-19 Thread Jaco Kroon
static variables should not be explicitly initialised to 0. This causes them to be placed in .data instead of .bss. This patch de-initialises 3 static variables in net/core/pktgen.c. There are approximately 800 more such variables in the source tree (2.6.15rc5). If there is more interrest I'd b

Re: [Ipsec-tools-devel] Re: [PATCH]: Re: SA switchover

2005-12-19 Thread David S. Miller
From: Krzysztof Oledzki <[EMAIL PROTECTED]> Date: Tue, 20 Dec 2005 06:25:12 +0100 (CET) > Yes, it works now perfectly: Wonderful, it's in Linus's 2.6.15 tree and submitted for 2.6.14-stable. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: [Ipsec-tools-devel] Re: [PATCH]: Re: SA switchover

2005-12-19 Thread Krzysztof Oledzki
On Mon, 19 Dec 2005, David S. Miller wrote: From: Krzysztof Oledzki <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 10:37:14 +0100 (CET) OK. With this patch kernel switches to new SA immediately, but only for ping. TCP (ssh) session between Cisco and Linux is still protected by the old SA. Ok,

Re: [PATCH] speed up __alloc_skb

2005-12-19 Thread David S. Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 17 Dec 2005 12:50:28 + > The Xen networking stuff is a piece of crap currently and far a way from > beeing mergeable. I think we should kill it and if Xen still needs it after > their networking code is rewritten to something sane we can

Re: [PATCH]: Re: SA switchover

2005-12-19 Thread Krzysztof Oledzki
On Mon, 19 Dec 2005, jamal wrote: On Mon, 2005-19-12 at 13:57 -0800, David S. Miller wrote: From: jamal <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 08:17:19 -0500 Just an addendum: If this works it should be sysctl controlled i hope. There is absolutely no reason for that, so no :) Well

Re: SACK performance improvements - technical report and updated 2.6.6 patches

2005-12-19 Thread David S. Miller
From: "Injong Rhee" <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 21:11:40 -0500 > I wonder the same. I wonder how this new patch by the HTCP folks > improves what we provided for the 2.6.x (which is currently > incorporated in the latest linux version). My recollection says that > this HTCP patch pe

RE: SACK performance improvements - technical report and updated 2.6.6 patches

2005-12-19 Thread Injong Rhee
I wonder the same. I wonder how this new patch by the HTCP folks improves what we provided for the 2.6.x (which is currently incorporated in the latest linux version). My recollection says that this HTCP patch periodically crashes the system very often -- so we could not run the comparison. BTW, th

Re: Intel e1000 fails after RAM upgrade

2005-12-19 Thread Carsten Otto
On Mon, Dec 19, 2005 at 03:35:57PM -0800, Jesse Brandeburg wrote: > > TDH <2000> > > TDT <2000> > > next_to_use <6> > > next_to_clean<0> > > buffer_info[next_to_clean] > > dma <13024c002> > > time_stamp > >

Re: [PATCH]: Re: SA switchover

2005-12-19 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 19:18:55 -0500 > BTW, what kernels are these patches against? 2.6.15-GIT, and it would likely apply to 2.6.14 as well :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH]: Re: SA switchover

2005-12-19 Thread jamal
On Mon, 2005-19-12 at 13:57 -0800, David S. Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Mon, 19 Dec 2005 08:17:19 -0500 > > > Just an addendum: If this works it should be sysctl controlled i hope. > > There is absolutely no reason for that, so no :) > Well, we went from "use old SA"

Re: [PATCH 1/4] tg3: Fix peer device handling

2005-12-19 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 15:02:31 -0800 > Has anyone made a stab at making the firmware loadable from the > hotplug framework (to keep Debian happy)? We changed the licensing statement to make them happy, at the top of tg3.c it states: * Firmware is: *

Re: [PATCH 3/4] tg3: Add tw32_wait_f() for some sensitive registers

2005-12-19 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 13:18:47 -0800 > BTW, I have considered always using config. cycles for such registers. > Config. cycles are non-posted and do not require read back. But our hw > engineers told me that it would still be safer to use mem. cycles even

Re: Intel e1000 fails after RAM upgrade

2005-12-19 Thread Jesse Brandeburg
On 12/19/05, Carsten Otto <[EMAIL PROTECTED]> wrote: > Hi there! > > First the basic system specs: > Athlon64 3500+ S939, Winchester > Kernel 2.6.14.4, X86_64 > 4*1 GB RAM DDR 333, Dual Channel [before: 2*1 GB RAM DDR 400, Dual Channel] > Intel Gigabit PCI (Intel Corporation 82540EM Gigabit Etherne

Re: [XFRM]: Handle DCCP in xfrm{4,6}_decode_session

2005-12-19 Thread Arnaldo Carvalho de Melo
On 12/19/05, David S. Miller <[EMAIL PROTECTED]> wrote: > > Applied, thanks Patrick. Thanks to both, for the patch and for applying :-) - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH 1/4] tg3: Fix peer device handling

2005-12-19 Thread Stephen Hemminger
Has anyone made a stab at making the firmware loadable from the hotplug framework (to keep Debian happy)? -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROT

Re: [PATCH 3/4] tg3: Add tw32_wait_f() for some sensitive registers

2005-12-19 Thread Michael Chan
On Mon, 2005-12-19 at 14:51 -0800, David S. Miller wrote: > And if the PCI write gets posted for "X" usec, we'll still do the PCI > read back-to-back with the write it will thus still hang. This change > makes the "_f()" part totally pointless. There is nothing to flush > out if we're going to u

Re: [PATCH 3/4] tg3: Add tw32_wait_f() for some sensitive registers

2005-12-19 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 13:02:36 -0800 > The tw32_f() function (register write with immediate read flush) can > hang when used on some registers to switch clock frequencies and > power. A new tw32_wait_f() is added for such registers with the > delay before

[BUG][PATCH] e1000: Fix invalid memory reference

2005-12-19 Thread Jesse Brandeburg
Thanks for the patch! Jeff, if you would be so kind as to apply this, thanks... This patch fixes invalid memory reference in the e1000 driver which would cause kernel panic. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Acked-by: Jesse Brandeburg <[EMAIL PROTECTED]> -- Forwarded mes

Re: [XFRM]: Handle DCCP in xfrm{4,6}_decode_session

2005-12-19 Thread David S. Miller
Applied, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [IPV6]: Fix Route Lifetime

2005-12-19 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 00:18:48 +0900 (JST) > [IPV6]: Fix route lifetime. > > The route expiration time is stored in rt6i_expires in jiffies. > The argument of rt6_route_add() for adding a route is not the > expiration time in jiffies nor in clock_t, bu

Re: [PATCH]: Re: SA switchover

2005-12-19 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 08:17:19 -0500 > Just an addendum: If this works it should be sysctl controlled i hope. There is absolutely no reason for that, so no :) > A second approach inspired from your current patch: > Just delete the route cache entry for the one sp

Re: [PATCH] Fix RTNLGRP definitions in rtnetlink.h

2005-12-19 Thread David S. Miller
From: Kristian Slavov <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 13:20:08 +0200 > Tested on 2.6.14.4 with "ip monitor addr" and with the program attached, > while adding and removing IPv6 address. Both programs didn't receive any > messages. > Tested 2.6.14.4 + this patch, and both programs rece

Re: [e2e] SACK performance improvements - technical report and updated 2.6.6 patches

2005-12-19 Thread Craig Partridge
Thanks for sharing! I found the report fun reading in the sense that I don't know of many folks who've worked on slow path performance improvement. However, having written some of these kinds of papers in the past, I'll point out that before it could be considered publishable, it needs a much cl

Re: [Ipsec-tools-devel] Re: [PATCH]: Re: SA switchover

2005-12-19 Thread David S. Miller
From: Krzysztof Oledzki <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 10:37:14 +0100 (CET) > OK. With this patch kernel switches to new SA immediately, but only for > ping. TCP (ssh) session between Cisco and Linux is still protected by the > old SA. Ok, we're making progress :-) When the bundles

Re: [GIT PATCH] SCTP updates (fwd)

2005-12-19 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 13:21:50 -0800 (PST) > It looks like you haven't yet pulled in these patches to your 2.6.16 tree. No, too busy with IPSEC bug fix work :-) > Actually 1 out of the 3 patches is a bugfix and it will be good if it can > go into 2.6.

Re: SACK performance improvements - technical report and updated 2.6.6 patches

2005-12-19 Thread David S. Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Mon, 19 Dec 2005 20:26:54 + > Your comments on this work would be appreciated. Ummm... how about the patches that fix this which are in the 2.6.x kernel already? Yes, it's not your stuff, but it was incredibly less invasive and probably works nearl

Re: [GIT PATCH] SCTP updates (fwd)

2005-12-19 Thread Sridhar Samudrala
On Fri, 9 Dec 2005, David S. Miller wrote: > From: Sridhar Samudrala <[EMAIL PROTECTED]> > Date: Fri, 9 Dec 2005 16:37:11 -0800 (PST) > > > Did you get a chance to look at the following SCTP update? > > If possible, could you add them to your 2.6.15 queue as they are > > SCTP specific changes and

SACK performance improvements - technical report and updated 2.6.6 patches

2005-12-19 Thread Baruch Even
Hello, I wanted to post an update about my work for SACK performance improvements, I've updated the patches on our website and added a technical report on the work so far. It can be found at: http://hamilton.ie/net/research.htm#patches In summary: The Linux stack so far is unable to effectively

Re: [PATCH] Fix RTNLGRP definitions in rtnetlink.h

2005-12-19 Thread Patrick McHardy
Kristian Slavov wrote: Hi, I reported a problem and gave hints to the solution, but nobody seemed to react. So I prepared a patch against 2.6.14.4. Tested on 2.6.14.4 with "ip monitor addr" and with the program attached, while adding and removing IPv6 address. Both programs didn't receive an

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Randy.Dunlap
On Mon, 19 Dec 2005, Arnaldo Carvalho de Melo wrote: > > Many years ago, when I worked on network drivers, (iirc) > > PHY 0 was to be used only if no other PHYs were present, > > so it should be checked last, not first. > > Hey, I should start the Janitor's Driver Development Documentation > Proje

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 09:07:52AM -0800, Randy.Dunlap wrote: > On Mon, 19 Dec 2005, John W. Linville wrote: > > > Hmmm...that seems odd. Of course, that is the way I had it before > > Jeff told me to change it to probe PHY ID 0 last... :-) > > Many years ago, when I worked on network drivers, (

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
On 12/19/05, Randy.Dunlap <[EMAIL PROTECTED]> wrote: > On Mon, 19 Dec 2005, John W. Linville wrote: > > > On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote: > > > On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > > > > > > > @@ -633,7 +643,7 @@ static int __dev

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Randy.Dunlap
On Mon, 19 Dec 2005, John W. Linville wrote: > On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote: > > On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > > > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > > > > > np->phys[0] =

Re: Resend [PATCH netdev-2.6 2/8] e1000: Performance Enhancements

2005-12-19 Thread Robert Olsson
David S. Miller writes: > I think a new variant of netif_receive_skb() might be needed or > maybe not. I don't see a need for a new ->poll() for example. Yes poll should fine as-is for netif_receive_skb we have to see. > On the other hand, nobody checks the return value from > netif

[PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
On 12/19/05, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > On 12/19/05, John W. Linville <[EMAIL PROTECTED]> wrote: > > On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > > > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > > > > > @@ -633,7

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 02:08:58PM -0200, Arnaldo Carvalho de Melo wrote: > On 12/19/05, John W. Linville <[EMAIL PROTECTED]> wrote: > > On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > > > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > > > > > @

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
On 12/19/05, John W. Linville <[EMAIL PROTECTED]> wrote: > On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > np->phys

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote: > On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > > > np->phys[0] = 1;/* Default setting */ > > > >

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Lennert Buytenhek
On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > np->phys[0] = 1;/* Default setting */ > > > np->mii_preamble_required++; > > > - for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy+

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > np->phys[0] = 1;/* Default setting */ > > np->mii_prea

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Lennert Buytenhek
On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > np->phys[0] = 1;/* Default setting */ > np->mii_preamble_required++; > - for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy+

[PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
Hi Jeff, Yesterday I've bought an el-cheapo encore ENL832-TX-ICNT eth card, sundance based, that didn't worked with the in-kernel sundance driver, after some googling I've found this driver: http://www.encore-usa.com/Drivers/ENL832-TX-ICNT_Drivers.zip Merged some bits and got this beast workin

[PATCH] remove bouncing mail address of mv643xx_eth maintainer

2005-12-19 Thread Olaf Hering
Remove bouncing mail address of mv643xx maintainer. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> MAINTAINERS |1 - drivers/net/mv643xx_eth.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.15-rc6-olh/MAINTAINERS =

Re: [PATCH]: Re: SA switchover

2005-12-19 Thread jamal
On Sat, 2005-17-12 at 15:03 -0800, David S. Miller wrote: > From: Krzysztof Oledzki <[EMAIL PROTECTED]> > Date: Fri, 16 Dec 2005 13:15:58 +0100 (CET) > > > Thank you! Will test ASAP. Need day or two, I need to reassemble my > > IPSec netlab. ;) > > Please let me know if it works as soon as you kn

Re: [PATCH] Fix RTNLGRP definitions in rtnetlink.h

2005-12-19 Thread jamal
On Mon, 2005-19-12 at 13:20 +0200, Kristian Slavov wrote: > Hi, > > I reported a problem and gave hints to the solution, but nobody seemed to > react. So I prepared a patch against 2.6.14.4. > > Tested on 2.6.14.4 with "ip monitor addr" and with the program attached, > while adding and removing

[PATCH] Fix RTNLGRP definitions in rtnetlink.h

2005-12-19 Thread Kristian Slavov
Hi, I reported a problem and gave hints to the solution, but nobody seemed to react. So I prepared a patch against 2.6.14.4. Tested on 2.6.14.4 with "ip monitor addr" and with the program attached, while adding and removing IPv6 address. Both programs didn't receive any messages. Tested 2.6.

Re: [Ipsec-tools-devel] Re: [PATCH]: Re: SA switchover

2005-12-19 Thread Krzysztof Oledzki
On Sun, 18 Dec 2005, David S. Miller wrote: From: "David S. Miller" <[EMAIL PROTECTED]> Date: Sun, 18 Dec 2005 13:20:19 -0800 (PST) From: Krzysztof Oledzki <[EMAIL PROTECTED]> Date: Sun, 18 Dec 2005 17:49:50 +0100 (CET) At 17:31:26 kernel executed the one from xfrm_state_add() (Ole #2) but