Re: [PATCH 2/2] add a dev_ioctl fallback to sock_ioctl

2005-12-28 Thread Christoph Hellwig
On Wed, Dec 28, 2005 at 12:17:11AM +0300, Michael Tokarev wrote: > There's something wrong with this new `return' statement. > On my screen it looks like a 'diamond' character instead > of a minus sign -- a character with code 0xAD ;) That's true. Due to some funky terminal interactions I had thi

Re: RFC 2863 patch

2005-12-28 Thread Krzysztof Halasa
"David S. Miller" <[EMAIL PROTECTED]> writes: >> Probably someone else should look at it/them? > > I'm the networking maintainer, you have to wait for me to > get to it. Actually we aren't talking about my patch as you have ignored it for, well, months, and I just gave up. Still, don't you think

Re: RFC 2863 patch

2005-12-28 Thread David S. Miller
From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Wed, 28 Dec 2005 11:06:06 +0100 > Still, don't you think you're way overloaded? How about delegating > part of the job so the development isn't crippled? Most networking patches except your's has been reviewed and integrated. In fact, it's the dam

Re: ipv4 duplicate rules

2005-12-28 Thread jamal
On Tue, 2005-27-12 at 08:33 -0500, jamal wrote: > Using explicit priorities is also "broken". Has been since day > one - Alexey was planning it to fix it "some day". i.e if you > add a second exact same rule with exactly the same prio, it will > be lifo added. OTOH, if you dont specify a priority

Re: RFC 2863 patch

2005-12-28 Thread Krzysztof Halasa
"David S. Miller" <[EMAIL PROTECTED]> writes: > Most networking patches except your's has been reviewed and > integrated. In fact, it's the damn holidays and I'm working on some > stuff I've always wanted to work on for fun and your patch came in > right before that. > > Just be patient, ok, I'll

PATCH: Dummy as IMQ replacement

2005-12-28 Thread jamal
Dave, This is intended for 2.6.16 since it is a new feature. To everyone who has contacted me over the last few months, I apologize for sitting on this for so long (Ive tried to CC a few). I tend to have more time at year end - and so here it is. This patch does not support feature #3 in the thre

Re: PATCH: Dummy as IMQ replacement

2005-12-28 Thread jamal
On Wed, 2005-28-12 at 10:39 -0500, jamal wrote: [..] > I am going to > send an iproute2 patch that is only documentation on usage etc. > Attached. cheers, jamal Documentation on using dummy in place of IMQ Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- diff --git a/doc/actions/action

Re: /sys/class/net//wireless directory

2005-12-28 Thread Ismail Donmez
Pazartesi 26 Aralık 2005 00:32 tarihinde şunları yazmıştınız: > Hi all, > > /sys/class/net//wireless directory seems to be gone in > 2.6.15-rcX kernels. I wonder where to find the information contained there > ( beacon, level, link etc information for the wireless device ) ? Anyone have any idea

Re: PATCH: Dummy as IMQ replacement

2005-12-28 Thread Patrick McHardy
While I have nothing against the idea, the patch needs a lot of cleanup. You seem to add almost as much ifdefed code to dummy as it currently has, which makes me wonder if a completely new device wouldn't be much cleaner. jamal wrote: diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index

Re: PATCH: Dummy as IMQ replacement

2005-12-28 Thread jamal
On Wed, 2005-28-12 at 18:19 +0100, Patrick McHardy wrote: > While I have nothing against the idea, the patch needs a lot > of cleanup. You seem to add almost as much ifdefed code to > dummy as it currently has, which makes me wonder if a completely > new device wouldn't be much cleaner. > Its one

[PATCH] Finish annotations of struct vlan_ethhdr

2005-12-28 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- include/linux/if_vlan.h |2 +- net/8021q/vlan_dev.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -44,7 +44,7 @@ struct vlan_ethhdr { unsigned char

LOW throughput with pktgen and e1000

2005-12-28 Thread Aritz Bastida
Hi everybody: I need to use pktgen for sending packets at very high speed to another machine, in order to test it under heavy network traffic. All my previous injection test were done with a dual Pentium III 800 MHz. As I needed a more powerful machine I got a Pentium 4 but the results are quite s

Re: LOW throughput with pktgen and e1000

2005-12-28 Thread Lennert Buytenhek
On Wed, Dec 28, 2005 at 08:12:18PM +0100, Aritz Bastida wrote: > I need to use pktgen for sending packets at very high speed to another > machine, in order to test it under heavy network traffic. All my > previous injection test were done with a dual Pentium III 800 MHz. As > I needed a more power

Re: [PATCH] Finish annotations of struct vlan_ethhdr

2005-12-28 Thread Al Viro
Applied. BTW, I'm very tempted to annotate s_addr and sin_port at that point; it will create a lot of noise around net/*, though, so depending on the way you keep track of regressions it might be a bad idea right now. I'm only using -D__CHECK_ENDIAN__ on subtree builds, so it's not a problem for

Re: LOW throughput with pktgen and e1000

2005-12-28 Thread Aritz Bastida
Hi. First of all, thank you. It seems the problem may be in there. The PCI buses are actually quite slow. As I told before I have a Pentium 3 with a e1000 card which achieves 350kpps at most. I have also a Pentium 4 with another e1000 card (the specific models were said in the prev mail). This c

LOW throughput with pktgen and e1000

2005-12-28 Thread Robert Olsson
Aritz Bastida writes: > I need to use pktgen for sending packets at very high speed to another > machine, in order to test it under heavy network traffic. All my > previous injection test were done with a dual Pentium III 800 MHz. As > I needed a more powerful machine I got a Pentium 4 but th

Re: LOW throughput with pktgen and e1000

2005-12-28 Thread Jesse Brandeburg
On 12/28/05, Aritz Bastida <[EMAIL PROTECTED]> wrote: > Hi everybody: > > I need to use pktgen for sending packets at very high speed to another > machine, in order to test it under heavy network traffic. All my > previous injection test were done with a dual Pentium III 800 MHz. As > I needed a mo

Re: LOW throughput with pktgen and e1000

2005-12-28 Thread Lennert Buytenhek
On Wed, Dec 28, 2005 at 09:22:09PM +0100, Aritz Bastida wrote: > Hi. Hi, > First of all, thank you. It seems the problem may be in there. The PCI > buses are actually quite slow. As I told before I have a Pentium 3 > with a e1000 card which achieves 350kpps at most. I have also a > Pentium 4 wi

[PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread Kris Katterjohn
Removes needless "filter" variables. Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> --- This is a diff from 2.6.15-rc7 and I'm not subscribed so please CC me on any replies. Thanks! --- x/net/core/sock.c 2005-12-28 15:10:33.0 -0600 +++ y/net/core/sock.c 2005-12-28 15:10:44.

Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Wed, 28 Dec 2005 13:16:55 -0800 > Removes needless "filter" variables. > > Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> I think we need to use a local variable here, since sk->sk_filter can be set to NULL asynchronously to the tests. - To u

Re: Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread Kris Katterjohn
From: David S. Miller > > Removes needless "filter" variables. > > > > Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> > > I think we need to use a local variable here, since sk->sk_filter can > be set to NULL asynchronously to the tests. That makes sense, but the local filter variables are a

Re: IPv6 regression in net-2.6.16

2005-12-28 Thread Mitsuru Chinen
Hi, "David S. Miller" <[EMAIL PROTECTED]> wrote on 2005/12/27 18:11:59: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Tue, 27 Dec 2005 17:08:26 +0900 (JST) > > > Chinen-san has run tests against current net-2.6.16 tree. > > We could run tests (Phase-1 for Host, Phase-2 Core for Host), >

Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Wed, 28 Dec 2005 13:38:02 -0800 > Unless you mean sk_filter could get set to NULL after the test, but > before it's used. That's exactly what I mean. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [

Re: IPv6 regression in net-2.6.16

2005-12-28 Thread David S. Miller
From: Mitsuru Chinen <[EMAIL PROTECTED]> Date: Thu, 29 Dec 2005 07:14:06 +0900 > Here's the result with just the async job changeset reverted. > > http://testlab.linux-ipv6.org/tahi-autorun.2/ct-v6logo2-host_net-2.6.16-20051227_without_async-job-patch/nd.p2/ > > The fails occured at the same tes

[PATCH 1/4] mv643xx: Fix dma_map/dma_unmap calls

2005-12-28 Thread Dale Farnsworth
From: Paolo Galtieri <[EMAIL PROTECTED]> Fix the dma_map/dma_unmap relationships and a NULL pointer dereference. If you do a dma_map_single you must do dma_unmap_single and if you do a dma_map_page you must do a dma_unmap_page. The NULL pointer dereference was caused because the buf_ptr and byte_

[PATCH 2/4] mv643xx: Add multicast support

2005-12-28 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> Add multicast support the the Marvell mv643xx ethernet driver. This code is adapted from code in a ppc-specific version of the driver. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> Index: linux-2.6-mv643xx_enet.git/drivers/net/mv643xx_eth.c ===

[PATCH 3/4] mv643xx: Align receive DMA buffers

2005-12-28 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> The Marvell mv643xx ethernet hardware requires that DMA buffers be aligned to 8-byte boundaries. This patch satisfies this requirement. Buffers allocated by dev_alloc_skb() only have 4-byte alignment when slab debugging is enabled. Also, document that th

[PATCH 4/4] mv643xx: Don't call request_irq with a held lock

2005-12-28 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> We can't call request_irq() while holding a spin lock. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c === --- linux-2.6-mv643xx_en

Re: [PATCH] Remove needless variables in net/core/sock.c

2005-12-28 Thread Kris Katterjohn
From: David S. Miller > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Wed, 28 Dec 2005 13:38:02 -0800 > > > Unless you mean sk_filter could get set to NULL after the test, but > > before it's used. > > That's exactly what I mean. Okey-dokey then. - To unsubscribe from this list: send the

Re: [PATCH 2/4] mv643xx: Add multicast support

2005-12-28 Thread Randy.Dunlap
On Wed, 28 Dec 2005, Dale Farnsworth wrote: > From: Dale Farnsworth <[EMAIL PROTECTED]> > > Add multicast support the the Marvell mv643xx ethernet driver. > > This code is adapted from code in a ppc-specific version of the driver. > > Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> > > Index: l

[PATCH] More instruction checks for net/core/filter.c

2005-12-28 Thread Kris Katterjohn
This only allows valid filter instructions to be passed to the kernel. Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> --- This is a diff from 2.6.15-rc7 and I'm not subscribed so please CC me on replies. I know I've sent a few patches for net/core/filter.c recently, and this should be my l

Re: LOW throughput with pktgen and e1000

2005-12-28 Thread Aritz Bastida
Hello again. First of all, thank you all for your replies. I've been working hard for long days and nights before sending this question, but I guess I'm still too newbie in the Linux kernel and specially with hardware matters such as pci, network card specifications, bus latencies, and so on. Firs

Re: LOW throughput with pktgen and e1000

2005-12-28 Thread Aritz Bastida
Hello again, Now I send you the statistics I have collected in the test I've done. But before, another problem I didn't tell before, because it didn't happen always. But it's quite strange. I have used pktgen in quite a few machines and in all of them, if you say clone_skb=1000 or so, the performa

[PATCH 2/4 rev2] mv643xx: Add multicast support

2005-12-28 Thread Dale Farnsworth
Add multicast support the the Marvell mv643xx ethernet driver. This code is adapted from code in a ppc-specific version of the driver. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- On Wed, Dec 28, 2005 at 11:04:06PM +, Randy.Dunlap wrote: > Just FMI (for my info), what are the sema

Re: 2.6.12.6 to 2.6.14.3 Major 10-GigE TCP Network Performance Degradation

2005-12-28 Thread Bill Fink
On Thu, 15 Dec 2005, Stephen Hemminger wrote: > On Fri, 16 Dec 2005 03:26:31 +0100 > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > On Thu, Dec 15, 2005 at 08:35:32PM -0500, Bill Fink wrote: > > > On Fri, 16 Dec 2005, Andi Kleen wrote: > > > > > > > > It appears that it is getting CPU starved for s