[PATCH] fix a few "warning: 'cleanup_card' defined but not used"

2006-01-03 Thread Denis Vlasenko
These warnings are emitted if non-modular network drivers are built. Fixes just move cleanup_card() definitions into #ifdef MODULE region. -- vda CC drivers/net/wd.o /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/net/wd.c:131: warning: 'cleanup_card' defined but not used CC driv

Re: [ANNOUNCE] RT2x00 ieee80211 stack switch

2006-01-03 Thread Michael Wu
On Monday 02 January 2006 09:22, Ivo van Doorn wrote: > Hi rt2x00-devel & netdev lists, > > First I would like to wish everybody a happy new year! > > Secondly I would like to make the announcement that the rt2x00 project > has decided to switch ieee80211 stack used in the rt2x00-beta series. > I'l

Re: [PATCH 4/4] mv643xx: Don't call request_irq with a held lock

2006-01-03 Thread Olaf Hering
On Wed, Dec 28, Dale Farnsworth wrote: > From: Dale Farnsworth <[EMAIL PROTECTED]> > > We can't call request_irq() while holding a spin lock. This still calls malloc with the lock held. What is the lock trying to protect anyway? Maybe the lock should be moved to the place where the lock is real

Re: [ANNOUNCE] RT2x00 ieee80211 stack switch

2006-01-03 Thread Benjamin Herrenschmidt
On Tue, 2006-01-03 at 04:20 -0500, Michael Wu wrote: > On Monday 02 January 2006 09:22, Ivo van Doorn wrote: > > Hi rt2x00-devel & netdev lists, > > > > First I would like to wish everybody a happy new year! > > > > Secondly I would like to make the announcement that the rt2x00 project > > has deci

Re: [ANNOUNCE] RT2x00 ieee80211 stack switch

2006-01-03 Thread Jiri Benc
Tue, 3 Jan 2006 04:20:52 -0500, Michael Wu wrote: > Jiri, I think it would be a good idea to maintain a tree/patch series that > contains drivers that use the devicescape stack. If enough drivers are > ported, there might be a case for completely scrapping the old code. > Probably not, but I thin

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-03 Thread Graham Gower
012345678901234567890123456789012345678901234567890123456789 On 03/01/06, Roger While <[EMAIL PROTECTED]> wrote: > What makes you think this is in IRQ context ? > Er... yeah. I must have been off my nut when I wrote that comment. A more apt comment should perhaps have been "dev_kfree_skb shouldn'

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-03 Thread Patrick McHardy
Graham Gower wrote: My logs were starting to fill with messages exatcly like that mentioned here: http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840 In any event, the patch at the end of that link was never applied (it doesn't fix the other call to dev_kfree_skb). After applying my

Re: [PATCH] More instruction checks for net/core/filter.c

2006-01-03 Thread Patrick McHardy
Kris Katterjohn wrote: From: Patrick McHardy Because it means a check was missing. We had a number of bad bugs in there before, better to find them quick than have them lurking around until someone does an code audit. But in this case I tend to agree with you, it doesn't seem to affect anything

Re: PATCH: IFB as IMQ replacement

2006-01-03 Thread Patrick McHardy
A few more comments. jamal wrote: +config IFB + tristate "Intermediate Functional Block support" + depends on NET_CLS_ACT + ---help--- + This is an intermidiate driver that allows sharing of + resources. + To compile this driver as a module, choose M her

Incomplete prism2_usb driver available / Evaluating the 802.11 subsystem

2006-01-03 Thread Stefan Rompf
Hi all, to learn about the in kernel 802.11 subsystem, driver writing and wireless in general, I started a project to develop a driver for the prism2/prism3 usb chipset. Goal was to get WPA support and the possibility to configure with wireless extensions. Unfortunately, I was rudely interrupt

[git patches] 2.6.x net driver updates

2006-01-03 Thread Jeff Garzik
Just sent this to Andrew and Linus: Please pull from 'upstream' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to receive the following updates: drivers/net/sk98lin/skproc.c | 265 -- drivers/net/wan/lmc/lmc_prot.h| 15 Documentation/n

Re: [ANNOUNCE] RT2x00 ieee80211 stack switch

2006-01-03 Thread Johannes Berg
On Mon, 2006-01-02 at 15:43 +0100, Jiri Benc wrote: > My todo list currently starts with these items: > How about - get rid of all the embedded algorithms (AES, Michael, RC4, CRC) and use the crypto layer from the kernel - port IPW drivers instead of just moving everything around, get ri

Re: [PATCH] More instruction checks for net/core/filter.c

2006-01-03 Thread Kris Katterjohn
>From : Patrick McHardy >Kris Katterjohn wrote: >> So keep the return statement, then? > >Lets agree on adding WARN_ON(1) before the return statement. Sounds good to me. >> After some googling, I found this OpenBSD kernel code which does a lot of >> what my >> patch would add, but uses BPF_CLASS

Re: [PATCH][2.6.14.5] fix /sys/class/net//wireless without dev->get_wireless_stats

2006-01-03 Thread Ismail Donmez
Salı 3 Ocak 2006 18:52 tarihinde şunları yazmıştınız: > Pazartesi 2 Ocak 2006 19:15 tarihinde şunları yazmıştınız: > > I accidentally used wrong lkml address, so I resend it now with proper > > format. > > > > dev->get_wireless_stats is deprecated but removing it also removes > > wireless subdirect

Re: 2.6.12.6 to 2.6.14.3 Major 10-GigE TCP Network Performance Degradation

2006-01-03 Thread Stephen Hemminger
On Wed, 28 Dec 2005 22:35:50 -0500 Bill Fink <[EMAIL PROTECTED]> wrote: > On Thu, 15 Dec 2005, Stephen Hemminger wrote: > > > On Fri, 16 Dec 2005 03:26:31 +0100 > > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > On Thu, Dec 15, 2005 at 08:35:32PM -0500, Bill Fink wrote: > > > > On Fri, 16 Dec 2

Re: PATCH: Dummy as IMQ replacement

2006-01-03 Thread Stephen Hemminger
On Fri, 30 Dec 2005 11:22:41 -0500 jamal <[EMAIL PROTECTED]> wrote: > On Wed, 2005-28-12 at 10:46 -0500, jamal wrote: > > On Wed, 2005-28-12 at 10:39 -0500, jamal wrote: > > [..] > > > I am going to > > > send an iproute2 patch that is only documentation on usage etc. > > > > > > > Attached. >

IPv6 priority in TC filter

2006-01-03 Thread Devanshu Mehta
Hi, I have recently started to use 'tc' on ipv6 traffic and have come across an issue with tc filter. As per tc_filter.c in iproute2-050816, to match 'priority' of an ipv6 packet, the u32 filter matches against the first 8 bits of the packet. From f_u32.c: if (strcmp(*argv, "priority")

[PATCH]

2006-01-03 Thread Stephen Hemminger
The check for multicast shouldn't exclude broadcast type addresses. This reverts the incorrect change done in 2.6.13. The broadcast address is a multicast address and should be excluded from being a valid_ether_address for use in bridging or device address. Signed-off-by: Stephen Hemminger <[EMAI

[PATCH] build fix for fib_trie

2006-01-03 Thread Stephen Hemminger
Need this to fix build of fib_trie in net-2.6.16 (rebased) tree. The code needs the new inet_make_mask inline. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.16.orig/net/ipv4/fib_trie.c +++ net-2.6.16/net/ipv4/fib_trie.c @@ -66,6 +66,7 @@ #include #include #include +#inclu

Re: [PATCH - 2.6.14.5]x25: fix for broken x25 module

2006-01-03 Thread David S. Miller
From: Shaun Pereira <[EMAIL PROTECTED]> Date: Tue, 03 Jan 2006 16:48:27 +1100 > - > - if (sock_flag(osk, SOCK_ZAPPED)) > - sock_set_flag(sk, SOCK_ZAPPED); > - > - if (sock_flag(osk, SOCK_DBG)) > - sock_set_flag(sk, SOCK_DBG); > + sock_copy_flags(sk, osk); Please get your email setup such that th

Re: [PATCH] forcedeth: TSO fix for large buffers

2006-01-03 Thread Manfred Spraul
Ayaz Abdulla wrote: If you look at the code, I do not set the NV_TX2_VALID bit (stored in np->tx_flags) in the first tx descriptor You are right: tx_flags starts as 0 and is only set to np->tx_flags after the first tx descriptor was set up. I overlooked that point, sorry. Jeff: Could you ad

Re: [PATCH] forcedeth: TSO fix for large buffers

2006-01-03 Thread Ayaz Abdulla
If you look at the code, I do not set the NV_TX2_VALID bit (stored in np->tx_flags) in the first tx descriptor until all other descriptors for this transmit are setup. This ensures hardware will not look at it. Once all fragments/descriptors are setup, I setup the control bits for the first tx

Re: [PATCH] speed up __alloc_skb

2006-01-03 Thread David S. Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Fri, 16 Dec 2005 14:52:01 -0500 > In __alloc_skb(), the use of skb_shinfo() which casts a u8 * to the > shared info structure results in gcc being forced to do a reload of the > pointer since it has no information on possible aliasing. Fix this b

Re: [PATCH] convert af_unix to use a spinlock instead of rwlock

2006-01-03 Thread David S. Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Fri, 16 Dec 2005 15:01:41 -0500 > In af_unix, a rwlock is used to protect internal state. At least on my > P4 with HT it is faster to use a spinlock due to the simpler memory > barrier used to unlock. This patch raises bw_unix to ~690K/s. Also

Re: [PATCH 1/2] remove unessecary lock_sock calls in netrom_ioctl

2006-01-03 Thread David S. Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Tue, 27 Dec 2005 19:51:20 +0100 > lock_sock is needed only in very few cases, so do it there instead of > around the switch statement. > > Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Applied, thanks Christoph. - To unsubscribe from this

Re: [PATCH 2/2] add a dev_ioctl fallback to sock_ioctl

2006-01-03 Thread David S. Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Tue, 27 Dec 2005 19:53:05 +0100 > Currently all network protocols need to call dev_ioctl as the default > fallback in their ioctl implementations. This patch adds a fallback > to dev_ioctl to sock_ioctl if the protocol returned -ENOIOCTLCMD. > Thi

Re: [PATCH] gnetlink: consistent command type

2006-01-03 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Tue, 27 Dec 2005 10:27:24 -0500 > This minor bug fix should probably go into 2.6.15. Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.

Re: [PATCH] tg3: fixup tot_len calculation

2006-01-03 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Wed, 28 Dec 2005 03:51:04 +0300 > Turning struct iphdr::tot_len into __be16 added sparse warning. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks Alexey. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] DECnet: Only use local routers

2006-01-03 Thread David S. Miller
From: Patrick Caulfield <[EMAIL PROTECTED]> Date: Sat, 31 Dec 2005 14:14:49 + > The attached patch makes DECnet routing only use routers from the same area - > rather than the highest rated router seen. > > In theory there should not be an out-of-area router on a local network but > some netw

Re: [PATCH-2.6] cleanup IP_VS_DBG statements

2006-01-03 Thread David S. Miller
From: Horms <[EMAIL PROTECTED]> Date: Fri, 30 Dec 2005 13:02:30 +0900 > Dave, please apply. Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH]

2006-01-03 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 3 Jan 2006 11:42:24 -0800 > The check for multicast shouldn't exclude broadcast type addresses. > This reverts the incorrect change done in 2.6.13. > > The broadcast address is a multicast address and should be excluded > from being a valid_e

Re: [PATCH] build fix for fib_trie

2006-01-03 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 3 Jan 2006 11:49:49 -0800 > Need this to fix build of fib_trie in net-2.6.16 (rebased) tree. > The code needs the new inet_make_mask inline. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe f

Re: [PATCH] is_multicast_ether_addr

2006-01-03 Thread Stephen Hemminger
On Tue, 03 Jan 2006 14:38:03 -0800 (PST) "David S. Miller" <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 3 Jan 2006 11:42:24 -0800 > > > The check for multicast shouldn't exclude broadcast type addresses. > > This reverts the incorrect change done in 2.6.13

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-03 Thread Graham Gower
On 03/01/06, Patrick McHardy <[EMAIL PROTECTED]> wrote: > Graham Gower wrote: > > My logs were starting to fill with messages exatcly like that mentioned > > here: > > http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840 > > > > In any event, the patch at the end of that link was never

Re: [PATCH] is_multicast_ether_addr

2006-01-03 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 3 Jan 2006 14:51:22 -0800 > The GIT history I found was: > > 0. originally is_valid_ether() did !((addr[0] & 1) || is_zero_addr(addr)) > 1. is_multicast_addr separated from is_valid_ether > 2. Jeff introduced the (addr[0] != 0xff) as part of

[PATCH] tcp: less inline's

2006-01-03 Thread Stephen Hemminger
TCP inline usage cleanup: * get rid of inline in several places * replace __inline__ with inline where possible * move functions used in one file out of tcp.h * let compiler decide on used once cases On x86_64: textdata bss dec hex filename 3594701 648348 567400 4810449

Re: [PATCH] tcp: less inline's

2006-01-03 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 3 Jan 2006 15:40:32 -0800 > TCP inline usage cleanup: > * get rid of inline in several places > * replace __inline__ with inline where possible > * move functions used in one file out of tcp.h > * let compiler decide on used once cases >

RFC: Building a special bridge behaviour/module for wireless.

2006-01-03 Thread Ben Greear
I am working on a WiFi virtual station emulator, and need a bastardized version of a bridge to make it work. The basic idea is to have a linux based AP that supports virtual wifi clients (it actually won't be acting as an AP at all). There are proprietary stacks that support this, and hopefully

[PATCH] TCP_Vegas: Fix slow start

2006-01-03 Thread Tom Young
Vegas' slow start was only adding one MSS per RTT rather than one for every ack. Slow start behavior should now match Reno. Signed-off-by: Thomas Young <[EMAIL PROTECTED]> --- net/ipv4/tcp_vegas.c |4 1 files changed, 4 insertions(+), 0 deletions(-) aa4db8a59aede2955461910e1516826fd8

Re: [PATCH (should be ready to apply)] More instruction checks for net/core/filter.c

2006-01-03 Thread Kris Katterjohn
I changed the sk_chk_filter() comment slightly, but that is the only change since the patch I posted earlier today. This should now be ready to be applied, unless any new reason is seen not to. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Sorry to send a whole new email, but I thought I'd

[PATCH 1/4][DCCP] ackvec: Fix spelling of "throw"

2006-01-03 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git Best Regards, - Arnaldo tree 999897434bf2f6e7ad905f28949bed30ae76e279 parent 40efc6fa179f440a008333ea98f701bc35a1f97f author Andrea Bittau <[EMAIL PROTECTED]> 1136346317 -0200 committer Arnaldo

[PATCH 2/4][DCCP] ackvec: use u8 for the buf offsets

2006-01-03 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git Best Regards, - Arnaldo tree cf5ca5bb82cc5e7ef01a368bf6b86029266bc146 parent 6742bbcbb8a0959e1dff0ce055768e3217d9967a author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1136346394 -0200 commit

[PATCH 4/4][IPVS]: Add missing include

2006-01-03 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git Best Regards, - Arnaldo tree 322e5309316ce619cb354c517186b35019026cbc parent 80e40daa4797a156781d1594642b654eb1c461df author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1136347340 -0200 commit

[PATCH 3/4][TCP]: syn_flood_warning is only needed if CONFIG_SYN_COOKIES is selected

2006-01-03 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git Best Regards, - Arnaldo tree 31a9a37e00b690edf3e54d61393e364f203549c3 parent e4dfd449c80a41bb615b23d0fc198ba08360a1f8 author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1136347086 -0200 commit

Re: [PATCH 1/4][DCCP] ackvec: Fix spelling of "throw"

2006-01-03 Thread David S. Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Wed, 4 Jan 2006 02:12:32 -0200 > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git All pulled, thanks Arnaldo. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH (should be ready to apply)] More instruction checks for net/core/filter.c

2006-01-03 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Tue, 3 Jan 2006 20:03:03 -0800 > --- x/net/core/filter.c 2006-01-03 11:09:07.0 -0600 > +++ y/net/core/filter.c 2006-01-03 21:42:02.0 -0600 > @@ -13,6 +13,7 @@ > * 2 of the License, or (at your option) any later version.

Re: [PATCH] TCP_Vegas: Fix slow start

2006-01-03 Thread David S. Miller
From: Tom Young <[EMAIL PROTECTED]> Date: Wed, 04 Jan 2006 14:23:47 +1100 > Vegas' slow start was only adding one MSS per RTT rather than one for > every ack. Slow start behavior should now match Reno. > > Signed-off-by: Thomas Young <[EMAIL PROTECTED]> Your email client has corrupted the spacin

Re: [PATCH] TCP_Vegas: Fix slow start

2006-01-03 Thread Tom Young
On Tue, 2006-01-03 at 21:22 -0800, David S. Miller wrote: > From: Tom Young <[EMAIL PROTECTED]> > Date: Wed, 04 Jan 2006 14:23:47 +1100 > > > Vegas' slow start was only adding one MSS per RTT rather than one for > > every ack. Slow start behavior should now match Reno. > > > > Signed-off-by: Thom

Re: [PATCH] forcedeth: TSO fix for large buffers

2006-01-03 Thread Andrew Morton
Manfred Spraul <[EMAIL PROTECTED]> wrote: > > This patch contains a bug fix for large buffers. Originally, if a tx > buffer to be sent was larger then the maximum size of the tx descriptor, > > it would overwrite other control bits. In this patch, the buffer is > split over multiple descripto

Re: Resubmit: [PATCH] natsemi: NAPI support

2006-01-03 Thread Mark Brown
This patch against 2.6.14 converts the natsemi driver to use NAPI. It was originally based on one written by Harald Welte, though it has since been modified quite a bit, most extensively in order to remove the ability to disable NAPI since none of the other drivers seem to provide that functionali